-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rdbms casts #3485
Rdbms casts #3485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
==========================================
+ Coverage 80.92% 80.94% +0.02%
==========================================
Files 416 416
Lines 32352 32368 +16
==========================================
+ Hits 26180 26200 +20
+ Misses 6172 6168 -4
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
3793f37
to
89ab676
Compare
This comment has been minimized.
This comment has been minimized.
89ab676
to
73e02d9
Compare
small_tests_24 / small_tests / 73e02d9 small_tests_23 / small_tests / 73e02d9 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 73e02d9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 73e02d9 dynamic_domains_mysql_redis_24 / mysql_redis / 73e02d9 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 73e02d9 ldap_mnesia_24 / ldap_mnesia / 73e02d9 ldap_mnesia_23 / ldap_mnesia / 73e02d9 internal_mnesia_24 / internal_mnesia / 73e02d9 pgsql_mnesia_24 / pgsql_mnesia / 73e02d9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 73e02d9 pgsql_mnesia_23 / pgsql_mnesia / 73e02d9 mysql_redis_24 / mysql_redis / 73e02d9 mssql_mnesia_24 / odbc_mssql_mnesia / 73e02d9 muc_SUITE:register:user_changes_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"08d65da73360f2be1d078e4c99f43070">>},
{<<"to">>,<<"muc.localhost">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-a6e3ee14e4">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"muc.localhost">>},
{<<"to">>,<<"alicE_user_changes_nick_1777@localhost/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"08d65da73360f2be1d078e4c99f43070">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,... riak_mnesia_24 / riak_mnesia / 73e02d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
Sometimes we might want to throw inserts without caring about the return value, so we don't need to block the c2s process for the DB worker to return. To be used carefully, it can overload the DB workers as the c2s process might then, unblocked, generate load faster than the DB workers might clear it.