Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdbms casts #3485

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Rdbms casts #3485

merged 2 commits into from
Jan 4, 2022

Conversation

NelsonVides
Copy link
Collaborator

Sometimes we might want to throw inserts without caring about the return value, so we don't need to block the c2s process for the DB worker to return. To be used carefully, it can overload the DB workers as the c2s process might then, unblocked, generate load faster than the DB workers might clear it.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #3485 (73e02d9) into master (1262811) will increase coverage by 0.02%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
+ Coverage   80.92%   80.94%   +0.02%     
==========================================
  Files         416      416              
  Lines       32352    32368      +16     
==========================================
+ Hits        26180    26200      +20     
+ Misses       6172     6168       -4     
Impacted Files Coverage Δ
src/rdbms/mongoose_rdbms.erl 63.29% <63.63%> (+0.34%) ⬆️
src/http_upload/mod_http_upload.erl 94.62% <0.00%> (-2.16%) ⬇️
src/logger/mongoose_log_filter.erl 78.08% <0.00%> (-1.37%) ⬇️
src/pubsub/mod_pubsub.erl 73.31% <0.00%> (+0.11%) ⬆️
src/mod_muc_rdbms.erl 95.93% <0.00%> (+0.81%) ⬆️
src/mod_muc.erl 75.67% <0.00%> (+0.90%) ⬆️
src/wpool/mongoose_wpool.erl 86.53% <0.00%> (+0.96%) ⬆️
src/mam/mod_mam_rdbms_arch_async.erl 97.87% <0.00%> (+1.06%) ⬆️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 73.58% <0.00%> (+1.88%) ⬆️
src/mod_private.erl 83.05% <0.00%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1262811...73e02d9. Read the comment docs.

@mongoose-im

This comment has been minimized.

@mongoose-im

This comment has been minimized.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 4, 2022

small_tests_24 / small_tests / 73e02d9
Reports root / small


small_tests_23 / small_tests / 73e02d9
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 73e02d9
Reports root/ big
OK: 2689 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 73e02d9
Reports root/ big
OK: 2689 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 73e02d9
Reports root/ big
OK: 2672 / Failed: 0 / User-skipped: 247 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 73e02d9
Reports root/ big
OK: 2689 / Failed: 0 / User-skipped: 230 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 73e02d9
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 389 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 73e02d9
Reports root/ big
OK: 1501 / Failed: 0 / User-skipped: 389 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 73e02d9
Reports root/ big
OK: 1542 / Failed: 0 / User-skipped: 348 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 73e02d9
Reports root/ big
OK: 3076 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 73e02d9
Reports root/ big
OK: 1835 / Failed: 0 / User-skipped: 360 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 73e02d9
Reports root/ big
OK: 3076 / Failed: 0 / User-skipped: 239 / Auto-skipped: 0


mysql_redis_24 / mysql_redis / 73e02d9
Reports root/ big
OK: 3071 / Failed: 0 / User-skipped: 244 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 73e02d9
Reports root/ big
OK: 3081 / Failed: 1 / User-skipped: 239 / Auto-skipped: 0

muc_SUITE:register:user_changes_nick
{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"08d65da73360f2be1d078e4c99f43070">>},
         {<<"to">>,<<"muc.localhost">>}],
        [{xmlel,<<"query">>,
           [{<<"xmlns">>,<<"jabber:iq:register">>}],
           [{xmlel,<<"x">>,
            [{<<"xmlns">>,<<"jabber:x:data">>},
             {<<"type">>,<<"submit">>}],
            [{xmlel,<<"field">>,
               [{<<"type">>,<<"hidden">>},
                {<<"var">>,<<"FORM_TYPE">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,<<"jabber:iq:register">>}]}]},
             {xmlel,<<"field">>,
               [{<<"type">>,<<"text-single">>},
                {<<"var">>,<<"nick">>}],
               [{xmlel,<<"value">>,[],
                  [{xmlcdata,
                     <<"thirdwitch1room-a6e3ee14e4">>}]}]}]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,<<"muc.localhost">>},
        {<<"to">>,<<"alicE_user_changes_nick_1777@localhost/res1">>},
        {<<"type">>,<<"error">>},
        {<<"xml:lang">>,<<"en">>},
        {<<"id">>,<<"08d65da73360f2be1d078e4c99f43070">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:register">>}],
          [{xmlel,<<"x">>,
             [{<<"xmlns">>,<<"jabber:x:data">>},
            {<<"type">>,<<"submit">>}],
             [{xmlel,<<"field">>,
              [{<<"type">>,<<"hidden">>},
               {<<"var">>,<<"FORM_TYPE">>}],
              [{xmlel,<<"value">>,...

Report log


riak_mnesia_24 / riak_mnesia / 73e02d9
Reports root/ big
OK: 1681 / Failed: 0 / User-skipped: 361 / Auto-skipped: 0

Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@arcusfelis arcusfelis merged commit ac670f8 into master Jan 4, 2022
@arcusfelis arcusfelis deleted the rdbms_casts branch January 4, 2022 13:58
@Premwoik Premwoik added this to the 5.1.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants