Test config parsing with post-processing #3507
Conversation
|
small_tests_24 / small_tests / 981e082 small_tests_23 / small_tests / 981e082 dynamic_domains_mysql_redis_24 / mysql_redis / 981e082 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 981e082 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 981e082 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 981e082 ldap_mnesia_23 / ldap_mnesia / 981e082 ldap_mnesia_24 / ldap_mnesia / 981e082 internal_mnesia_24 / internal_mnesia / 981e082 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 981e082 pgsql_mnesia_24 / pgsql_mnesia / 981e082 mysql_redis_24 / mysql_redis / 981e082 riak_mnesia_24 / riak_mnesia / 981e082 mssql_mnesia_24 / odbc_mssql_mnesia / 981e082 |
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
==========================================
+ Coverage 80.96% 80.97% +0.01%
==========================================
Files 418 418
Lines 32329 32329
==========================================
+ Hits 26174 26179 +5
+ Misses 6155 6150 -5
Continue to review full report at Codecov.
|
This change makes it possible to test config post-processing, i.e. - Repeating global options for each host (type) - Module dependencies - Aggregation of acl's and access rules (in the future) Related changes: - Module options are checked selectively because deps are now present (only the checked module instead of all) - New function 'compare_nodes/3' is used for more organized comparison of config tree nodes - HOST_TYPE is changed to HOST because some modules don't support dynamic domains yet. Before it was working only because it referred to an undefined host type and thus it managed to circumvent the check.
chrzaszcz
force-pushed
the
test-full-config-processing
branch
from
981e082 to
80f1e25
Compare
|
small_tests_24 / small_tests / 80f1e25 small_tests_23 / small_tests / 80f1e25 dynamic_domains_mysql_redis_24 / mysql_redis / 80f1e25 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 80f1e25 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 80f1e25 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 80f1e25 ldap_mnesia_23 / ldap_mnesia / 80f1e25 ldap_mnesia_24 / ldap_mnesia / 80f1e25 internal_mnesia_24 / internal_mnesia / 80f1e25 pgsql_mnesia_23 / pgsql_mnesia / 80f1e25 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 80f1e25 pgsql_mnesia_24 / pgsql_mnesia / 80f1e25 mssql_mnesia_24 / odbc_mssql_mnesia / 80f1e25 mysql_redis_24 / mysql_redis / 80f1e25 riak_mnesia_24 / riak_mnesia / 80f1e25 |
Call
processinstead ofparseinconfig_parser_SUITEThis makes it possible to test config post-processing, i.e.
Related changes:
compare_nodes/3is used for more organized comparison of config tree nodesHOST_TYPEis changed toHOSTbecause some modules don't support dynamic domains yet. Before it was working only because it referred to an undefined host type and thus it managed to circumvent the check.Note:
host_keyhelper will be simplified in the upcoming PR, removing theHostTypeargument as it is only required for shaper/acl/access now - only these options have this host-or-global resulting format, others are stored only per host type.