-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphql stanza client API #3565
Conversation
small_tests_24 / small_tests / c862839 small_tests_23 / small_tests / c862839 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / c862839 dynamic_domains_mysql_redis_24 / mysql_redis / c862839 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c862839 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / c862839 ldap_mnesia_23 / ldap_mnesia / c862839 graphql_stanza_SUITE:user_stanza_caregory:user_send_message_without_from{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_without_from_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,128}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_message{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_get_last_messages{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{graphql_stanza_SUITE,user_get_last_messages_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,316}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_stanza{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} ldap_mnesia_24 / ldap_mnesia / c862839 graphql_stanza_SUITE:user_stanza_caregory:user_send_stanza{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_message_without_from{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_without_from_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,128}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_message{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_get_last_messages{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{graphql_stanza_SUITE,user_get_last_messages_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,316}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} internal_mnesia_24 / internal_mnesia / c862839 graphql_stanza_SUITE:user_stanza_caregory:user_send_message{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_get_last_messages{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,114}]},
{graphql_stanza_SUITE,user_get_last_messages_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,316}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_stanza{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stanza_SUITE:user_stanza_caregory:user_send_message_without_from{error,
{function_clause,
[{graphql_stanza_SUITE,assert_not_empty,[<<>>],[]},
{graphql_stanza_SUITE,user_send_message_without_from_story,3,
[{file,
"/home/circleci/project/big_tests/tests/graphql_stanza_SUITE.erl"},
{line,128}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_23 / pgsql_mnesia / c862839 mysql_redis_24 / mysql_redis / c862839 pgsql_mnesia_24 / pgsql_mnesia / c862839 mssql_mnesia_24 / odbc_mssql_mnesia / c862839 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / c862839 riak_mnesia_24 / riak_mnesia / c862839 |
Codecov Report
@@ Coverage Diff @@
## feature/graphql #3565 +/- ##
===================================================
+ Coverage 81.42% 81.44% +0.01%
===================================================
Files 456 458 +2
Lines 33068 33102 +34
===================================================
+ Hits 26927 26959 +32
- Misses 6141 6143 +2
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 9637f5a small_tests_23 / small_tests / 9637f5a dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9637f5a dynamic_domains_mysql_redis_24 / mysql_redis / 9637f5a dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 9637f5a dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 9637f5a ldap_mnesia_24 / ldap_mnesia / 9637f5a ldap_mnesia_23 / ldap_mnesia / 9637f5a rest_client_SUITE:messages:msg_is_sent_and_delivered_over_sse{error,{{badmap,{error,timeout}},
[{erlang,map_get,[data,{error,timeout}],[]},
{rest_client_SUITE,msg_is_sent_and_delivered_over_sse,1,
[{file,"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,217}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} internal_mnesia_24 / internal_mnesia / 9637f5a pgsql_mnesia_23 / pgsql_mnesia / 9637f5a elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 9637f5a pgsql_mnesia_24 / pgsql_mnesia / 9637f5a mysql_redis_24 / mysql_redis / 9637f5a mssql_mnesia_24 / odbc_mssql_mnesia / 9637f5a riak_mnesia_24 / riak_mnesia / 9637f5a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me generally :) I left minor comments
small_tests_24 / small_tests / 9567035 small_tests_23 / small_tests / 9567035 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 9567035 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9567035 dynamic_domains_mysql_redis_24 / mysql_redis / 9567035 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 9567035 ldap_mnesia_23 / ldap_mnesia / 9567035 ldap_mnesia_24 / ldap_mnesia / 9567035 internal_mnesia_24 / internal_mnesia / 9567035 mysql_redis_24 / mysql_redis / 9567035 pgsql_mnesia_23 / pgsql_mnesia / 9567035 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 9567035 pgsql_mnesia_24 / pgsql_mnesia / 9567035 mssql_mnesia_24 / odbc_mssql_mnesia / 9567035 riak_mnesia_24 / riak_mnesia / 9567035 |
9567035
to
b00766d
Compare
b00766d
to
df10013
Compare
df10013
to
8b2a5b1
Compare
small_tests_24 / small_tests / 8b2a5b1 small_tests_23 / small_tests / 8b2a5b1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8b2a5b1 amp_big_SUITE:offline:offline_failure:notify_deliver_to_unknown_domain_test{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_notify_deliver_to_unknown_domain_test_344@domain.example.com/res1">>,
escalus_tcp,<0.7401.0>,
[{event_manager,<0.7192.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_344">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.7192.0>},
{server,<<"domain.example.com">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_344">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_344">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,
<<"alicE_notify_deliver_to_unknown_domain_test_344">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"3f44b88ad15a9d66">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{amp_big_SUITE,client_receives_generic_error,3,
[{file,
"/home/circleci/project/big_t... dynamic_domains_mysql_redis_24 / mysql_redis / 8b2a5b1 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 8b2a5b1 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 8b2a5b1 ldap_mnesia_24 / ldap_mnesia / 8b2a5b1 ldap_mnesia_23 / ldap_mnesia / 8b2a5b1 internal_mnesia_24 / internal_mnesia / 8b2a5b1 mysql_redis_24 / mysql_redis / 8b2a5b1 pgsql_mnesia_24 / pgsql_mnesia / 8b2a5b1 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 8b2a5b1 pgsql_mnesia_23 / pgsql_mnesia / 8b2a5b1 mssql_mnesia_24 / odbc_mssql_mnesia / 8b2a5b1 riak_mnesia_24 / riak_mnesia / 8b2a5b1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8b2a5b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Nice idea with creating this behavior :) I added one comment.
small_tests_23 / small_tests / 5507a78 small_tests_24 / small_tests / 5507a78 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 5507a78 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5507a78 dynamic_domains_mysql_redis_24 / mysql_redis / 5507a78 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 5507a78 ldap_mnesia_23 / ldap_mnesia / 5507a78 ldap_mnesia_24 / ldap_mnesia / 5507a78 pgsql_mnesia_24 / pgsql_mnesia / 5507a78 internal_mnesia_24 / internal_mnesia / 5507a78 pgsql_mnesia_23 / pgsql_mnesia / 5507a78 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5507a78 mssql_mnesia_24 / odbc_mssql_mnesia / 5507a78 mysql_redis_24 / mysql_redis / 5507a78 riak_mnesia_24 / riak_mnesia / 5507a78 |
Proposed changes include: