-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put mod_stream_management config opts in a map #3571
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3571 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 424 424
Lines 32301 32292 -9
=======================================
- Hits 26161 26156 -5
+ Misses 6140 6136 -4
Continue to review full report at Codecov.
|
ff5f652
to
7b5ce06
Compare
This comment was marked as outdated.
This comment was marked as outdated.
7b5ce06
to
76a9b27
Compare
This comment was marked as outdated.
This comment was marked as outdated.
76a9b27
to
0b51fe6
Compare
small_tests_24 / small_tests / 0b51fe6 small_tests_23 / small_tests / 0b51fe6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0b51fe6 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 0b51fe6 dynamic_domains_mysql_redis_24 / mysql_redis / 0b51fe6 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 0b51fe6 ldap_mnesia_23 / ldap_mnesia / 0b51fe6 ldap_mnesia_24 / ldap_mnesia / 0b51fe6 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 0b51fe6 internal_mnesia_24 / internal_mnesia / 0b51fe6 pgsql_mnesia_23 / pgsql_mnesia / 0b51fe6 pgsql_mnesia_24 / pgsql_mnesia / 0b51fe6 mssql_mnesia_24 / odbc_mssql_mnesia / 0b51fe6 mysql_redis_24 / mysql_redis / 0b51fe6 riak_mnesia_24 / riak_mnesia / 0b51fe6 |
0b51fe6
to
fc68049
Compare
small_tests_24 / small_tests / fc68049 small_tests_23 / small_tests / fc68049 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / fc68049 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fc68049 dynamic_domains_mysql_redis_24 / mysql_redis / fc68049 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / fc68049 ldap_mnesia_23 / ldap_mnesia / fc68049 pubsub_SUITE:dag+basic:subscribe_options_test{error,{{badmatch,{{<<"pubsub#deliver">>,<<"boolean">>,<<"false">>},
<<"pubsub#deliver">>}},
[{pubsub_tools,'-verify_form_values/2-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,649}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,460}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} ldap_mnesia_24 / ldap_mnesia / fc68049 internal_mnesia_24 / internal_mnesia / fc68049 mysql_redis_24 / mysql_redis / fc68049 pgsql_mnesia_24 / pgsql_mnesia / fc68049 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / fc68049 mssql_mnesia_24 / odbc_mssql_mnesia / fc68049 riak_mnesia_24 / riak_mnesia / fc68049 |
efd5f63
to
7d788c2
Compare
small_tests_24 / small_tests / 7d788c2 small_tests_23 / small_tests / 7d788c2 dynamic_domains_mysql_redis_24 / mysql_redis / 7d788c2 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7d788c2 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7d788c2 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7d788c2 rest_client_SUITE:roster:add_contact_and_invite{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"alicE_add_contact_and_invite_1902@domain.example.com/res1">>,
escalus_tcp,<0.26007.1>,
[{event_manager,<0.25971.1>},
{server,<<"domain.example.com">>},
{username,<<"alicE_add_contact_and_invite_1902">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.25971.1>},
{server,<<"domain.example.com">>},
{username,<<"alicE_add_contact_and_invite_1902">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alicE_add_contact_and_invite_1902">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alicE_add_contact_and_invite_1902">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"matygrysa">>},
{stream_id,<<"e2238b828318fe96">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1106}]},
{escalus_story,story,4,
[{file,
"/... ldap_mnesia_23 / ldap_mnesia / 7d788c2 ldap_mnesia_24 / ldap_mnesia / 7d788c2 internal_mnesia_24 / internal_mnesia / 7d788c2 pgsql_mnesia_23 / pgsql_mnesia / 7d788c2 pgsql_mnesia_24 / pgsql_mnesia / 7d788c2 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7d788c2 mysql_redis_24 / mysql_redis / 7d788c2 mssql_mnesia_24 / odbc_mssql_mnesia / 7d788c2 riak_mnesia_24 / riak_mnesia / 7d788c2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, I added minor comments.
small_tests_24 / small_tests / 9155c8b small_tests_23 / small_tests / 9155c8b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9155c8b dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 9155c8b dynamic_domains_mysql_redis_24 / mysql_redis / 9155c8b ldap_mnesia_23 / ldap_mnesia / 9155c8b dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 9155c8b ldap_mnesia_24 / ldap_mnesia / 9155c8b internal_mnesia_24 / internal_mnesia / 9155c8b mysql_redis_24 / mysql_redis / 9155c8b pgsql_mnesia_23 / pgsql_mnesia / 9155c8b mssql_mnesia_24 / odbc_mssql_mnesia / 9155c8b pgsql_mnesia_24 / pgsql_mnesia / 9155c8b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 9155c8b jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,293}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}... metrics_api_SUITE:all_metrics_are_global:init_per_group{'EXIT',{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost,timeout => 30000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{distributed_helper,add_node_to_cluster,2,
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,29}]},
{metrics_helper,prepare_by_all_metrics_are_global,2,
[{file,"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,44}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mod_global_distrib_SUITE:init_per_suite{'EXIT',
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost,timeout => 30000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{mongoose_helper,successful_rpc,5,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,291}]},
{mod_global_distrib_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/mod_global_distrib_SUITE.erl"},
{line,124}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mongooseimctl_SUITE:basic:backup_restore_mnesia{error,{{badmatch,{"Can't store backup in \"/home/circleci/project/_build/mim1/rel/mongooseim/backup_mnesia.bup\" at node mongooseim@localhost: {\"Cannot prepare checkpoint (replica not available)\",\n [jingle_sip_session,\n {238082,\n mongooseim@localhost}]}\n",
1}},
[{mongooseimctl_SUITE,backup_restore_mnesia,1,
[{file,"/home/circleci/project/big_tests/tests/mongooseimctl_SUITE.erl"},
{line,1154}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} rest_client_SUITE:security:non_default_http_server_name_is_returned_if_configured{error,
{{badrpc,
{'EXIT',
{badarg,
[{persistent_term,get,
[{mongoose_config,listen}],
[{error_info,#{module => erl_erts_errors}}]},
{mongoose_config,get_opt,1,
[{file,
"/home/circleci/project/src/config/mongoose_config.erl"},
{line,118}]}]}}},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost},mongoose_config,get_opt,[listen]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{rest_helper,get_port,3,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,250}]},
{rest_helper,fusco_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,206}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,143}]},
{rest_client_SUITE,verify_server_name_in_header,2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1363}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} rest_client_SUITE:security:non_default_http_server_name_is_returned_if_configured{error,
{{badrpc,
{'EXIT',
{badarg,
[{persistent_term,get,
[{mongoose_config,listen}],
[{error_info,#{module => erl_erts_errors}}]},
{mongoose_config,get_opt,1,
[{file,
"/home/circleci/project/src/config/mongoose_config.erl"},
{line,118}]}]}}},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost},mongoose_config,get_opt,[listen]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{rest_helper,get_port,3,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,250}]},
{rest_helper,fusco_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,206}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,143}]},
{rest_client_SUITE,verify_server_name_in_header,2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1363}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} rest_client_SUITE:security:non_default_http_server_name_is_returned_if_configured{error,
{{badrpc,
{'EXIT',
{badarg,
[{persistent_term,get,
[{mongoose_config,listen}],
[{error_info,#{module => erl_erts_errors}}]},
{mongoose_config,get_opt,1,
[{file,
"/home/circleci/project/src/config/mongoose_config.erl"},
{line,118}]}]}}},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost},mongoose_config,get_opt,[listen]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{rest_helper,get_port,3,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,250}]},
{rest_helper,fusco_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,206}]},
{rest_helper,make_request,1,
[{file,"/home/circleci/project/big_tests/tests/rest_helper.erl"},
{line,143}]},
{rest_client_SUITE,verify_server_name_in_header,2,
[{file,
"/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
{line,1363}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} service_mongoose_system_metrics_SUITE:end_per_suite{error,
{{badrpc,
{'EXIT',
{badarg,
[{ets,member,
[mongoose_services,service_mongoose_system_metrics],
[{error_info,
#{cause => id,module => erl_stdlib_errors}}]},
{mongoose_service,is_loaded,1,
[{file,
"/home/circleci/project/src/mongoose_service.erl"},
{line,106}]},
{mongoose_service,start_service,2,
[{file,
"/home/circleci/project/src/mongoose_service.erl"},
{line,68}]}]}}},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost},
mongoose_service,start_service,
[service_mongoose_system_metrics,
[{initial_report,20000},{periodic_report,300000}]]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_mongoose_system_metrics_SUITE,'-end_per_suite/1-lc$^0/1-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,123}]},
{service_mongoose_system_metrics_SUITE,end_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_mongoose_system_metrics_SUITE.erl"},
{line,123}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} service_domain_db_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{badarg,
[{ets,member,
[mongoose_services,service_domain_db],
[{error_info,
#{cause => id,module => erl_stdlib_errors}}]},
{mongoose_service,is_loaded,1,
[{file,
"/home/circleci/project/src/mongoose_service.erl"},
{line,106}]}]}}},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost},
mongoose_service,is_loaded,
[service_domain_db]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,store_conf,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,194}]},
{service_domain_db_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,177}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_SUITE:init_per_suite{'EXIT',
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => ejabberd2@localhost,timeout => 30000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{distributed_helper,add_node_to_cluster,2,
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,29}]},
{dynamic_domains_SUITE,cluster_nodes,2,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_domains_SUITE.erl"},
{line,210}]},
{dynamic_domains_SUITE,init_per_suite,1,
[{file,
"/home/circleci/project/big_tests/tests/dynamic_domains_SUITE.erl"},
{line,32}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 9155c8b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 9155c8b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine 👍
Stream management options in a map with defaults.