-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate segmented cache to maps #3572
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3572 +/- ##
==========================================
- Coverage 81.01% 81.00% -0.01%
==========================================
Files 424 424
Lines 32337 32339 +2
==========================================
- Hits 26198 26197 -1
- Misses 6139 6142 +3
Continue to review full report at Codecov.
|
ddc4ae0
to
a47d0e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / d48e84b small_tests_23 / small_tests / d48e84b dynamic_domains_mysql_redis_24 / mysql_redis / d48e84b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d48e84b dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d48e84b dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d48e84b ldap_mnesia_24 / ldap_mnesia / d48e84b ldap_mnesia_23 / ldap_mnesia / d48e84b internal_mnesia_24 / internal_mnesia / d48e84b elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d48e84b pgsql_mnesia_23 / pgsql_mnesia / d48e84b mysql_redis_24 / mysql_redis / d48e84b pgsql_mnesia_24 / pgsql_mnesia / d48e84b mssql_mnesia_24 / odbc_mssql_mnesia / d48e84b riak_mnesia_24 / riak_mnesia / d48e84b |
Muclight still takes lists as opts, so in the small tests there's a bit of duplication that will need to be removed when muclight is migrated, so that mam caches and muclight caches test similarly. Otherwise, this does the job.