Map options for mod_muc_light #3580
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
==========================================
+ Coverage 79.26% 80.84% +1.58%
==========================================
Files 424 424
Lines 32274 32265 -9
==========================================
+ Hits 25581 26085 +504
+ Misses 6693 6180 -513
Continue to review full report at Codecov.
|
chrzaszcz
force-pushed
the
mod_muc_light-map
branch
2 times, most recently
from
fe288ea to
9702d83
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
mod_muc_light-map
branch
from
30e851b to
b564b05
Compare
Motivation: - The new config with defaults would make deps without opts fail - These modules should not be started implicitly anyway. We should consider a new kind of dependency in the future, called 'required', that will require the user to configure the modules explicitly.
Also: - Make the schema error more user-friendly
chrzaszcz
force-pushed
the
mod_muc_light-map
branch
from
b564b05 to
c196d55
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
- Do not set the host when the default one is used - Save, ensure and restore modules in push_SUITE - Remove unused code
There is no reason for them to be different.
chrzaszcz
force-pushed
the
mod_muc_light-map
branch
from
c196d55 to
06a1100
Compare
|
small_tests_24 / small_tests / 06a1100 small_tests_23 / small_tests / 06a1100 dynamic_domains_mysql_redis_24 / mysql_redis / 06a1100 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 06a1100 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 06a1100 ldap_mnesia_24 / ldap_mnesia / 06a1100 sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_bounce{error,
{{assertion_failed,assert,is_chat_message,
[<<"msg-1">>],
{xmlel,<<"message">>,
[{<<"from">>,
<<"bOb_unacknowledged_message_hook_bounce_1395@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alicE_unacknowledged_message_hook_bounce_1398@localhost">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
{xmlel,<<"delay">>,
[{<<"xmlns">>,<<"urn:xmpp:delay">>},
{<<"stamp">>,<<"2022-03-09T11:09:51.705770Z">>},
{<<"from">>,<<"localhost">>}],
[{xmlcdata,<<"SM Storage">>}]}]},
"<message from='bOb_unacknowledged_message_hook_bounce_1395@localhost/escalus-default-resource' to='alicE_unacknowledged_message_hook_bounce_1398@localhost' xml:lang='en' type='chat'><body>msg-2</body><delay xmlns='urn:xmpp:delay' stamp='2022-03-09T11:09:51.705770Z' from='localhost'>SM Storage</delay></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,unacknowledged_message_hook_common,2,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,805}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"tes...dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 06a1100 ldap_mnesia_23 / ldap_mnesia / 06a1100 internal_mnesia_24 / internal_mnesia / 06a1100 pgsql_mnesia_24 / pgsql_mnesia / 06a1100 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 06a1100 pgsql_mnesia_23 / pgsql_mnesia / 06a1100 mysql_redis_24 / mysql_redis / 06a1100 mssql_mnesia_24 / odbc_mssql_mnesia / 06a1100 riak_mnesia_24 / riak_mnesia / 06a1100 ldap_mnesia_24 / ldap_mnesia / 06a1100 |
Put
mod_muc_lightopts in a map with defaults.Other changes:
mod_inbox- see the commit message for details.