-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global distribution opts in a map #3587
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3587 +/- ##
==========================================
+ Coverage 80.83% 80.84% +0.01%
==========================================
Files 425 425
Lines 32273 32194 -79
==========================================
- Hits 26087 26027 -60
+ Misses 6186 6167 -19
Continue to review full report at Codecov.
|
f311c58
to
b68ebb9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b68ebb9
to
b762480
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b762480
to
5ec9256
Compare
small_tests_24 / small_tests / 5ec9256 small_tests_23 / small_tests / 5ec9256 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 5ec9256 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 5ec9256 dynamic_domains_mysql_redis_24 / mysql_redis / 5ec9256 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 5ec9256 ldap_mnesia_24 / ldap_mnesia / 5ec9256 ldap_mnesia_23 / ldap_mnesia / 5ec9256 internal_mnesia_24 / internal_mnesia / 5ec9256 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 5ec9256 pgsql_mnesia_23 / pgsql_mnesia / 5ec9256 mysql_redis_24 / mysql_redis / 5ec9256 pgsql_mnesia_24 / pgsql_mnesia / 5ec9256 mssql_mnesia_24 / odbc_mssql_mnesia / 5ec9256 riak_mnesia_24 / riak_mnesia / 5ec9256 |
5ec9256
to
b78ffb3
Compare
small_tests_24 / small_tests / b78ffb3 small_tests_23 / small_tests / b78ffb3 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / b78ffb3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b78ffb3 dynamic_domains_mysql_redis_24 / mysql_redis / b78ffb3 ldap_mnesia_23 / ldap_mnesia / b78ffb3 jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,277}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}... dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / b78ffb3 ldap_mnesia_24 / ldap_mnesia / b78ffb3 internal_mnesia_24 / internal_mnesia / b78ffb3 pgsql_mnesia_23 / pgsql_mnesia / b78ffb3 mysql_redis_24 / mysql_redis / b78ffb3 jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,293}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}... pgsql_mnesia_24 / pgsql_mnesia / b78ffb3 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / b78ffb3 mssql_mnesia_24 / odbc_mssql_mnesia / b78ffb3 riak_mnesia_24 / riak_mnesia / b78ffb3 |
d275bb1
to
6db0471
Compare
small_tests_24 / small_tests / d5a19e6 small_tests_23 / small_tests / d5a19e6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d5a19e6 dynamic_domains_mysql_redis_24 / mysql_redis / d5a19e6 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d5a19e6 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d5a19e6 ldap_mnesia_23 / ldap_mnesia / d5a19e6 internal_mnesia_24 / internal_mnesia / d5a19e6 ldap_mnesia_24 / ldap_mnesia / d5a19e6 pgsql_mnesia_24 / pgsql_mnesia / d5a19e6 pgsql_mnesia_23 / pgsql_mnesia / d5a19e6 mysql_redis_24 / mysql_redis / d5a19e6 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d5a19e6 mssql_mnesia_24 / odbc_mssql_mnesia / d5a19e6 riak_mnesia_24 / riak_mnesia / d5a19e6 |
small_tests_24 / small_tests / 550851c small_tests_23 / small_tests / 550851c dynamic_domains_mysql_redis_24 / mysql_redis / 550851c dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 550851c dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 550851c ldap_mnesia_24 / ldap_mnesia / 550851c dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 550851c ldap_mnesia_23 / ldap_mnesia / 550851c internal_mnesia_24 / internal_mnesia / 550851c elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 550851c jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,293}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}... pgsql_mnesia_24 / pgsql_mnesia / 550851c pgsql_mnesia_23 / pgsql_mnesia / 550851c mysql_redis_24 / mysql_redis / 550851c mssql_mnesia_24 / odbc_mssql_mnesia / 550851c riak_mnesia_24 / riak_mnesia / 550851c offline_SUITE:mod_offline_tests:max_offline_messages_reached{error,{{timeout,100,[{times,50,98}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{offline_SUITE,'-max_offline_messages_reached/1-fun-1-',6,
[{file,"/home/circleci/project/big_tests/tests/offline_SUITE.erl"},
{line,252}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} |
small_tests_24 / small_tests / d275bb1 small_tests_23 / small_tests / d275bb1 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / d275bb1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d275bb1 dynamic_domains_mysql_redis_24 / mysql_redis / d275bb1 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / d275bb1 ldap_mnesia_23 / ldap_mnesia / d275bb1 ldap_mnesia_24 / ldap_mnesia / d275bb1 internal_mnesia_24 / internal_mnesia / d275bb1 pgsql_mnesia_23 / pgsql_mnesia / d275bb1 sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_bounce{error,
{{assertion_failed,assert,is_chat_message,
[<<"msg-1">>],
{xmlel,<<"message">>,
[{<<"from">>,
<<"bOb_unacknowledged_message_hook_bounce_2125@localhost/escalus-default-resource">>},
{<<"to">>,
<<"alicE_unacknowledged_message_hook_bounce_2128@localhost">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-2">>}]},
{xmlel,<<"delay">>,
[{<<"xmlns">>,<<"urn:xmpp:delay">>},
{<<"stamp">>,<<"2022-03-17T13:12:11.964965Z">>},
{<<"from">>,<<"localhost">>}],
[{xmlcdata,<<"SM Storage">>}]}]},
"<message from='bOb_unacknowledged_message_hook_bounce_2125@localhost/escalus-default-resource' to='alicE_unacknowledged_message_hook_bounce_2128@localhost' xml:lang='en' type='chat'><body>msg-2</body><delay xmlns='urn:xmpp:delay' stamp='2022-03-17T13:12:11.964965Z' from='localhost'>SM Storage</delay></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,unacknowledged_message_hook_common,2,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,805}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"tes... elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / d275bb1 mssql_mnesia_24 / odbc_mssql_mnesia / d275bb1 mysql_redis_24 / mysql_redis / d275bb1 pgsql_mnesia_24 / pgsql_mnesia / d275bb1 riak_mnesia_24 / riak_mnesia / d275bb1 |
small_tests_24 / small_tests / 6db0471 small_tests_23 / small_tests / 6db0471 dynamic_domains_mysql_redis_24 / mysql_redis / 6db0471 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6db0471 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 6db0471 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 6db0471 ldap_mnesia_24 / ldap_mnesia / 6db0471 ldap_mnesia_23 / ldap_mnesia / 6db0471 internal_mnesia_24 / internal_mnesia / 6db0471 pgsql_mnesia_23 / pgsql_mnesia / 6db0471 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 6db0471 mysql_redis_24 / mysql_redis / 6db0471 jingle_SUITE:init_per_suite{'EXIT',
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{nkpacket,
{bad_return,
{{nkpacket_app,start,[normal,[]]},
{'EXIT',
{{badmatch,{error,eafnosupport}},
[{nkpacket_stun,check_stun_server,5,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,277}]},
{nkpacket_stun,get_stun_servers,4,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,261}]},
{nkpacket_stun,get_stun_servers,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,97}]},
{nkpacket_stun,ext_ip,1,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_stun.erl"},
{line,75}]},
{nkpacket_app,get_auto_ips,0,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,113}]},
{nkpacket_app,start,2,
[{file,
"/home/circleci/project/_build/default/lib/nkpacket/src/nkpacket_app.erl"},
{line,58}]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},{line,293}]}]}}}}}}},
[{mod_jingle_sip,start_nksip_service_or_error,1,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"},
{line,62}]},
{mod_jingle_sip,start,2,
[{file,"/home/circleci/project/src/jingle_sip/mod_jingle_sip.erl"}... mam_SUITE:rdbms_simple_mam_all:mam04:simple_archive_request_for_the_receiver{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_simple_archive_request_for_the_receiver_998">>,
<<"localhost">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mam_SUITE:rdbms_simple_mam_all:mam04:save_unicode_messages{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_save_unicode_messages_1003">>,
<<"localhost">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mam_SUITE:rdbms_simple_mam_all:mam04:simple_text_search_request{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_simple_text_search_request_1004">>,
<<"localhost">>,<<"matygrysa">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mam_SUITE:rdbms_simple_mam_all:mam04:simple_archive_request{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_simple_archive_request_996">>,<<"localhost">>,
<<"makrolika">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mam_SUITE:rdbms_simple_mam_all:mam04:unicode_messages_can_be_extracted{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_unicode_messages_can_be_extracted_1000">>,
<<"localhost">>,<<"makrolika">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} mam_SUITE:rdbms_simple_mam_all:mam04:long_text_search_request{error,{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_long_text_search_request_1002">>,
<<"localhost">>,<<"makrolika">>],
3000,ejabberd],
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach,2,[{file,"lists.erl"},{line,1342}]},
{escalus_ejabberd,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{escalus_fresh,story,3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,27}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_24 / pgsql_mnesia / 6db0471 mssql_mnesia_24 / odbc_mssql_mnesia / 6db0471 riak_mnesia_24 / riak_mnesia / 6db0471 |
Other changes: - Defaults are moved from deps to the main config spec - All modules have the same opts for simplicity, because they are using each other's options anyway - there is no clear separation. - The utils module is now a separate dependency, which eliminates the need for custom callbacks for 'start', 'stop' and 'deps'. - There is no need for the sender dep as it has no start/stop logic.
- Instead of copying all options to ETS tables, store the global host type to enable querying the options without knowing the host type. Currently this host type is equivalent to global_host, but it can change in the future, when adding support for dynamic domains. - Make it a module because it has state - Use domain API for checking the global and local hosts. - Protect 'getaddrs' from returning duplicate addresses (happened on CI).
- Use opts from the provided map - Refactor hook handler registration - Eliminate the custom callbacks from the utils module
- Use opts from the provided map - Refactor hook handler registration - Eliminate the custom callbacks from the utils module
- Use opts from the provided map - Eliminate the custom callbacks from the utils module
- Use opts from the provided map - Eliminate the custom callbacks from the utils module - Put local_host in the state as it is used in every refresh operation, just like refresh_interval, which was already there
- Use opts from the provided map - Eliminate the custom callbacks from the utils module - Refactor hook handler registration
- Use TLS opts in a map - Eliminate the improper list from the API
- Use the new 'wrap' API - Read options from 'mod_global_distrib' as this is the module responsible for the 'maybe_reroute' handler
- Remove module callbacks as it is not a gen_mod anymore. - Read options from 'mod_global_distrib' as this is the module responsible for the 'maybe_reroute' handler
- Use opts in maps - Store connections_per_endpoint in the state like other options
- Start the modules regularly instead of being partially mocked
- Use maps with defaults - Test endpoint resolution
- Use options with defaults - Provide endpoints and resolved endpoints respectively - Restarting the receiver is not affecting the mapping options anymore (and it shouldn't do so), so the mapping endpoints are udpated explicitly - Disable test repeat
- Fix the wrong description of advertised endpoints - they neither were nor are resolved - Provide the correct default for TLS ciphers
It was: - not supported in the config spec, making it unusable - documented with the old Erlang configuration format (cfg) - untested - placed in the wrong section of the configuration file (top level)
6db0471
to
7286e37
Compare
small_tests_24 / small_tests / 7286e37 small_tests_23 / small_tests / 7286e37 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7286e37 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7286e37 dynamic_domains_mysql_redis_24 / mysql_redis / 7286e37 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7286e37 internal_mnesia_24 / internal_mnesia / 7286e37 ldap_mnesia_24 / ldap_mnesia / 7286e37 ldap_mnesia_23 / ldap_mnesia / 7286e37 pgsql_mnesia_24 / pgsql_mnesia / 7286e37 pgsql_mnesia_23 / pgsql_mnesia / 7286e37 mysql_redis_24 / mysql_redis / 7286e37 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7286e37 mssql_mnesia_24 / odbc_mssql_mnesia / 7286e37 riak_mnesia_24 / riak_mnesia / 7286e37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit the code is quite complicated so I don't understand everything and the relationships between global distrib modules. But the changes are really nice, and make the code much more readable and simple. Left some minor comments just to clarify if I understood the changes correctly.
cc3cccc
to
1b29057
Compare
small_tests_24 / small_tests / cc3cccc small_tests_23 / small_tests / cc3cccc dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / cc3cccc dynamic_domains_mysql_redis_24 / mysql_redis / cc3cccc muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4383}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4124}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4120}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / cc3cccc ldap_mnesia_24 / ldap_mnesia / cc3cccc ldap_mnesia_23 / ldap_mnesia / cc3cccc internal_mnesia_24 / internal_mnesia / cc3cccc pgsql_mnesia_23 / pgsql_mnesia / cc3cccc pgsql_mnesia_24 / pgsql_mnesia / cc3cccc elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / cc3cccc mysql_redis_24 / mysql_redis / cc3cccc mssql_mnesia_24 / odbc_mssql_mnesia / cc3cccc riak_mnesia_24 / riak_mnesia / cc3cccc |
small_tests_24 / small_tests / 1b29057 small_tests_23 / small_tests / 1b29057 dynamic_domains_mysql_redis_24 / mysql_redis / 1b29057 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1b29057 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 1b29057 ldap_mnesia_23 / ldap_mnesia / 1b29057 ldap_mnesia_24 / ldap_mnesia / 1b29057 internal_mnesia_24 / internal_mnesia / 1b29057 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 1b29057 mysql_redis_24 / mysql_redis / 1b29057 pgsql_mnesia_24 / pgsql_mnesia / 1b29057 pgsql_mnesia_23 / pgsql_mnesia / 1b29057 mssql_mnesia_24 / odbc_mssql_mnesia / 1b29057 riak_mnesia_24 / riak_mnesia / 1b29057 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 1b29057 inbox_extensions_SUITE:async_pools:one_to_one:archive_full_archive_can_be_fetched_queryid{error,
{{inbox_size,ok,
[{times,1,
{error,
{inbox_size,3,
[{times,1,
#{respond_iq =>
{xmlel,<<"iq">>,
[{<<"from">>,
<<"alicE_archive_full_archive_can_be_fetched_queryid_885@domain.example.com">>},
{<<"to">>,
<<"alicE_archive_full_archive_can_be_fetched_queryid_885@domain.example.com/res1">>},
{<<"id">>,<<"8408f5ca055200725e4b30b3490d058b">>},
{<<"type">>,<<"result">>}],
[{xmlel,<<"fin">>,
[{<<"xmlns">>,<<"erlang-solutions.com:xmpp:inbox:0">>}],
[{xmlel,<<"active-conversations">>,[],[{xmlcdata,<<"0">>}]},
{xmlel,<<"count">>,[],[{xmlcdata,<<"2">>}]},
{xmlel,<<"unread-messages">>,[],[{xmlcdata,<<"0">>}]}]}]},
respond_messages =>
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alicE_archive_full_archive_can_be_fetched_queryid_885@domain.example.com">>},
{<<"to">>,
<<"alicE_archive_full_archive_can_be_fetched_queryid_885@domain.example.com/res1">>},
{<<"id">>,<<"4d2d3fd4-65ea-4325-9c0a-161676599c2e">>}],
[{xmlel,<<"result">>,
[{<<"xmlns">>,<<"erlang-solutions.com:xmpp:inbox:0">>},
{<<"unread">>,<<"0">>},
{<<"queryid">>,<<"8408f5ca055200725e4b30b3490d058b">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"delay">>,
[{<<"xmlns">>,<<"urn:xmpp:delay">>},
{<<"stamp">>,<<"2022-03-17T17:19:05.345054Z">>}],
... dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 1b29057 |
Highlights:
All changes are described in details in the commit messages.