-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mam/report wrong stanza id more friendly #3591
Conversation
We can verify as well that the received IQ matches the one requested.
Codecov Report
@@ Coverage Diff @@
## master #3591 +/- ##
==========================================
- Coverage 80.92% 80.88% -0.05%
==========================================
Files 426 426
Lines 32351 32364 +13
==========================================
- Hits 26181 26178 -3
- Misses 6170 6186 +16
Continue to review full report at Codecov.
|
small_tests_24 / small_tests / 2f6b47e small_tests_23 / small_tests / 2f6b47e dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 2f6b47e dynamic_domains_mysql_redis_24 / mysql_redis / 2f6b47e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2f6b47e ldap_mnesia_23 / ldap_mnesia / 2f6b47e dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 2f6b47e ldap_mnesia_24 / ldap_mnesia / 2f6b47e internal_mnesia_24 / internal_mnesia / 2f6b47e elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2f6b47e pgsql_mnesia_24 / pgsql_mnesia / 2f6b47e pgsql_mnesia_23 / pgsql_mnesia / 2f6b47e mysql_redis_24 / mysql_redis / 2f6b47e mssql_mnesia_24 / odbc_mssql_mnesia / 2f6b47e riak_mnesia_24 / riak_mnesia / 2f6b47e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
If a client submits a stanza id that is not a valid one as generated by MIM's MAM, MAM is failing with a hard crash and returning the client a 500. This is not really friendly and doesn't help in debugging what went wrong.
In this PR I make it catch such an invalid id and return a more friendly 406-non_acceptable error, with a text description.