-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute setup workflow for tags as well #3676
Conversation
small_tests_24 / small_tests / 7677a16 small_tests_23 / small_tests / 7677a16 dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7677a16 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7677a16 dynamic_domains_mysql_redis_24 / mysql_redis / 7677a16 ldap_mnesia_23 / ldap_mnesia / 7677a16 ldap_mnesia_24 / ldap_mnesia / 7677a16 dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7677a16 internal_mnesia_24 / internal_mnesia / 7677a16 pgsql_mnesia_23 / pgsql_mnesia / 7677a16 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_1767@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_1767@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"uwbX9Db2+NYDFO1Zn+JdyA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1263}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1195}]}]}} mysql_redis_24 / mysql_redis / 7677a16 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7677a16 mssql_mnesia_24 / odbc_mssql_mnesia / 7677a16 riak_mnesia_24 / riak_mnesia / 7677a16 |
Codecov Report
@@ Coverage Diff @@
## master #3676 +/- ##
==========================================
- Coverage 81.14% 81.13% -0.02%
==========================================
Files 433 433
Lines 31909 31909
==========================================
- Hits 25893 25889 -4
- Misses 6016 6020 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good 👍
https://circleci.com/docs/2.0/configuration-reference/#tags
This was probably lost when we built the setup stage for CircleCI jobs. Gustaw and I had the same problem a long time ago, I think for 3.6 or so, that we realise that by default CircleCI does not run workflows for tags. I just guess this is the reason again, specially after seeing CircleCI says there's no workflow to run after a setup, without errors: