Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute setup workflow for tags as well #3676

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Jun 8, 2022

tags
CircleCI does not run workflows for tags unless you explicitly specify tag filters. Additionally, if a job requires any other jobs (directly or indirectly), you must specify tag filters for those jobs.

https://circleci.com/docs/2.0/configuration-reference/#tags

This was probably lost when we built the setup stage for CircleCI jobs. Gustaw and I had the same problem a long time ago, I think for 3.6 or so, that we realise that by default CircleCI does not run workflows for tags. I just guess this is the reason again, specially after seeing CircleCI says there's no workflow to run after a setup, without errors:
image

@NelsonVides NelsonVides marked this pull request as ready for review June 8, 2022 22:46
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 8, 2022

small_tests_24 / small_tests / 7677a16
Reports root / small


small_tests_23 / small_tests / 7677a16
Reports root / small


dynamic_domains_pgsql_mnesia_23 / pgsql_mnesia / 7677a16
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7677a16
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_24 / mysql_redis / 7677a16
Reports root/ big
OK: 2890 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


ldap_mnesia_23 / ldap_mnesia / 7677a16
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 7677a16
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_24 / odbc_mssql_mnesia / 7677a16
Reports root/ big
OK: 2907 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_24 / internal_mnesia / 7677a16
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


pgsql_mnesia_23 / pgsql_mnesia / 7677a16
Reports root/ big
OK: 3292 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_1767@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_1767@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"uwbX9Db2+NYDFO1Zn+JdyA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1754}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1263}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1195}]}]}}

Report log


mysql_redis_24 / mysql_redis / 7677a16
Reports root/ big
OK: 3276 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 7677a16
Reports root/ big
OK: 1900 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0


mssql_mnesia_24 / odbc_mssql_mnesia / 7677a16
Reports root/ big
OK: 3281 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 7677a16
Reports root/ big
OK: 1743 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3676 (7677a16) into master (9a83e02) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3676      +/-   ##
==========================================
- Coverage   81.14%   81.13%   -0.02%     
==========================================
  Files         433      433              
  Lines       31909    31909              
==========================================
- Hits        25893    25889       -4     
- Misses       6016     6020       +4     
Impacted Files Coverage Δ
...rc/smart_markers/mod_smart_markers_rdbms_async.erl 85.18% <0.00%> (-3.71%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 70.14% <0.00%> (-2.99%) ⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl 82.85% <0.00%> (-2.86%) ⬇️
src/pubsub/node_pep.erl 79.62% <0.00%> (-1.86%) ⬇️
src/domain/mongoose_domain_loader.erl 89.28% <0.00%> (-0.90%) ⬇️
src/ejabberd_c2s.erl 88.94% <0.00%> (-0.23%) ⬇️
src/pubsub/mod_pubsub.erl 73.42% <0.00%> (-0.07%) ⬇️
src/mod_muc_log.erl 63.11% <0.00%> (ø)
src/mod_muc_room.erl 76.70% <0.00%> (+0.11%) ⬆️
...c/global_distrib/mod_global_distrib_server_mgr.erl 77.71% <0.00%> (+0.57%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a83e02...7677a16. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 👍

@chrzaszcz chrzaszcz merged commit 8f5b21a into master Jun 9, 2022
@chrzaszcz chrzaszcz deleted the circlec_ci_tags_setup branch June 9, 2022 05:41
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants