Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different issue for collecting error comments #3686

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

arcusfelis
Copy link
Contributor

This PR addresses "No more space for comments, reached 2500".

Proposed changes include:

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 14, 2022

small_tests_24 / small_tests / 1fface6
Reports root / small


small_tests_25 / small_tests / 1fface6
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 1fface6
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / 1fface6
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 1fface6
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 1fface6
Reports root/ big
OK: 2808 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 1fface6
Reports root/ big
OK: 1508 / Failed: 0 / User-skipped: 401 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 1fface6
Reports root/ big
OK: 2825 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 1fface6
Reports root/ big
OK: 1593 / Failed: 0 / User-skipped: 316 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 1fface6
Reports root/ big
OK: 1876 / Failed: 0 / User-skipped: 324 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 1fface6
Reports root/ big
OK: 3194 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 1fface6
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 1fface6
Reports root/ big
OK: 1731 / Failed: 0 / User-skipped: 323 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 1fface6
Reports root/ big
OK: 3199 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #3686 (1fface6) into master (96839a5) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3686      +/-   ##
==========================================
- Coverage   81.19%   81.13%   -0.07%     
==========================================
  Files         434      434              
  Lines       31884    31884              
==========================================
- Hits        25889    25868      -21     
- Misses       5995     6016      +21     
Impacted Files Coverage Δ
src/mongoose_tcp_listener.erl 78.04% <0.00%> (-4.88%) ⬇️
src/inbox/mod_inbox_rdbms_async.erl 70.14% <0.00%> (-2.99%) ⬇️
...bal_distrib/mod_global_distrib_hosts_refresher.erl 66.66% <0.00%> (-2.23%) ⬇️
src/ejabberd_s2s_out.erl 60.54% <0.00%> (-1.99%) ⬇️
src/pubsub/node_pep.erl 77.77% <0.00%> (-1.86%) ⬇️
src/domain/mongoose_domain_loader.erl 89.28% <0.00%> (-0.90%) ⬇️
src/ejabberd_c2s.erl 89.23% <0.00%> (-0.38%) ⬇️
src/mod_muc_room.erl 76.68% <0.00%> (-0.18%) ⬇️
src/pubsub/mod_pubsub.erl 73.42% <0.00%> (-0.07%) ⬇️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96839a5...1fface6. Read the comment docs.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chrzaszcz chrzaszcz merged commit cbd9928 into master Jun 15, 2022
@chrzaszcz chrzaszcz deleted the mu-ci-new-issue-for-comments branch June 15, 2022 07:47
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants