Fix the format of JWT secret #3716
Conversation
It was parsed as a string, but should be a binary instead. Also: add file check
chrzaszcz
force-pushed
the
fix-auth-jwt-secret
branch
from
05d916c to
7de6597
Compare
|
small_tests_24 / small_tests / 7de6597 small_tests_25 / small_tests / 7de6597 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 7de6597 ldap_mnesia_24 / ldap_mnesia / 7de6597 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 7de6597 dynamic_domains_mysql_redis_25 / mysql_redis / 7de6597 ldap_mnesia_25 / ldap_mnesia / 7de6597 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7de6597 sm_SUITE:parallel_unacknowledged_message_hook:unacknowledged_message_hook_bounce{error,
{{assertion_failed,assert,is_chat_message,
[<<"msg-1">>],
{xmlel,<<"message">>,
[{<<"from">>,
<<"bob_unacknowledged_message_hook_bounce_2403@domain.example.com/escalus-default-resource">>},
{<<"to">>,
<<"alice_unacknowledged_message_hook_bounce_2409@domain.example.com">>},
{<<"xml:lang">>,<<"en">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"msg-3">>}]},
{xmlel,<<"delay">>,
[{<<"xmlns">>,<<"urn:xmpp:delay">>},
{<<"stamp">>,<<"2022-07-26T08:42:52.564438Z">>},
{<<"from">>,<<"domain.example.com">>}],
[{xmlcdata,<<"SM Storage">>}]}]},
"<message from='bob_unacknowledged_message_hook_bounce_2403@domain.example.com/escalus-default-resource' to='alice_unacknowledged_message_hook_bounce_2409@domain.example.com' xml:lang='en' type='chat'><body>msg-3</body><delay xmlns='urn:xmpp:delay' stamp='2022-07-26T08:42:52.564438Z' from='domain.example.com'>SM Storage</delay></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{sm_SUITE,unacknowledged_message_hook_common,2,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,857}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
...pgsql_mnesia_24 / pgsql_mnesia / 7de6597 internal_mnesia_25 / internal_mnesia / 7de6597 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 7de6597 mysql_redis_25 / mysql_redis / 7de6597 pgsql_mnesia_25 / pgsql_mnesia / 7de6597 mssql_mnesia_25 / odbc_mssql_mnesia / 7de6597 muc_SUITE:register:user_submits_registration_form{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"9649174e3a501cc69522dba6aff88c27">>},
{<<"to">>,<<"muc.localhost">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitchroom-de278a24aa">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"muc.localhost">>},
{<<"to">>,
<<"alice_user_submits_registration_form_2189@localhost/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>},
{<<"id">>,<<"9649174e3a501cc69522dba6aff88c27">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
...pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,{{assertion_failed,assert_many,false,[is_presence],[],[]},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_story,'-make_all_clients_friends/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,109}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{escalus_utils,'-each_with_index/3-fun-0-',3,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,87}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{escalus_utils,distinct_pairs,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_utils.erl"},
{line,60}]},
{escalus_story,make_all_clients_friends,1,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,106}]}]}}riak_mnesia_24 / riak_mnesia / 7de6597 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7de6597 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / 7de6597 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 7de6597 |
Codecov Report
@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
+ Coverage 80.69% 82.21% +1.52%
==========================================
Files 523 523
Lines 33801 33801
==========================================
+ Hits 27275 27789 +514
+ Misses 6526 6012 -514
Continue to review full report at Codecov.
|
This PR addresses #3690
The secret was parsed as a string, but should be a binary instead.
Also: add file check