Domain admin tests in roster suite #3736
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 82.70% 82.69% -0.01%
==========================================
Files 529 529
Lines 33947 33947
==========================================
- Hits 28075 28073 -2
- Misses 5872 5874 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
| domain_admin_set_mutual_subscription_try_connect_users_no_permission(Config) -> | ||
| escalus:fresh_story_with_config(Config, [{alice_bis, 1}, {bob, 1}], | ||
| fun domain_admin_set_mutual_subscription_try_connect_users_no_permission_story/3). |
There was a problem hiding this comment.
Please try to stick to the 100 characters per line limit.
There was a problem hiding this comment.
Overall looks good, however, I think that copying all tests for domain_admin tests is unnecessary. A sufficient amount would be to test each graphql function two times for domain admin(one when it passes and one when an authentication error occurs). More details I will give later during the call.
jacekwegr
force-pushed
the
domain-admin-roster-tests
branch
from
721e9f8 to
4367b5f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
domain-admin-roster-tests
branch
from
4367b5f to
c368c51
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
domain-admin-roster-tests
branch
from
c368c51 to
b10550e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jacekwegr
force-pushed
the
domain-admin-roster-tests
branch
from
44684ac to
6aca4dd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
| Res = admin_subscribe_to_all(Alice, [Bob, Kate], Config), | ||
| check_if_created_succ(?SUBSCRIBE_TO_ALL_PATH, Res, [true, false]), | ||
| ?assertNotEqual(nomatch, binary:match(get_err_msg(Res), <<"does not exist">>)), | ||
|
|
There was a problem hiding this comment.
I would remove this empty line
Added tests for domain admin in graphql_roster_SUITE. The tests are similar to those for a global admin, but they also check for permissions.
jacekwegr
force-pushed
the
domain-admin-roster-tests
branch
from
6aca4dd to
ecd2cf3
Compare
|
small_tests_24 / small_tests / ecd2cf3 small_tests_25 / small_tests / ecd2cf3 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ecd2cf3 ldap_mnesia_24 / ldap_mnesia / ecd2cf3 dynamic_domains_mysql_redis_25 / mysql_redis / ecd2cf3 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ecd2cf3 ldap_mnesia_25 / ldap_mnesia / ecd2cf3 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ecd2cf3 pgsql_mnesia_24 / pgsql_mnesia / ecd2cf3 internal_mnesia_25 / internal_mnesia / ecd2cf3 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ecd2cf3 pgsql_mnesia_25 / pgsql_mnesia / ecd2cf3 mysql_redis_25 / mysql_redis / ecd2cf3 mssql_mnesia_25 / odbc_mssql_mnesia / ecd2cf3 push_integration_SUITE:pubsub_ful:pm_notifications_with_inbox:inbox_msg_reset_unread_count_fcm{error,
{{assertMatch,
[{module,push_integration_SUITE},
{line,662},
{expression,"Data"},
{pattern,"# { << \"message-count\" >> := ExpectedCount }"},
{value,
#{<<"last-message-body">> => <<"SECOND MESSAGE">>,
<<"last-message-sender">> =>
<<"alice_inbox_msg_reset_unread_count_fcm_2611@localhost">>,
<<"message-count">> => 1}}]},
[{push_integration_SUITE,check_notification,2,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,662}]},
{push_integration_SUITE,'-inbox_msg_reset_unread_count/3-fun-0-',5,
[{file,
"/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
{line,598}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / ecd2cf3 mssql_mnesia_25 / odbc_mssql_mnesia / ecd2cf3 |
Added tests for domain admin in graphql_roster_SUITE. The tests are similar to those for a global admin, but they also check for permissions.