-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable code for domain admin tests #3740
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #3740 +/- ##
==========================================
- Coverage 82.67% 82.64% -0.04%
==========================================
Files 529 529
Lines 33947 33947
==========================================
- Hits 28067 28055 -12
- Misses 5880 5892 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged the execute_auth and execute_domain_admin functions so both types of admins can use execute_command
6efe220
to
6944340
Compare
small_tests_24 / small_tests / 6944340 small_tests_25 / small_tests / 6944340 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6944340 ldap_mnesia_24 / ldap_mnesia / 6944340 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6944340 ldap_mnesia_25 / ldap_mnesia / 6944340 dynamic_domains_mysql_redis_25 / mysql_redis / 6944340 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6944340 internal_mnesia_25 / internal_mnesia / 6944340 pgsql_mnesia_24 / pgsql_mnesia / 6944340 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6944340 pgsql_mnesia_25 / pgsql_mnesia / 6944340 mssql_mnesia_25 / odbc_mssql_mnesia / 6944340 mysql_redis_25 / mysql_redis / 6944340 riak_mnesia_24 / riak_mnesia / 6944340 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Merged execute_auth and execute_domain_admin functions so both types of admins can use execute_command