C2s/privacy #3747
Merged
C2s/privacy #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/presences
branch
2 times, most recently
from
a703a6c
to
bdc1f33
Compare
NelsonVides
force-pushed
the
c2s/privacy
branch
2 times, most recently
from
6c22e28
to
a18c463
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 62.69% // Head: 64.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3747 +/- ##
========================================================
+ Coverage 62.69% 64.13% +1.43%
========================================================
Files 536 536
Lines 34853 34990 +137
========================================================
+ Hits 21852 22441 +589
+ Misses 13001 12549 -452
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NelsonVides
force-pushed
the
c2s/presences
branch
from
bdc1f33
to
7b68709
Compare
NelsonVides
force-pushed
the
c2s/privacy
branch
from
a18c463
to
2870c7d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/presences
branch
from
7b68709
to
2a5694a
Compare
NelsonVides
force-pushed
the
c2s/privacy
branch
from
2870c7d
to
cf3284c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/presences
branch
3 times, most recently
from
c6105e8
to
7b8e99c
Compare
NelsonVides
force-pushed
the
c2s/presences
branch
4 times, most recently
from
1edaa0f
to
4152aa9
Compare
NelsonVides
force-pushed
the
c2s/privacy
branch
from
cf3284c
to
b773701
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/privacy
branch
from
b773701
to
559015e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/privacy
branch
2 times, most recently
from
5e00370
to
a959bce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
NelsonVides
force-pushed
the
c2s/privacy
branch
from
a959bce
to
e591151
Compare
This comment was marked as outdated.
This comment was marked as outdated.
An important note is that privacy checks were most often returning
tuples of {mongoose_acc, decision}, where the decision is actually the
tag of the tuple, so the order was inverted for better pattern-matching.
NelsonVides
force-pushed
the
c2s/privacy
branch
from
e591151
to
fadd027
Compare
|
ldap_mnesia_24 / ldap_mnesia / fadd027 small_tests_24 / small_tests / fadd027 ldap_mnesia_25 / ldap_mnesia / fadd027 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fadd027 small_tests_25 / small_tests / fadd027 internal_mnesia_25 / internal_mnesia / fadd027 pgsql_mnesia_24 / pgsql_mnesia / fadd027 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fadd027 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fadd027 dynamic_domains_mysql_redis_25 / mysql_redis / fadd027 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fadd027 mysql_redis_25 / mysql_redis / fadd027 metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}pgsql_mnesia_25 / pgsql_mnesia / fadd027 mssql_mnesia_25 / odbc_mssql_mnesia / fadd027 service_domain_db_SUITE:db:db_could_sync_between_nodes{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,db_could_sync_between_nodes,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,568}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}service_domain_db_SUITE:db:db_deleted_from_one_node_while_service_disabled_on_another{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,
db_deleted_from_one_node_while_service_disabled_on_another,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,579}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}service_domain_db_SUITE:db:db_reinserted_from_one_node_while_service_disabled_on_another{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,
db_reinserted_from_one_node_while_service_disabled_on_another,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,616}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}riak_mnesia_24 / riak_mnesia / fadd027 mysql_redis_25 / mysql_redis / fadd027 metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / fadd027 mysql_redis_25 / mysql_redis / fadd027 inbox_SUITE:async_pools:one_to_one:msg_sent_to_offline_user{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_msg_sent_to_offline_user_684@localhost/res1">>},
{<<"to">>,<<"bob_msg_sent_to_offline_user_684@localhost/res1">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"test">>}]},
{xmlel,<<"stanza-id">>,
[{<<"by">>,<<"bob_msg_sent_to_offline_user_684@localhost">>},
{<<"id">>,<<"BQDQ95EVBK81">>},
{<<"xmlns">>,<<"urn:xmpp:sid:0">>}],
[]}]},
"<message from='alice_msg_sent_to_offline_user_684@localhost/res1' to='bob_msg_sent_to_offline_user_684@localhost/res1' type='chat'><body>test</body><stanza-id by='bob_msg_sent_to_offline_user_684@localhost' id='BQDQ95EVBK81' xmlns='urn:xmpp:sid:0'/></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_session,session,1,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,131}]},
{escalus_session,session,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,273}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,fo...metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements privacy and blocking. They require presences.