-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C2s/ping #3748
C2s/ping #3748
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
21f1c60
to
e80ecce
Compare
48cf8eb
to
ddfcc46
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ddfcc46
to
b0e3f1d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a21bb34
to
225849a
Compare
b0e3f1d
to
a729fc4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 64.42% // Head: 64.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3748 +/- ##
========================================================
+ Coverage 64.42% 64.71% +0.28%
========================================================
Files 536 536
Lines 35002 34997 -5
========================================================
+ Hits 22551 22649 +98
+ Misses 12451 12348 -103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
a729fc4
to
c526baf
Compare
ldap_mnesia_24 / ldap_mnesia / c526baf small_tests_24 / small_tests / c526baf ldap_mnesia_25 / ldap_mnesia / c526baf small_tests_25 / small_tests / c526baf dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c526baf internal_mnesia_25 / internal_mnesia / c526baf pgsql_mnesia_24 / pgsql_mnesia / c526baf dynamic_domains_mysql_redis_25 / mysql_redis / c526baf dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c526baf elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c526baf riak_mnesia_24 / riak_mnesia / c526baf pgsql_mnesia_25 / pgsql_mnesia / c526baf dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c526baf last_SUITE:valid_queries:last_offline_user{error,
{{assertion_failed,assert,is_last_result,
{xmlel,<<"presence">>,
[{<<"from">>,<<"alice_unnamed_813@domain.example.com/res1">>},
{<<"to">>,<<"alice_unnamed_813@domain.example.com/res1">>},
{<<"type">>,<<"unavailable">>}],
[{xmlel,<<"status">>,[],[{xmlcdata,<<"Unknown condition">>}]}]},
"<presence from='alice_unnamed_813@domain.example.com/res1' to='alice_unnamed_813@domain.example.com/res1' type='unavailable'><status>Unknown condition</status></presence>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{last_SUITE,'-last_offline_user/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/last_SUITE.erl"},
{line,133}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mysql_redis_25 / mysql_redis / c526baf metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / c526baf |
small_tests_24 / small_tests / 002eb93 ldap_mnesia_24 / ldap_mnesia / 002eb93 small_tests_25 / small_tests / 002eb93 ldap_mnesia_25 / ldap_mnesia / 002eb93 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 002eb93 pgsql_mnesia_24 / pgsql_mnesia / 002eb93 internal_mnesia_25 / internal_mnesia / 002eb93 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 002eb93 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 002eb93 dynamic_domains_mysql_redis_25 / mysql_redis / 002eb93 mysql_redis_25 / mysql_redis / 002eb93 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 002eb93 pgsql_mnesia_25 / pgsql_mnesia / 002eb93 riak_mnesia_24 / riak_mnesia / 002eb93 mssql_mnesia_25 / odbc_mssql_mnesia / 002eb93 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I just have one small comment.
src/mod_ping.erl
Outdated
_ -> | ||
{ok, Acc} | ||
end; | ||
{_, {error, not_found}} -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clause is redundant as a next one returns the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed 👌🏽
small_tests_24 / small_tests / a73bc33 ldap_mnesia_25 / ldap_mnesia / a73bc33 small_tests_25 / small_tests / a73bc33 ldap_mnesia_24 / ldap_mnesia / a73bc33 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a73bc33 pgsql_mnesia_24 / pgsql_mnesia / a73bc33 inbox_SUITE:regular:one_to_one:msg_sent_to_offline_user{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_msg_sent_to_offline_user_982@localhost/res1">>},
{<<"to">>,<<"bob_msg_sent_to_offline_user_982@localhost/res1">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"test">>}]},
{xmlel,<<"stanza-id">>,
[{<<"by">>,<<"bob_msg_sent_to_offline_user_982@localhost">>},
{<<"id">>,<<"BQHJJK5AFJO1">>},
{<<"xmlns">>,<<"urn:xmpp:sid:0">>}],
[]}]},
"<message from='alice_msg_sent_to_offline_user_982@localhost/res1' to='bob_msg_sent_to_offline_user_982@localhost/res1' type='chat'><body>test</body><stanza-id by='bob_msg_sent_to_offline_user_982@localhost' id='BQHJJK5AFJO1' xmlns='urn:xmpp:sid:0'/></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_session,session,1,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,131}]},
{escalus_session,session,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,273}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,fo... internal_mnesia_25 / internal_mnesia / a73bc33 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a73bc33 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a73bc33 dynamic_domains_mysql_redis_25 / mysql_redis / a73bc33 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a73bc33 pgsql_mnesia_25 / pgsql_mnesia / a73bc33 mysql_redis_25 / mysql_redis / a73bc33 mssql_mnesia_25 / odbc_mssql_mnesia / a73bc33 riak_mnesia_24 / riak_mnesia / a73bc33 pgsql_mnesia_24 / pgsql_mnesia / a73bc33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 👍
No description provided.