-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix types in subscribeAllToAll roster GraphQL API #3756
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 82.66% // Head: 82.71% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3756 +/- ##
==========================================
+ Coverage 82.66% 82.71% +0.05%
==========================================
Files 529 529
Lines 33957 33958 +1
==========================================
+ Hits 28069 28089 +20
+ Misses 5888 5869 -19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
996efa5
to
0da283d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0da283d
to
28161cc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
28161cc
to
2e58f7c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
2e58f7c
to
a08a82e
Compare
small_tests_24 / small_tests / a08a82e small_tests_25 / small_tests / a08a82e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a08a82e ldap_mnesia_24 / ldap_mnesia / a08a82e dynamic_domains_mysql_redis_25 / mysql_redis / a08a82e dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a08a82e ldap_mnesia_25 / ldap_mnesia / a08a82e dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a08a82e pgsql_mnesia_24 / pgsql_mnesia / a08a82e internal_mnesia_25 / internal_mnesia / a08a82e elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a08a82e pgsql_mnesia_25 / pgsql_mnesia / a08a82e mysql_redis_25 / mysql_redis / a08a82e pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2237@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2237@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"5wmMU1MieggTZpSdS1AL1Q==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} riak_mnesia_24 / riak_mnesia / a08a82e mssql_mnesia_25 / odbc_mssql_mnesia / a08a82e |
This PR fixes types in subscribeAllToAll roster GraphQL API and adds tests for them