Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in subscribeAllToAll roster GraphQL API #3756

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

jacekwegr
Copy link
Contributor

This PR fixes types in subscribeAllToAll roster GraphQL API and adds tests for them

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 82.66% // Head: 82.71% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (a08a82e) compared to base (77951fc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3756      +/-   ##
==========================================
+ Coverage   82.66%   82.71%   +0.05%     
==========================================
  Files         529      529              
  Lines       33957    33958       +1     
==========================================
+ Hits        28069    28089      +20     
+ Misses       5888     5869      -19     
Impacted Files Coverage Δ
...l/admin/mongoose_graphql_roster_admin_mutation.erl 100.00% <100.00%> (ø)
src/mod_muc_room.erl 78.39% <0.00%> (-0.12%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/ejabberd_ctl.erl 54.14% <0.00%> (+0.29%) ⬆️
src/ejabberd_c2s.erl 89.23% <0.00%> (+0.29%) ⬆️
src/mod_roster.erl 79.42% <0.00%> (+0.71%) ⬆️
src/rdbms/mongoose_rdbms.erl 66.31% <0.00%> (+1.05%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 73.52% <0.00%> (+1.47%) ⬆️
src/mod_roster_riak.erl 98.46% <0.00%> (+1.53%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the fix-types-in-subscribe-all-to-all-api branch from 0da283d to 28161cc Compare September 12, 2022 13:27
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the fix-types-in-subscribe-all-to-all-api branch from 28161cc to 2e58f7c Compare September 12, 2022 14:42
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review September 13, 2022 07:51
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

big_tests/tests/graphql_roster_SUITE.erl Outdated Show resolved Hide resolved
@jacekwegr jacekwegr force-pushed the fix-types-in-subscribe-all-to-all-api branch from 2e58f7c to a08a82e Compare September 14, 2022 09:40
@mongoose-im
Copy link
Collaborator

mongoose-im commented Sep 14, 2022

small_tests_24 / small_tests / a08a82e
Reports root / small


small_tests_25 / small_tests / a08a82e
Reports root / small


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a08a82e
Reports root/ big
OK: 3595 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_24 / ldap_mnesia / a08a82e
Reports root/ big
OK: 1956 / Failed: 0 / User-skipped: 555 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / a08a82e
Reports root/ big
OK: 3578 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a08a82e
Reports root/ big
OK: 3595 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / a08a82e
Reports root/ big
OK: 1956 / Failed: 0 / User-skipped: 555 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a08a82e
Reports root/ big
OK: 3595 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / a08a82e
Reports root/ big
OK: 3969 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / a08a82e
Reports root/ big
OK: 2077 / Failed: 0 / User-skipped: 434 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a08a82e
Reports root/ big
OK: 2417 / Failed: 0 / User-skipped: 429 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / a08a82e
Reports root/ big
OK: 3969 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / a08a82e
Reports root/ big
OK: 3975 / Failed: 1 / User-skipped: 102 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2237@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2237@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"5wmMU1MieggTZpSdS1AL1Q==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log


riak_mnesia_24 / riak_mnesia / a08a82e
Reports root/ big
OK: 2256 / Failed: 0 / User-skipped: 422 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / a08a82e
Reports root/ big
OK: 3969 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@chrzaszcz chrzaszcz merged commit ebb3411 into master Sep 14, 2022
@chrzaszcz chrzaszcz deleted the fix-types-in-subscribe-all-to-all-api branch September 14, 2022 11:40
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants