Get rid of mongoose_commands #3759

chrzaszcz · 2022-09-14T13:57:11Z

The new mongoose_admin_api module covers the functionality that mongoose_api_admin, mongoose_commands, mod_commands, mod_muc_commands and mod_muc_light_commands used to provide. This means that all the unused code can be now removed, resulting in a significant code reduction.

Also: log level for HTTP errors for the Admin REST API was reduced. Now it is:

error for internal server errors.
warning for other errors.

TO DO after this PR:

Rework mongoose_api and mongoose_domain_handler to use mongoose_admin_api.
Document the new REST API.
Update migration guide.

mongoose-im · 2022-09-14T14:05:41Z

small_tests_24 / small_tests / dbd74b5
Reports root / small

small_tests_25 / small_tests / dbd74b5
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / dbd74b5
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / dbd74b5
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / dbd74b5
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / dbd74b5
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / dbd74b5
Reports root/ big
OK: 2078 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / dbd74b5
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / dbd74b5
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / dbd74b5
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / dbd74b5
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / dbd74b5
Reports root/ big
OK: 3942 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / dbd74b5
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / dbd74b5
Reports root/ big
OK: 3957 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

muc_http_api_SUITE:negative:kick_user_errors

{error,{{timeout,ok,[{times,50,not_yet}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {muc_http_api_SUITE,kick_user_errors,1,
               [{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
                {line,325}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2346@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2346@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"xqtZrDaYgZVDJgamXC9PyQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

codecov · 2022-09-14T14:08:05Z

Codecov Report

Base: 80.93% // Head: 82.69% // Increases project coverage by +1.75% 🎉

Coverage data is based on head (27e0486) compared to base (0c74a8f).
Patch coverage: 80.76% of modified lines in pull request are covered.

Additional details and impacted files

@@                     Coverage Diff                      @@
##           feature/unified-rest-api    #3759      +/-   ##
============================================================
+ Coverage                     80.93%   82.69%   +1.75%     
============================================================
  Files                           537      531       -6     
  Lines                         34342    33769     -573     
============================================================
+ Hits                          27796    27925     +129     
+ Misses                         6546     5844     -702

Impacted Files	Coverage Δ
src/ejabberd_app.erl	`94.52% <ø> (-0.08%)`	⬇️
src/ejabberd_cowboy.erl	`75.80% <ø> (ø)`
src/mongoose_api_common.erl	`75.00% <ø> (+2.73%)`	⬆️
src/mongoose_hooks.erl	`95.40% <ø> (-0.05%)`	⬇️
src/mongoose_http_handler.erl	`100.00% <ø> (ø)`
src/mongoose_lib.erl	`87.32% <ø> (-0.18%)`	⬇️
src/mongoose_stanza_helper.erl	`92.85% <ø> (+27.85%)`	⬆️
src/mongoose_admin_api/mongoose_admin_api.erl	`90.90% <79.16%> (-6.24%)`	⬇️
src/inbox/mod_inbox.erl	`86.73% <100.00%> (ø)`
...stem_metrics/mongoose_system_metrics_collector.erl	`94.62% <100.00%> (ø)`
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mongoose-im · 2022-09-14T14:31:42Z

small_tests_24 / small_tests / c8c8355
Reports root / small

small_tests_25 / small_tests / c8c8355
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c8c8355
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / c8c8355
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c8c8355
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c8c8355
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c8c8355
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c8c8355
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c8c8355
Reports root/ big
OK: 2078 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c8c8355
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c8c8355
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c8c8355
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c8c8355
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / c8c8355
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c8c8355
Reports root/ big
OK: 3942 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mongoose-im · 2022-09-15T07:10:09Z

small_tests_24 / small_tests / 038fd1f
Reports root / small

small_tests_25 / small_tests / 038fd1f
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 038fd1f
Reports root/ big
OK: 3570 / Failed: 3 / User-skipped: 88 / Auto-skipped: 0

service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join

{error,{test_case_failed,{[<<"example1.com">>],
              [<<"example1.com">>,<<"example2.com">>]}}}

Report log

service_domain_db_SUITE:db:rest_with_auth:rest_delete_domain_cleans_data_from_mam

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_2427@example.org/res1">>,
          escalus_tcp,<0.17074.2>,
          [{event_manager,<0.17068.2>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2427">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17068.2>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_2427">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2427">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2427">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"ea96b6ad9ff6534a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5,
       [{file,
    ...

Report log

service_domain_db_SUITE:db:rest_without_auth:rest_delete_domain_cleans_data_from_mam

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"bob_rest_delete_domain_cleans_data_from_mam_2428@example.org/res1">>,
          escalus_tcp,<0.17673.2>,
          [{event_manager,<0.17667.2>},
           {server,<<"example.org">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2428">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.17667.2>},
            {server,<<"example.org">>},
            {username,
              <<"bob_rest_delete_domain_cleans_data_from_mam_2428">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2428">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {port,5232},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"bob_rest_delete_domain_cleans_data_from_mam_2428">>},
           {server,<<"example.org">>},
           {host,<<"localhost">>},
           {password,<<"makota3">>},
           {port,5232},
           {stream_id,<<"813dd09187d9b95e">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {service_domain_db_SUITE,
       '-rest_delete_domain_cleans_data_from_mam/1-fun-0-',5,
       [{file,
    ...

Report log

ldap_mnesia_24 / ldap_mnesia / 038fd1f
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 038fd1f
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

mam_SUITE:rdbms_async_cache_chat_markers:end_per_group

{error,
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,'pm_mam_async_pool_test type',
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_test type-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_test type-2',
        {already_started,<9143.9222.1>}}}}}}},
    {child,undefined,'pm_mam_sup_async_pool_test type',
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => 'pm_mam_sup_async_pool_test type',restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"test type">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
    type =>...

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 038fd1f
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 038fd1f
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 038fd1f
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 038fd1f
Reports root/ big
OK: 2078 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 038fd1f
Reports root/ big
OK: 3958 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2348@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2348@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"Aa/RvjHWtdE8BHfyZfwdxg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 038fd1f
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 038fd1f
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 038fd1f
Reports root/ big
OK: 3942 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 038fd1f
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 038fd1f
Reports root/ big
OK: 3946 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mongoose-im · 2022-09-15T07:42:12Z

small_tests_24 / small_tests / fff1672
Reports root / small

small_tests_25 / small_tests / fff1672
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fff1672
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / fff1672
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / fff1672
Reports root/ big
OK: 3556 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fff1672
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / fff1672
Reports root/ big
OK: 1957 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / fff1672
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fff1672
Reports root/ big
OK: 3573 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / fff1672
Reports root/ big
OK: 2078 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fff1672
Reports root/ big
OK: 2418 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / fff1672
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / fff1672
Reports root/ big
OK: 3942 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / fff1672
Reports root/ big
OK: 3947 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / fff1672
Reports root/ big
OK: 2258 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

mongoose-im · 2022-09-15T08:28:00Z

small_tests_24 / small_tests / 999cb68
Reports root / small

small_tests_25 / small_tests / 999cb68
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 999cb68
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 999cb68
Reports root/ big
OK: 1958 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 999cb68
Reports root/ big
OK: 1958 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 999cb68
Reports root/ big
OK: 3557 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 999cb68
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 999cb68
Reports root/ big
OK: 3573 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 999cb68
Reports root/ big
OK: 2079 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 999cb68
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 999cb68
Reports root/ big
OK: 2419 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 999cb68
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 999cb68
Reports root/ big
OK: 3943 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 999cb68
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 999cb68
Reports root/ big
OK: 2259 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 999cb68
Reports root/ big
OK: 3573 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted

{error,
  {{assert,
     [{module,inbox_extensions_SUITE},
      {line,798},
      {expression,"escalus_pred : is_message ( Message )"},
      {expected,true},
      {value,false}]},
   [{inbox_extensions_SUITE,check_message_with_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,798}]},
    {inbox_extensions_SUITE,set_inbox_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,792}]},
    {inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,568}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 999cb68
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

Also: remove mod_*commands from small tests, because this functionality is being removed.

This functionality is being removed.

This functionality is now provided by mongoose_admin_api

- Remove unused helpers from mongoose_api_common - Move error handling to mongoose_admin_api, which is specific to the Admin API. - Rework error loggiong, the log level is quite verbose (warning/error), but still lower than before (always error). Anyway, it applies only to the Admin API.

'reload_dispatch' is kept as a shell utility

mongoose-im · 2022-09-15T12:48:56Z

small_tests_24 / small_tests / 27e0486
Reports root / small

small_tests_25 / small_tests / 27e0486
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 27e0486
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 27e0486
Reports root/ big
OK: 1958 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 27e0486
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 27e0486
Reports root/ big
OK: 3557 / Failed: 0 / User-skipped: 105 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 27e0486
Reports root/ big
OK: 1958 / Failed: 0 / User-skipped: 530 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 27e0486
Reports root/ big
OK: 3573 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_24 / pgsql_mnesia / 27e0486
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 27e0486
Reports root/ big
OK: 2079 / Failed: 0 / User-skipped: 409 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 27e0486
Reports root/ big
OK: 2419 / Failed: 0 / User-skipped: 404 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 27e0486
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 27e0486
Reports root/ big
OK: 3943 / Failed: 0 / User-skipped: 102 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 27e0486
Reports root/ big
OK: 3948 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 27e0486
Reports root/ big
OK: 2259 / Failed: 0 / User-skipped: 396 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 27e0486
Reports root/ big
OK: 3574 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

arcusfelis

ok

chrzaszcz force-pushed the without-mongoose-commands branch from dbd74b5 to c8c8355 Compare September 14, 2022 14:23

mongoose-im mentioned this pull request Sep 14, 2022

CI build failures summary - part 2 #3685

Closed

chrzaszcz force-pushed the without-mongoose-commands branch from c8c8355 to 038fd1f Compare September 15, 2022 07:01

chrzaszcz force-pushed the without-mongoose-commands branch from 038fd1f to fff1672 Compare September 15, 2022 07:33

chrzaszcz force-pushed the without-mongoose-commands branch from fff1672 to 999cb68 Compare September 15, 2022 08:19

Base automatically changed from unified-admin-api to feature/unified-rest-api September 15, 2022 08:21

Paweł Chrząszcz added 10 commits September 15, 2022 14:31

Test mongoose_admin_api instead of the obsolete mongoose_api_admin

a1ff38e

Also: remove mod_*commands from small tests, because this functionality is being removed.

Finish replacing mongoose_api_admin with mongoose_admin_api

818bbf1

Remove the obsolete mongoose_api_admin

3d7e00b

Remove tests for mongoose_commands

898e162

This functionality is being removed.

Remove mod_*commands from big tests

a244b47

Remove mod_*commands

cdb4146

This functionality is now provided by mongoose_admin_api

Remove the obsolete mongoose_commands

b5ec345

Clean up unused functions

80fcc62

'reload_dispatch' is kept as a shell utility

Test the handling of invalid query string

27e0486

chrzaszcz force-pushed the without-mongoose-commands branch from 999cb68 to 27e0486 Compare September 15, 2022 12:40

chrzaszcz marked this pull request as ready for review September 15, 2022 14:12

arcusfelis approved these changes Sep 15, 2022

View reviewed changes

arcusfelis merged commit 72c0612 into feature/unified-rest-api Sep 15, 2022

arcusfelis deleted the without-mongoose-commands branch September 15, 2022 14:58

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get rid of mongoose_commands #3759

Get rid of mongoose_commands #3759

chrzaszcz commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

arcusfelis left a comment

Get rid of mongoose_commands #3759

Get rid of mongoose_commands #3759

Conversation

chrzaszcz commented Sep 14, 2022 • edited Loading

mongoose-im commented Sep 14, 2022 • edited Loading

codecov bot commented Sep 14, 2022 • edited Loading

Codecov Report

mongoose-im commented Sep 14, 2022 • edited Loading

mongoose-im commented Sep 15, 2022 • edited Loading

mongoose-im commented Sep 15, 2022 • edited Loading

mongoose-im commented Sep 15, 2022 • edited Loading

mongoose-im commented Sep 15, 2022 • edited Loading

arcusfelis left a comment

Choose a reason for hiding this comment

chrzaszcz commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 14, 2022 •

edited

Loading

codecov bot commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 14, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading

mongoose-im commented Sep 15, 2022 •

edited

Loading