Fixes AMP big suite #3778
Fixes AMP big suite #3778
Conversation
|
small_tests_24 / small_tests / d4fbad6 ldap_mnesia_24 / ldap_mnesia / d4fbad6 ldap_mnesia_25 / ldap_mnesia / d4fbad6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d4fbad6 small_tests_25 / small_tests / d4fbad6 pgsql_mnesia_24 / pgsql_mnesia / d4fbad6 internal_mnesia_25 / internal_mnesia / d4fbad6 dynamic_domains_mysql_redis_25 / mysql_redis / d4fbad6 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d4fbad6 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d4fbad6 mysql_redis_25 / mysql_redis / d4fbad6 metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d4fbad6 pgsql_mnesia_25 / pgsql_mnesia / d4fbad6 mssql_mnesia_25 / odbc_mssql_mnesia / d4fbad6 riak_mnesia_24 / riak_mnesia / d4fbad6 mysql_redis_25 / mysql_redis / d4fbad6 inbox_SUITE:async_pools:one_to_one:msg_sent_to_offline_user{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_msg_sent_to_offline_user_685@localhost/res1">>},
{<<"to">>,<<"bob_msg_sent_to_offline_user_685@localhost/res1">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"body">>,[],[{xmlcdata,<<"test">>}]},
{xmlel,<<"stanza-id">>,
[{<<"by">>,<<"bob_msg_sent_to_offline_user_685@localhost">>},
{<<"id">>,<<"BQDQFSH5OK01">>},
{<<"xmlns">>,<<"urn:xmpp:sid:0">>}],
[]}]},
"<message from='alice_msg_sent_to_offline_user_685@localhost/res1' to='bob_msg_sent_to_offline_user_685@localhost/res1' type='chat'><body>test</body><stanza-id by='bob_msg_sent_to_offline_user_685@localhost' id='BQDQFSH5OK01' xmlns='urn:xmpp:sid:0'/></message>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{escalus_session,session,1,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,131}]},
{escalus_session,session,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,273}]},
{escalus_connection,connection_step,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,160}]},
{lists,fo...metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Codecov ReportBase: 64.00% // Head: 64.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/mongoose_c2s #3778 +/- ##
========================================================
+ Coverage 64.00% 64.42% +0.42%
========================================================
Files 536 536
Lines 34990 35002 +12
========================================================
+ Hits 22394 22549 +155
+ Misses 12596 12453 -143
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
ldap_mnesia_24 / ldap_mnesia / fc83136 small_tests_24 / small_tests / fc83136 ldap_mnesia_25 / ldap_mnesia / fc83136 small_tests_25 / small_tests / fc83136 internal_mnesia_25 / internal_mnesia / fc83136 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fc83136 pgsql_mnesia_24 / pgsql_mnesia / fc83136 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fc83136 dynamic_domains_mysql_redis_25 / mysql_redis / fc83136 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fc83136 pgsql_mnesia_25 / pgsql_mnesia / fc83136 mysql_redis_25 / mysql_redis / fc83136 metrics_session_SUITE:session_global:session_global{error,
{{totalSessionCount,
{value,1},
[{times,25,
{error,
{badmatch,{value,0}},
[{metrics_helper,assert_counter,3,
[{file,
"/home/circleci/project/big_tests/tests/metrics_helper.erl"},
{line,36}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mssql_mnesia_25 / odbc_mssql_mnesia / fc83136 service_domain_db_SUITE:db:db_get_all_dynamic{error,
{{badrpc,timeout},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,db_get_all_dynamic,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,366}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fc83136 riak_mnesia_24 / riak_mnesia / fc83136 |
|
ldap_mnesia_24 / ldap_mnesia / c61179e small_tests_24 / small_tests / c61179e ldap_mnesia_25 / ldap_mnesia / c61179e small_tests_25 / small_tests / c61179e dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c61179e internal_mnesia_25 / internal_mnesia / c61179e pgsql_mnesia_24 / pgsql_mnesia / c61179e elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c61179e dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c61179e dynamic_domains_mysql_redis_25 / mysql_redis / c61179e dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c61179e mysql_redis_25 / mysql_redis / c61179e pgsql_mnesia_25 / pgsql_mnesia / c61179e riak_mnesia_24 / riak_mnesia / c61179e mssql_mnesia_25 / odbc_mssql_mnesia / c61179e |
There was a problem hiding this comment.
Brilliant! 😃
Basically the only important comment: re-enable the amp suite in big_tests/default.spec and big_tests/dynamic_domains.spec, we need to know they pass.
A second comment, a note for the future: the c2s_preprocessing_hook has a bit of a redundant logic, with that drop trick, where modern hooks as we reworked them could simply return {stop, Acc} and subsequent handlers won't be run so they won't have to check for the drop key. Anyway right now we want to do one refactor at a time so leave it as it is, but, we will come back here 😄
| run_initial_check(Acc, _C2SState) -> | ||
| -spec run_initial_check(mongoose_acc:t(), mongoose_c2s:hook_params(), gen_hook:extra()) -> | ||
| mongoose_c2s_hooks:hook_result(). | ||
| run_initial_check(#{result := drop} = Acc, _Params, _Extra) -> |
There was a problem hiding this comment.
Actually this is a bug in the old code, the acc will store the result in something like #{{hook, result} := drop}, in mongoose_acc keys are pairs with a namespace. We shouldn't do that anyway, mongoose_acc is an abstract data structure, we should do case mongoose_acc:get(hook, result, undefined, Acc) of and match on drop or on whatever else 🤔
|
small_tests_24 / small_tests / fb541ff ldap_mnesia_24 / ldap_mnesia / fb541ff ldap_mnesia_25 / ldap_mnesia / fb541ff dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / fb541ff small_tests_25 / small_tests / fb541ff internal_mnesia_25 / internal_mnesia / fb541ff pgsql_mnesia_24 / pgsql_mnesia / fb541ff elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / fb541ff dynamic_domains_mysql_redis_25 / mysql_redis / fb541ff dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / fb541ff pgsql_mnesia_25 / pgsql_mnesia / fb541ff riak_mnesia_24 / riak_mnesia / fb541ff dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / fb541ff mssql_mnesia_25 / odbc_mssql_mnesia / fb541ff smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched{error,
{{fetch_marker,ok,
[{times,50,
{error,
{badmatch,[]},
[{smart_markers_SUITE,'-verify_marker_fetch/4-fun-6-',3,
[{file,
"/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
{line,405}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}mysql_redis_25 / mysql_redis / fb541ff mssql_mnesia_25 / odbc_mssql_mnesia / fb541ff |
|
ldap_mnesia_24 / ldap_mnesia / 57a5e59 small_tests_24 / small_tests / 57a5e59 ldap_mnesia_25 / ldap_mnesia / 57a5e59 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 57a5e59 mam_SUITE:rdbms_async_pool_muc_light:init_per_group{'EXIT',
{{badrpc,
{'EXIT',
{{start_child_failed,
{error,
{{shutdown,
{failed_to_start_child,'pm_mam_async_pool_test type',
{shutdown,
{failed_to_start_child,
'wpool_pool-pm_mam_async_pool_test type-process-sup',
{shutdown,
{failed_to_start_child,
'wpool_pool-pm_mam_async_pool_test type-3',
{already_started,<8807.16327.1>}}}}}}},
{child,undefined,'pm_mam_sup_async_pool_test type',
{mongoose_async_pools,start_link,
[<<"test type">>,pm_mam,
#{batch_name => insert_mam_messages30,batch_size => 30,
enabled => true,
flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
flush_extra =>
#{batch_name => insert_mam_messages30,batch_size => 30,
enabled => true,flush_interval => 1,pool_size => 16},
flush_interval => 1,pool_size => 16,pool_type => batch}]},
transient,false,infinity,supervisor,
[mongoose_async_pools]}}},
#{id => 'pm_mam_sup_async_pool_test type',restart => transient,
start =>
{mongoose_async_pools,start_link,
[<<"test type">>,pm_mam,
#{batch_name => insert_mam_messages30,batch_size => 30,
enabled => true,
flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
flush_extra =>
#{batch_name => insert_mam_messages30,batch_size => 30,
enabled => true,flush_interval => 1,pool_size => 16},
flush_interval => 1,pool_size => 16,pool_type => batch}]},
type => superviso...small_tests_25 / small_tests / 57a5e59 pgsql_mnesia_24 / pgsql_mnesia / 57a5e59 internal_mnesia_25 / internal_mnesia / 57a5e59 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 57a5e59 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 57a5e59 pgsql_mnesia_25 / pgsql_mnesia / 57a5e59 mysql_redis_25 / mysql_redis / 57a5e59 riak_mnesia_24 / riak_mnesia / 57a5e59 dynamic_domains_mysql_redis_25 / mysql_redis / 57a5e59 bosh_SUITE:chat:interleave_requests{error,
{{badmatch,
{error,
{connection_step_failed,
{{escalus_session,authenticate},
{client,<<"carol@domain.example.com/bosh">>,escalus_bosh,
<0.8275.0>,undefined,
[{event_client,
[{event_manager,<0.8272.0>},
{server,<<"domain.example.com">>},
{username,<<"carol">>},
{resource,<<"bosh">>}]},
{resource,<<"bosh">>},
{username,<<"carol">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{port,5280},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{keepalive,false},
{username,<<"carol">>},
{server,<<"domain.example.com">>},
{host,<<"localhost">>},
{password,<<"jinglebells">>},
{transport,escalus_bosh},
{path,<<"/http-bind">>},
{port,5280}]},
[{compression,false},
{starttls,false},
{stream_management,true},
{advanced_message_processing,true},
{client_state_indication,false},
{sasl_mechanisms,[<<"SCRAM-SHA-256">>,<<"PLAIN">>]},
{caps,undefined}]},
{timeout,wait_for_features}}}},
[{bosh_SUITE,start_client,3,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,840}]},
{bosh_SUITE,'-interleave_requests/1-fun-0-',2,
[{file,"/home/circl...dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 57a5e59 mssql_mnesia_25 / odbc_mssql_mnesia / 57a5e59 service_domain_db_SUITE:db:db_could_sync_between_nodes{error,
{{badrpc,{'EXIT',{timeout,{gen_server,call,[service_domain_db,ping]}}}},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,db_could_sync_between_nodes,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,568}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}service_domain_db_SUITE:db:db_deleted_from_one_node_while_service_disabled_on_another{error,
{{badrpc,{'EXIT',{timeout,{gen_server,call,[service_domain_db,ping]}}}},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,
db_deleted_from_one_node_while_service_disabled_on_another,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,573}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}}service_domain_db_SUITE:db:db_reinserted_from_one_node_while_service_disabled_on_another{error,
{{badrpc,{'EXIT',{timeout,{gen_server,call,[service_domain_db,ping]}}}},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},service_domain_db,sync_local,[]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,117}]},
{service_domain_db_SUITE,sync_local,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1205}]},
{service_domain_db_SUITE,sync,0,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,1184}]},
{service_domain_db_SUITE,
db_reinserted_from_one_node_while_service_disabled_on_another,1,
[{file,
"/home/circleci/project/big_tests/tests/service_domain_db_SUITE.erl"},
{line,598}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
Fixes AMP big suite.