Fix muc validation in graphql #3799

arcusfelis · 2022-10-07T08:53:49Z

This PR addresses #3752

Proposed changes include:

Check the result of make_jid
Require from argument.

mongoose-im · 2022-10-07T09:02:28Z

small_tests_24 / small_tests / 31c3b95
Reports root / small

small_tests_25 / small_tests / 31c3b95
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 31c3b95
Reports root/ big
OK: 2081 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 31c3b95
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 31c3b95
Reports root/ big
OK: 2081 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 31c3b95
Reports root/ big
OK: 3931 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 31c3b95
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 31c3b95
Reports root/ big
OK: 2217 / Failed: 0 / User-skipped: 633 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 31c3b95
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 31c3b95
Reports root/ big
OK: 2557 / Failed: 0 / User-skipped: 628 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 31c3b95
Reports root/ big
OK: 4331 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 31c3b95
Reports root/ big
OK: 4317 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 31c3b95
Reports root/ big
OK: 2397 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 31c3b95
Reports root/ big
OK: 4324 / Failed: 2 / User-skipped: 97 / Auto-skipped: 5

mam_SUITE:rdbms_async_pool_muc_light:init_per_group

{'EXIT',
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,pm_mam_async_pool_localhost,
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_localhost-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_localhost-1',
        {already_started,<9158.31235.1>}}}}}}},
    {child,undefined,pm_mam_sup_async_pool_localhost,
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 1,pool_size => 16},
       flush_interval => 1,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => pm_mam_sup_async_pool_localhost,restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 1,pool_size => 16},
       flush_interval => 1,pool_size => 16,pool_type => batch}]},
    type => supervisor}},
 ...

Report log

mam_SUITE:rdbms_async_cache_prefs_cases:end_per_group

{error,
 {{badrpc,
   {'EXIT',
  {{start_child_failed,
    {error,
     {{shutdown,
     {failed_to_start_child,pm_mam_async_pool_localhost,
      {shutdown,
       {failed_to_start_child,
      'wpool_pool-pm_mam_async_pool_localhost-process-sup',
      {shutdown,
       {failed_to_start_child,
        'wpool_pool-pm_mam_async_pool_localhost-4',
        {already_started,<9158.6213.2>}}}}}}},
    {child,undefined,pm_mam_sup_async_pool_localhost,
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
     transient,false,infinity,supervisor,
     [mongoose_async_pools]}}},
    #{id => pm_mam_sup_async_pool_localhost,restart => transient,
    start =>
     {mongoose_async_pools,start_link,
      [<<"localhost">>,pm_mam,
       #{batch_name => insert_mam_messages30,batch_size => 30,
       enabled => true,
       flush_callback => fun mod_mam_rdbms_arch_async:flush/2,
       flush_extra =>
        #{batch_name => insert_mam_messages30,batch_size => 30,
        enabled => true,flush_interval => 2000,pool_size => 16},
       flush_interval => 2000,pool_size => 16,pool_type => batch}]},
    type => super...

Report log

mam_SUITE:rdbms_async_cache_disabled_complex_queries:mam04:pagination_simple_enforced

{error,{{badmatch,[]},
    [{mam_SUITE,'-pagination_simple_enforced/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,1279}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mam_SUITE:rdbms_async_cache_disabled_retraction:mam06:retract_message

{error,{{archive_size,1,[{times,200,0}]},
    [{mongoose_helper,do_wait_until,2,
              [{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
               {line,371}]},
     {mam_SUITE,'-test_retract_message/1-fun-0-',4,
          [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
           {line,1782}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 31c3b95
Reports root/ big
OK: 4329 / Failed: 2 / User-skipped: 97 / Auto-skipped: 0

muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive

{error,{{assertion_failed,assert,is_groupchat_message,
              [<<"Restorable message">>],
              undefined,"undefined"},
    [{escalus_new_assert,assert_true,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
                {line,84}]},
     {muc_SUITE,wait_for_mam_result,3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4394}]},
     {muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4130}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
          [{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
           {line,4126}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

rest_client_SUITE:roster:add_contact_and_invite

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_add_contact_and_invite_2968@localhost/res1">>,
          escalus_tcp,<0.31270.2>,
          [{event_manager,<0.31234.2>},
           {server,<<"localhost">>},
           {username,<<"alicE_add_contact_and_invite_2968">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.31234.2>},
            {server,<<"localhost">>},
            {username,<<"alicE_add_contact_and_invite_2968">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_add_contact_and_invite_2968">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_add_contact_and_invite_2968">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"20a32850e3d025d9">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {rest_client_SUITE,'-add_contact_and_invite/1-fun-0-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/rest_client_SUITE.erl"},
        {line,1102}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       ...

Report log

pgsql_mnesia_25 / pgsql_mnesia / 31c3b95
Reports root/ big
OK: 4331 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 31c3b95
Reports root/ big
OK: 4331 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

codecov · 2022-10-07T09:04:13Z

Codecov Report

Base: 83.03% // Head: 83.01% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (02603b4) compared to base (7ced8ba).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3799      +/-   ##
==========================================
- Coverage   83.03%   83.01%   -0.03%     
==========================================
  Files         529      529              
  Lines       33886    33886              
==========================================
- Hits        28138    28130       -8     
- Misses       5748     5756       +8

Impacted Files	Coverage Δ
src/mod_muc_api.erl	`99.45% <100.00%> (ø)`
src/elasticsearch/mongoose_elasticsearch.erl	`76.92% <0.00%> (-7.70%)`	⬇️
src/cassandra/mongoose_cassandra.erl	`77.77% <0.00%> (-3.71%)`	⬇️
src/mam/mod_mam_muc_rdbms_arch_async.erl	`82.85% <0.00%> (-2.86%)`	⬇️
src/cassandra/mongoose_cassandra_worker.erl	`66.03% <0.00%> (-2.84%)`	⬇️
src/mam/mod_mam_elasticsearch_arch.erl	`86.60% <0.00%> (-1.79%)`	⬇️
src/mod_roster_riak.erl	`96.92% <0.00%> (-1.54%)`	⬇️
src/mod_roster.erl	`78.70% <0.00%> (-0.72%)`	⬇️
src/rdbms/mongoose_rdbms.erl	`66.31% <0.00%> (+1.05%)`	⬆️
src/global_distrib/mod_global_distrib_receiver.erl	`80.72% <0.00%> (+1.20%)`	⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/mod_muc_api.erl

mongoose-im · 2022-10-13T08:25:44Z

small_tests_24 / small_tests / e1e6433
Reports root / small

small_tests_25 / small_tests / e1e6433
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e1e6433
Reports root/ big
OK: 2081 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e1e6433
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / e1e6433
Reports root/ big
OK: 3931 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / e1e6433
Reports root/ big
OK: 2081 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e1e6433
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / e1e6433
Reports root/ big
OK: 2217 / Failed: 0 / User-skipped: 633 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e1e6433
Reports root/ big
OK: 2557 / Failed: 0 / User-skipped: 628 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / e1e6433
Reports root/ big
OK: 3957 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e1e6433
Reports root/ big
OK: 4342 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2716@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2716@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"6VVl1rAoFtl5gSsmkJdlUg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / e1e6433
Reports root/ big
OK: 4342 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2569@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2569@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"aZChkyvGext/XrieX2U/uQ==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

riak_mnesia_24 / riak_mnesia / e1e6433
Reports root/ big
OK: 2397 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / e1e6433
Reports root/ big
OK: 4317 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / e1e6433
Reports root/ big
OK: 4331 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

chrzaszcz

Looks good

Add graphql_muc_SUITE:user_try_create_instant_room_with_invalid_name testcase

Otherwise null is passed into a room process which crashes the process

mongoose-im · 2022-10-21T10:02:40Z

small_tests_24 / small_tests / 02603b4
Reports root / small

small_tests_25 / small_tests / 02603b4
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 02603b4
Reports root/ big
OK: 2099 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 02603b4
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 02603b4
Reports root/ big
OK: 2099 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 02603b4
Reports root/ big
OK: 3963 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 02603b4
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 02603b4
Reports root/ big
OK: 4374 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription

{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2603@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2603@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"BhE1BBPd1hYHzYslQ2CmQA==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

internal_mnesia_25 / internal_mnesia / 02603b4
Reports root/ big
OK: 2235 / Failed: 0 / User-skipped: 647 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 02603b4
Reports root/ big
OK: 2577 / Failed: 0 / User-skipped: 640 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 02603b4
Reports root/ big
OK: 4363 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 02603b4
Reports root/ big
OK: 2423 / Failed: 0 / User-skipped: 626 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 02603b4
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 02603b4
Reports root/ big
OK: 4362 / Failed: 2 / User-skipped: 97 / Auto-skipped: 3

inbox_extensions_SUITE:async_pools:one_to_one:mute_muted_entry_gets_unmuted

{error,
  {{assert,
     [{module,inbox_extensions_SUITE},
      {line,798},
      {expression,"escalus_pred : is_message ( Message )"},
      {expected,true},
      {value,false}]},
   [{inbox_extensions_SUITE,check_message_with_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,798}]},
    {inbox_extensions_SUITE,set_inbox_properties,4,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,792}]},
    {inbox_extensions_SUITE,'-mute_muted_entry_gets_unmuted/1-fun-2-',2,
      [{file,
         "/home/circleci/project/big_tests/tests/inbox_extensions_SUITE.erl"},
       {line,568}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pubsub_SUITE:tree+hometree_specific:can_create_node_with_existing_parent_path

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {pubsub_SUITE,'-can_create_node_with_existing_parent_path/1-fun-0-',
             1,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,1802}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 02603b4
Reports root/ big
OK: 4349 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 02603b4
Reports root/ big
OK: 4363 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

kamilwaz

There was one small typo (are to is) that I fixed it by myself. The rest was 👍

mongoose-im mentioned this pull request Oct 7, 2022

CI build failures summary - part 2 #3685

Closed

kamilwaz requested changes Oct 11, 2022

View reviewed changes

src/mod_muc_api.erl Outdated Show resolved Hide resolved

arcusfelis force-pushed the mu-fix-muc-validation-in-graphql branch from 31c3b95 to e1e6433 Compare October 13, 2022 08:17

chrzaszcz approved these changes Oct 21, 2022

View reviewed changes

arcusfelis and others added 3 commits October 21, 2022 11:52

Check jid format in muc api #3752

ffc4fcf

Add graphql_muc_SUITE:user_try_create_instant_room_with_invalid_name testcase

Make from required to pass in listRooms

fc04bed

Otherwise null is passed into a room process which crashes the process

Fix typo in error message

02603b4

kamilwaz force-pushed the mu-fix-muc-validation-in-graphql branch from e1e6433 to 02603b4 Compare October 21, 2022 09:54

kamilwaz approved these changes Oct 21, 2022

View reviewed changes

kamilwaz merged commit 187cb40 into master Oct 21, 2022

kamilwaz deleted the mu-fix-muc-validation-in-graphql branch October 21, 2022 11:08

chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix muc validation in graphql #3799

Fix muc validation in graphql #3799

arcusfelis commented Oct 7, 2022

mongoose-im commented Oct 7, 2022 •

edited

Loading

codecov bot commented Oct 7, 2022 •

edited

Loading

mongoose-im commented Oct 13, 2022 •

edited

Loading

chrzaszcz left a comment

mongoose-im commented Oct 21, 2022 •

edited

Loading

kamilwaz left a comment

Fix muc validation in graphql #3799

Fix muc validation in graphql #3799

Conversation

arcusfelis commented Oct 7, 2022

mongoose-im commented Oct 7, 2022 • edited Loading

codecov bot commented Oct 7, 2022 • edited Loading

Codecov Report

mongoose-im commented Oct 13, 2022 • edited Loading

chrzaszcz left a comment

Choose a reason for hiding this comment

mongoose-im commented Oct 21, 2022 • edited Loading

kamilwaz left a comment

Choose a reason for hiding this comment

mongoose-im commented Oct 7, 2022 •

edited

Loading

codecov bot commented Oct 7, 2022 •

edited

Loading

mongoose-im commented Oct 13, 2022 •

edited

Loading

mongoose-im commented Oct 21, 2022 •

edited

Loading