Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored hook handler in mod_jingle_sip module #3802

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Refactored hook handler in mod_jingle_sip module #3802

merged 1 commit into from
Oct 10, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_jingle_sip module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 10, 2022 •
edited
Loading

small_tests_24 / small_tests / 04df9f2
Reports root / small

small_tests_25 / small_tests / 04df9f2
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 04df9f2
Reports root/ big
OK: 2080 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 04df9f2
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 04df9f2
Reports root/ big
OK: 2080 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 04df9f2
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 04df9f2
Reports root/ big
OK: 3929 / Failed: 1 / User-skipped: 114 / Auto-skipped: 0

rest_SUITE:admin:session_can_be_kicked 
{error,{test_case_failed,[70,97,105,108,58,32,
              [60,60,
               "\"alice_session_can_be_kicked_2377@domain.example.com/res1\"",
               62,62],
              32,105,110,32,
              [91,
               [[60,60,
               "\"alice_session_can_be_kicked_2377@domain.example.com/res1\"",
               62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,
               ["  ",32,32],
               "  ",32,32],
              [60,60,
               "\"alice_messages_are_sent_and_received_2379@domain.example.com/res1\"",
               62,62],
              44,10,
              [32,
               [[[32,["  ",32,32],"  ",32,32],
                 32,
                 ["  ",32,32],
                 "  ",32,32],
                [32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [[32,["  ",32,32],"  ",32,32],
                32,
                ["  ",32,32],
                "  ",32,32],
               [32,["  ",32,32],"  ",32,32],
               32,...

Report log

internal_mnesia_25 / internal_mnesia / 04df9f2
Reports root/ big
OK: 2216 / Failed: 0 / User-skipped: 633 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 04df9f2
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 04df9f2
Reports root/ big
OK: 2556 / Failed: 0 / User-skipped: 628 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 04df9f2
Reports root/ big
OK: 4341 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2639@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2639@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"3f2DfbYXb/phxsqJ39vaIg==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 04df9f2
Reports root/ big
OK: 4316 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 04df9f2
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 04df9f2
Reports root/ big
OK: 4330 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Base: 82.87% // Head: 82.88% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2239501) compared to base (5b3e266).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
+ Coverage   82.87%   82.88%   +0.01%     
==========================================
  Files         529      529              
  Lines       33808    33812       +4     
==========================================
+ Hits        28017    28024       +7     
+ Misses       5791     5788       -3
Impacted Files Coverage Δ
src/jingle_sip/mod_jingle_sip.erl 79.92% <100.00%> (+0.07%) ⬆️
src/mongoose_hooks.erl 96.10% <100.00%> (+0.05%) ⬆️
src/mod_roster_riak.erl 96.92% <0.00%> (-1.54%) ⬇️
src/muc_light/mod_muc_light_db_mnesia.erl 91.57% <0.00%> (-1.06%) ⬇️
src/mod_roster.erl 78.46% <0.00%> (-0.72%) ⬇️
src/mod_muc_api.erl 98.91% <0.00%> (-0.55%) ⬇️
src/mod_muc_log.erl 62.82% <0.00%> (ø)
src/mod_muc_room.erl 78.56% <0.00%> (+0.17%) ⬆️
src/rdbms/mongoose_rdbms.erl 66.31% <0.00%> (+1.05%) ⬆️
src/inbox/mod_inbox_rdbms_async.erl 72.05% <0.00%> (+2.94%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im mongoose-im mentioned this pull request Oct 10, 2022
Closed
@pawlooss1 pawlooss1 force-pushed the hooks/mod_jingle_sip branch from 04df9f2 to 2239501 Compare October 10, 2022 11:53
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 10, 2022 •
edited
Loading

small_tests_24 / small_tests / 2239501
Reports root / small

small_tests_25 / small_tests / 2239501
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 2239501
Reports root/ big
OK: 2080 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 2239501
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 2239501
Reports root/ big
OK: 2080 / Failed: 0 / User-skipped: 769 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 2239501
Reports root/ big
OK: 3930 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 2239501
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 2239501
Reports root/ big
OK: 2216 / Failed: 0 / User-skipped: 633 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 2239501
Reports root/ big
OK: 4330 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 2239501
Reports root/ big
OK: 2556 / Failed: 0 / User-skipped: 628 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 2239501
Reports root/ big
OK: 3956 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 2239501
Reports root/ big
OK: 4329 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

bosh_SUITE:essential:accept_higher_hold_value 
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,251},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"7231d1cbee03f6617cb4f9bb1f6c4728a49d6a40">>,
           <9158.6066.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,251}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / 2239501
Reports root/ big
OK: 4316 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 2239501
Reports root/ big
OK: 2396 / Failed: 0 / User-skipped: 620 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 2239501
Reports root/ big
OK: 4341 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription 
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_unsubscribe_after_presence_unsubscription_2585@localhost">>},
         {<<"to">>,
        <<"bob_unsubscribe_after_presence_unsubscription_2585@localhost/res1">>},
         {<<"type">>,<<"headline">>}],
        [{xmlel,<<"event">>,
           [{<<"xmlns">>,
           <<"http://jabber.org/protocol/pubsub#event">>}],
           [{xmlel,<<"items">>,
            [{<<"node">>,<<"il64yDXq8sJrrUroqr4Pzw==">>}],
            [{xmlel,<<"item">>,
               [{<<"id">>,<<"salmon">>}],
               [{xmlel,<<"entry">>,
                  [{<<"xmlns">>,
                  <<"http://www.w3.org/2005/Atom">>}],
                  []}]}]}]},
         {xmlel,<<"headers">>,
           [{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
           []}]}]},
   [{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
      [{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
       {line,384}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

pgsql_mnesia_25 / pgsql_mnesia / 2239501
Reports root/ big
OK: 4330 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review October 10, 2022 12:57
NelsonVides
NelsonVides approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@NelsonVides NelsonVides merged commit 435451f into master Oct 10, 2022
@NelsonVides NelsonVides deleted the hooks/mod_jingle_sip branch October 10, 2022 13:42
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pawlooss1 @mongoose-im @NelsonVides @chrzaszcz