Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored hook handlers in mod_carboncopy #3818

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Refactored hook handlers in mod_carboncopy #3818

merged 1 commit into from
Oct 24, 2022

Conversation

pawlooss1
Copy link
Member

This PR changes all hook handlers in mod_carboncopy module to gen_hook format.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 20, 2022 •
edited
Loading

small_tests_24 / small_tests / c68d235
Reports root / small

small_tests_25 / small_tests / c68d235
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c68d235
Reports root/ big
OK: 3988 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / c68d235
Reports root/ big
OK: 2098 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / c68d235
Reports root/ big
OK: 2105 / Failed: 1 / User-skipped: 784 / Auto-skipped: 0

pubsub_SUITE:dag+node_config:disable_notifications_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c68d235
Reports root/ big
OK: 3988 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / c68d235
Reports root/ big
OK: 3962 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c68d235
Reports root/ big
OK: 3988 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / c68d235
Reports root/ big
OK: 4362 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / c68d235
Reports root/ big
OK: 2234 / Failed: 0 / User-skipped: 647 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c68d235
Reports root/ big
OK: 2576 / Failed: 0 / User-skipped: 640 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / c68d235
Reports root/ big
OK: 2422 / Failed: 0 / User-skipped: 626 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / c68d235
Reports root/ big
OK: 4348 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / c68d235
Reports root/ big
OK: 4362 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / c68d235
Reports root/ big
OK: 4362 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

@codecov
Copy link

codecov bot commented Oct 20, 2022 •
edited
Loading

Codecov Report

Base: 83.01% // Head: 83.03% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7ced8ba) compared to base (02603b4).
Patch has no changes to coverable lines.

❗ Current head 7ced8ba differs from pull request most recent head a5dfba6. Consider uploading reports for the commit a5dfba6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3818      +/-   ##
==========================================
+ Coverage   83.01%   83.03%   +0.02%     
==========================================
  Files         529      529              
  Lines       33886    33886              
==========================================
+ Hits        28130    28138       +8     
+ Misses       5756     5748       -8
Impacted Files Coverage Δ
src/mongoose_cleaner.erl 60.00% <0.00%> (-10.00%) ⬇️
src/global_distrib/mod_global_distrib_receiver.erl 79.51% <0.00%> (-1.21%) ⬇️
src/rdbms/mongoose_rdbms.erl 65.26% <0.00%> (-1.06%) ⬇️
src/mod_muc_api.erl 99.45% <0.00%> (ø)
src/mod_roster.erl 79.42% <0.00%> (+0.71%) ⬆️
src/mod_roster_riak.erl 98.46% <0.00%> (+1.53%) ⬆️
src/mam/mod_mam_elasticsearch_arch.erl 88.39% <0.00%> (+1.78%) ⬆️
src/cassandra/mongoose_cassandra_worker.erl 68.86% <0.00%> (+2.83%) ⬆️
src/mam/mod_mam_muc_rdbms_arch_async.erl 85.71% <0.00%> (+2.85%) ⬆️
src/cassandra/mongoose_cassandra.erl 81.48% <0.00%> (+3.70%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pawlooss1 pawlooss1 force-pushed the hooks/mod_carboncopy branch from c68d235 to 16417b2 Compare October 21, 2022 09:52
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 21, 2022 •
edited
Loading

small_tests_24 / small_tests / 16417b2
Reports root / small

small_tests_25 / small_tests / 16417b2
Reports root / small

ldap_mnesia_24 / ldap_mnesia / 16417b2
Reports root/ big
OK: 2098 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 16417b2
Reports root/ big
OK: 3988 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 16417b2
Reports root/ big
OK: 2098 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 16417b2
Reports root/ big
OK: 3962 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 16417b2
Reports root/ big
OK: 2234 / Failed: 0 / User-skipped: 647 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 16417b2
Reports root/ big
OK: 4362 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 16417b2
Reports root/ big
OK: 3988 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 16417b2
Reports root/ big
OK: 4362 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 16417b2
Reports root/ big
OK: 2422 / Failed: 0 / User-skipped: 626 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 16417b2
Reports root/ big
OK: 4348 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 16417b2
Reports root/ big
OK: 4357 / Failed: 5 / User-skipped: 97 / Auto-skipped: 0

smart_markers_SUITE:regular:one2one:repeated_markers_produce_no_warnings 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_repeated_markers_produce_no_warnings_3070@localhost/res1">>,
          escalus_tcp,<0.2870.3>,
          [{event_manager,<0.2854.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_repeated_markers_produce_no_warnings_3070">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.2854.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_repeated_markers_produce_no_warnings_3070">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_repeated_markers_produce_no_warnings_3070">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_repeated_markers_produce_no_warnings_3070">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"b4e37d697c534cc8">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,
       '-repeated_markers_produce_no_warnings/1-fun-1-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
        {...

Report log

smart_markers_SUITE:regular:one2one:marker_after_timestamp_for_threadid_can_be_fetched 
{error,{{badmatch,0},
    [{escalus_story,drop_presences,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,191}]},
     {escalus_story,'-start_ready_clients/2-fun-0-',3,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,135}]},
     {lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
     {escalus_story,start_ready_clients,2,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,128}]},
     {lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
     {lists,flatmap_1,2,[{file,"lists.erl"},{line,1335}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,69}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}]}}

Report log

smart_markers_SUITE:regular:one2one:remove_markers_when_removed_user 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_remove_markers_when_removed_user_3069@localhost/res1">>,
          escalus_tcp,<0.2875.3>,
          [{event_manager,<0.2848.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_remove_markers_when_removed_user_3069">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.2848.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_remove_markers_when_removed_user_3069">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_remove_markers_when_removed_user_3069">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_remove_markers_when_removed_user_3069">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"a3560b471eba0d9d">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,'-remove_markers_when_removed_user/1-fun-2-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
        {line,241}]},
     {escalus_story...

Report log

smart_markers_SUITE:regular:one2one:marker_after_timestamp_can_be_fetched 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_marker_after_timestamp_can_be_fetched_3071@localhost/res1">>,
          escalus_tcp,<0.2876.3>,
          [{event_manager,<0.2857.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_marker_after_timestamp_can_be_fetched_3071">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.2857.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_marker_after_timestamp_can_be_fetched_3071">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_marker_after_timestamp_can_be_fetched_3071">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_marker_after_timestamp_can_be_fetched_3071">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"1003e16db5689a4a">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,
       '-marker_after_timestamp_can_be_fetched/1-fun-0-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
   ...

Report log

smart_markers_SUITE:regular:one2one:marker_for_thread_can_be_fetched 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_marker_for_thread_can_be_fetched_3067@localhost/res1">>,
          escalus_tcp,<0.2874.3>,
          [{event_manager,<0.2829.3>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_marker_for_thread_can_be_fetched_3067">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.2829.3>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_marker_for_thread_can_be_fetched_3067">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_marker_for_thread_can_be_fetched_3067">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_marker_for_thread_can_be_fetched_3067">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"f209c1291ead10fb">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {smart_markers_SUITE,'-marker_for_thread_can_be_fetched/1-fun-0-',2,
       [{file,
          "/home/circleci/project/big_tests/tests/smart_markers_SUITE.erl"},
        {line,209}]},
     {escalus_story...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 16417b2
Reports root/ big
OK: 4361 / Failed: 1 / User-skipped: 97 / Auto-skipped: 0

push_integration_SUITE:pubsub_ful:pm_notifications_with_inbox:inbox_msg_reset_unread_count_apns 
{error,
  {{assertMatch,
     [{module,push_integration_SUITE},
      {line,662},
      {expression,"Data"},
      {pattern,"# { << \"message-count\" >> := ExpectedCount }"},
      {value,
        #{<<"last-message-body">> => <<"SECOND MESSAGE">>,
        <<"last-message-sender">> =>
          <<"alice_inbox_msg_reset_unread_count_apns_2788@localhost">>,
        <<"message-count">> => 1}}]},
   [{push_integration_SUITE,check_notification,2,
      [{file,
         "/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
       {line,662}]},
    {push_integration_SUITE,'-inbox_msg_reset_unread_count/3-fun-0-',5,
      [{file,
         "/home/circleci/project/big_tests/tests/push_integration_SUITE.erl"},
       {line,598}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1291}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1223}]}]}}

Report log

@pawlooss1 pawlooss1 force-pushed the hooks/mod_carboncopy branch from 16417b2 to a5dfba6 Compare October 21, 2022 11:09
@mongoose-im
Copy link
Collaborator

mongoose-im commented Oct 21, 2022 •
edited
Loading

small_tests_24 / small_tests / a5dfba6
Reports root / small

small_tests_25 / small_tests / a5dfba6
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a5dfba6
Reports root/ big
OK: 3988 / Failed: 1 / User-skipped: 88 / Auto-skipped: 0

bosh_SUITE:essential:accept_higher_hold_value 
{error,
  {{assertEqual,
     [{module,bosh_SUITE},
      {line,251},
      {expression,"get_bosh_sessions ( )"},
      {expected,[]},
      {value,
        [{bosh_session,<<"b8a4da9966e73d570bc64d803c14d49ce75c8cce">>,
           <8833.6034.0>}]}]},
   [{bosh_SUITE,accept_higher_hold_value,1,
      [{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
       {line,251}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
    {test_server,run_test_case_eval1,6,
      [{file,"test_server.erl"},{line,1292}]},
    {test_server,run_test_case_eval,9,
      [{file,"test_server.erl"},{line,1224}]}]}}

Report log

ldap_mnesia_24 / ldap_mnesia / a5dfba6
Reports root/ big
OK: 2099 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a5dfba6
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / a5dfba6
Reports root/ big
OK: 2099 / Failed: 0 / User-skipped: 783 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / a5dfba6
Reports root/ big
OK: 3963 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / a5dfba6
Reports root/ big
OK: 2235 / Failed: 0 / User-skipped: 647 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a5dfba6
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a5dfba6
Reports root/ big
OK: 2577 / Failed: 0 / User-skipped: 640 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / a5dfba6
Reports root/ big
OK: 4363 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / a5dfba6
Reports root/ big
OK: 4349 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / a5dfba6
Reports root/ big
OK: 2423 / Failed: 0 / User-skipped: 626 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / a5dfba6
Reports root/ big
OK: 4363 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a5dfba6
Reports root/ big
OK: 3989 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

@pawlooss1 pawlooss1 marked this pull request as ready for review October 24, 2022 07:59
NelsonVides
NelsonVides approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏽

@NelsonVides NelsonVides merged commit 6d4933b into master Oct 24, 2022
@NelsonVides NelsonVides deleted the hooks/mod_carboncopy branch October 24, 2022 11:03
@chrzaszcz chrzaszcz added this to the 6.0.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

@DenysGonchar DenysGonchar Awaiting requested review from DenysGonchar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pawlooss1 @mongoose-im @NelsonVides @chrzaszcz