-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jwerl #3823
Update jwerl #3823
Conversation
small_tests_24 / small_tests / 0efb3ac small_tests_25 / small_tests / 0efb3ac ldap_mnesia_24 / ldap_mnesia / 0efb3ac dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0efb3ac ldap_mnesia_25 / ldap_mnesia / 0efb3ac dynamic_domains_mysql_redis_25 / mysql_redis / 0efb3ac dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0efb3ac dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0efb3ac internal_mnesia_25 / internal_mnesia / 0efb3ac pgsql_mnesia_24 / pgsql_mnesia / 0efb3ac muc_http_api_SUITE:negative:kick_user_errors{error,{{timeout,ok,[{times,50,not_yet}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{muc_http_api_SUITE,kick_user_errors,1,
[{file,"/home/circleci/project/big_tests/tests/muc_http_api_SUITE.erl"},
{line,325}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2574@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2574@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"3aSU4IMwczOBlsYUiNRI9Q==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0efb3ac pgsql_mnesia_25 / pgsql_mnesia / 0efb3ac riak_mnesia_24 / riak_mnesia / 0efb3ac mysql_redis_25 / mysql_redis / 0efb3ac mssql_mnesia_25 / odbc_mssql_mnesia / 0efb3ac pgsql_mnesia_24 / pgsql_mnesia / 0efb3ac |
Codecov ReportBase: 83.03% // Head: 83.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3823 +/- ##
==========================================
- Coverage 83.03% 83.02% -0.01%
==========================================
Files 529 529
Lines 33886 33886
==========================================
- Hits 28138 28135 -3
- Misses 5748 5751 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rebar.config
Outdated
@@ -108,8 +108,7 @@ | |||
|
|||
%%% Other | |||
{pa, {git, "https://github.com/erszcz/pa.git", {branch, "master"}}}, | |||
%% MR of jwerl - https://gitlab.com/glejeune/jwerl/-/merge_requests/13 | |||
{jwerl, {git, "https://gitlab.com/vkatsuba/jwerl.git", {branch, "refactoring/otp-24"}}}, | |||
{jwerl, {git, "https://gitlab.com/glejeune/jwerl.git", {tag, "1.2.0"}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A hex package was also published, better use that one: https://hex.pm/packages/jwerl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏽
small_tests_24 / small_tests / b7e66fb small_tests_25 / small_tests / b7e66fb ldap_mnesia_24 / ldap_mnesia / b7e66fb dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b7e66fb ldap_mnesia_25 / ldap_mnesia / b7e66fb dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b7e66fb dynamic_domains_mysql_redis_25 / mysql_redis / b7e66fb internal_mnesia_25 / internal_mnesia / b7e66fb pgsql_mnesia_24 / pgsql_mnesia / b7e66fb dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b7e66fb muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b7e66fb pgsql_mnesia_25 / pgsql_mnesia / b7e66fb riak_mnesia_24 / riak_mnesia / b7e66fb mssql_mnesia_25 / odbc_mssql_mnesia / b7e66fb mysql_redis_25 / mysql_redis / b7e66fb jingle_SUITE:all:mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,
<<"bob_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1514@localhost">>},
{<<"to">>,
<<"alice_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1514@localhost/res1">>},
{<<"id">>,<<"3ed8664b-12f2-49b5-9886-675e00a1096d">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-info">>},
{<<"sid">>,<<"f99359c3-88f4-4e12-a2b2-2e84bfa292bc">>}],
[{xmlel,<<"ringing">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:apps:rtp:info:1">>}],
[]}]}]},
"<iq from='bob_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1514@localhost' to='alice_mongoose_returns_404_when_nto_authorized_user_tries_to_cancel_a_session_1514@localhost/res1' id='3ed8664b-12f2-49b5-9886-675e00a1096d' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-info' sid='f99359c3-88f4-4e12-a2b2-2e84bfa292bc'><ringing xmlns='urn:xmpp:jingle:apps:rtp:info:1'/></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
{line,38... dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b7e66fb muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b7e66fb |
The branch
refactoring/otp-24
was merged in last week so I update it inrebar.config
andrebar.lock
.