-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the DomainName type in GraphQL #3856
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 83.14% // Head: 83.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3856 +/- ##
==========================================
- Coverage 83.14% 83.12% -0.03%
==========================================
Files 535 535
Lines 34145 34145
==========================================
- Hits 28391 28383 -8
- Misses 5754 5762 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adc90b3
to
d7244e5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
d7244e5
to
b347b17
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b347b17
to
0125408
Compare
This comment was marked as outdated.
This comment was marked as outdated.
small_tests_24 / small_tests / a634845 small_tests_25 / small_tests / a634845 ldap_mnesia_24 / ldap_mnesia / a634845 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / a634845 ldap_mnesia_25 / ldap_mnesia / a634845 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / a634845 dynamic_domains_mysql_redis_25 / mysql_redis / a634845 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a634845 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / a634845 internal_mnesia_25 / internal_mnesia / a634845 pgsql_mnesia_24 / pgsql_mnesia / a634845 pgsql_mnesia_25 / pgsql_mnesia / a634845 mysql_redis_25 / mysql_redis / a634845 mssql_mnesia_25 / odbc_mssql_mnesia / a634845 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / a634845 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just wondering if we should also change types for the following endpoints:
domainsByHostType
- result type to[DomainName]
,SessionAdminQuery
,domainStats
.
In case of failure it would result in very long execution time. Pass the optional Check function to the inner loop.
Will do, I apparently made a mistake when grepping for items to change. |
a634845
to
63bf856
Compare
riak_mnesia_24 / riak_mnesia / 63bf856 small_tests_24 / small_tests / 63bf856 small_tests_25 / small_tests / 63bf856 ldap_mnesia_24 / ldap_mnesia / 63bf856 graphql_stats_SUITE:admin_stats_http:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 63bf856 ldap_mnesia_25 / ldap_mnesia / 63bf856 graphql_stats_SUITE:admin_stats_http:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 63bf856 dynamic_domains_mysql_redis_25 / mysql_redis / 63bf856 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 63bf856 muc_light_http_api_SUITE:end_per_suite{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_send_message_to_room_2540">>,
[{escalus_event_mgr,<0.11845.2>},
{tc_name,send_message_to_room},
{escalus_cleaner,<0.11844.2>},
{watchdog,<0.11843.2>},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/muc_light_http_api_SUITE_data"},
{preset,"odbc_mssql_mnesia"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3856/152776/odbc_mssql_mnesia.25.0.1/big/ct_run.test%4063b7f4a7df06.2022-11-17_17.48.24/big_tests.tests.muc_light_http_api_SUITE.logs/run.2022-11-17_18.01.43/muc_light_http_api_suite.send_message_to_room.190850.html"},
{tc_group_properties,[{name,positive},parallel]},
{tc_group_path,[]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/muc_light_http_api_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/3856/152776/odbc_mssql_mnesia.25.0.1/big/ct_run.test%4063b7f4a7df06.2022-11-17_17.48.24/big_tests.tests.muc_light_http_api_SUITE.logs/run.2022-11-17_18.01.43/log_private/"},
{{saved_modules,mongooseim@localhost,<<"test type">>},
#{mod_adhoc => #{iqdisc => one_queue,report_commands_node => false},
mod_amp => #{},
mod_bosh =>
#{backend => mnesia,inactivity => 30,max_pause => 120,
max_wait => infinity,server_acks => false},
mod_cache_users =>
#{number_of_segments => 5,strategy => fifo,time_to_live => 2},
mod_carboncopy => #{iqdisc => no_queue},
mod_disco =>
#{extra_domains => []... internal_mnesia_25 / internal_mnesia / 63bf856 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 63bf856 pgsql_mnesia_24 / pgsql_mnesia / 63bf856 pgsql_mnesia_25 / pgsql_mnesia / 63bf856 mysql_redis_25 / mysql_redis / 63bf856 mssql_mnesia_25 / odbc_mssql_mnesia / 63bf856 ldap_mnesia_25 / ldap_mnesia / 63bf856 graphql_stats_SUITE:admin_stats_http:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} ldap_mnesia_24 / ldap_mnesia / 63bf856 graphql_stats_SUITE:admin_stats_http:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_stats_SUITE:admin_stats_cli:admin_stats_domain_without_users_test{error,{{assertMatch,[{module,graphql_stats_SUITE},
{line,115},
{expression,"Result"},
{pattern,"# { << \"registeredUsers\" >> := 0 , << \"onlineUsers\" >> := 0 }"},
{value,#{<<"onlineUsers">> => 0,
<<"registeredUsers">> => 1}}]},
[{graphql_stats_SUITE,admin_stats_domain_without_users_test,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_stats_SUITE.erl"},
{line,115}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / 63bf856 |
63bf856
to
aa8bbb4
Compare
small_tests_24 / small_tests / aa8bbb4 small_tests_25 / small_tests / aa8bbb4 ldap_mnesia_24 / ldap_mnesia / aa8bbb4 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / aa8bbb4 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / aa8bbb4 ldap_mnesia_25 / ldap_mnesia / aa8bbb4 dynamic_domains_mysql_redis_25 / mysql_redis / aa8bbb4 pgsql_mnesia_24 / pgsql_mnesia / aa8bbb4 internal_mnesia_25 / internal_mnesia / aa8bbb4 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / aa8bbb4 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / aa8bbb4 riak_mnesia_24 / riak_mnesia / aa8bbb4 pgsql_mnesia_25 / pgsql_mnesia / aa8bbb4 mysql_redis_25 / mysql_redis / aa8bbb4 mssql_mnesia_25 / odbc_mssql_mnesia / aa8bbb4 |
Also: add a test verifying that the stats are counted only for the given domain, and not globally.
aa8bbb4
to
b2007a7
Compare
small_tests_24 / small_tests / b2007a7 small_tests_25 / small_tests / b2007a7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / b2007a7 ldap_mnesia_24 / ldap_mnesia / b2007a7 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b2007a7 dynamic_domains_mysql_redis_25 / mysql_redis / b2007a7 ldap_mnesia_25 / ldap_mnesia / b2007a7 internal_mnesia_25 / internal_mnesia / b2007a7 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / b2007a7 pgsql_mnesia_24 / pgsql_mnesia / b2007a7 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / b2007a7 riak_mnesia_24 / riak_mnesia / b2007a7 pgsql_mnesia_25 / pgsql_mnesia / b2007a7 mysql_redis_25 / mysql_redis / b2007a7 mssql_mnesia_25 / odbc_mssql_mnesia / b2007a7 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} mssql_mnesia_25 / odbc_mssql_mnesia / b2007a7 inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_fetch_ahead{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"bob_max_queries_can_fetch_ahead_1501@localhost/res1">>,
escalus_tcp,<0.8339.1>,
[{event_manager,<0.8329.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1501">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8329.1>},
{server,<<"localhost">>},
{username,<<"bOb_max_queries_can_fetch_ahead_1501">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"bob_max_queries_can_fetch_ahead_1501">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"bOb_max_queries_can_fetch_ahead_1501">>},
{server,<<"localhost">>},
{password,<<"makrolika">>},
{stream_id,<<"84b2cde14a1205fa">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl,3,[{file,"lists.erl"},{line,1350}]},
{inbox_extensions_SUITE,'-max_queries_can_fetch_ahead/1-fun-0-',4,
[{file,... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_forwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_forwards_1499@localhost/res1">>,
escalus_tcp,<0.8342.1>,
[{event_manager,<0.8315.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1499">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8315.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_forwards_1499">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_forwards_1499">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_forwards_1499">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"71e921ebd082bc76">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_forwards/1-fun-0-',4,
[{file,
"/home/circleci/project/big_t... inbox_extensions_SUITE:regular:one_to_one:pagination:max_queries_can_be_limited{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_max_queries_can_be_limited_1500@localhost/res1">>,
escalus_tcp,<0.8343.1>,
[{event_manager,<0.8322.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1500">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8322.1>},
{server,<<"localhost">>},
{username,<<"kate_max_queries_can_be_limited_1500">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_max_queries_can_be_limited_1500">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_max_queries_can_be_limited_1500">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"016f352f37bdb524">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-max_queries_can_be_limited/1-fun-0-',4,
[{file... inbox_extensions_SUITE:regular:one_to_one:pagination:pagination_overrides_form{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,
<<"kate_pagination_overrides_form_1496@localhost/res1">>,
escalus_tcp,<0.8341.1>,
[{event_manager,<0.8294.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1496">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8294.1>},
{server,<<"localhost">>},
{username,<<"kate_pagination_overrides_form_1496">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_pagination_overrides_form_1496">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_pagination_overrides_form_1496">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"abf905e9c68eae11">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-pagination_overrides_form/1-fun-0-',4,
[{file,
... inbox_extensions_SUITE:regular:one_to_one:pagination:can_paginate_backwards{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"kate_can_paginate_backwards_1498@localhost/res1">>,
escalus_tcp,<0.8345.1>,
[{event_manager,<0.8308.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1498">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.8308.1>},
{server,<<"localhost">>},
{username,<<"kate_can_paginate_backwards_1498">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"kate_can_paginate_backwards_1498">>},
{server,<<"localhost">>},
{host,<<"localhost">>},
{port,5222},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"kate_can_paginate_backwards_1498">>},
{server,<<"localhost">>},
{password,<<"makrowe;p">>},
{stream_id,<<"fa466722fc6f2921">>}]},
5000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{inbox_helper,'-given_conversations_between/2-fun-1-',4,
[{file,"/home/circleci/project/big_tests/tests/inbox_helper.erl"},
{line,543}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,1355}]},
{inbox_extensions_SUITE,'-can_paginate_backwards/1-fun-0-',4,
[{file,
"/home/circleci/project... mssql_mnesia_25 / odbc_mssql_mnesia / b2007a7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
God job 👍
The main goal is to use the
DomainName
instead ofString
for all fields containing XMPP doman names in the GraphQL schema. This ensures that the domain is string-prepped:@use
and@protected
directives.Appropriate tests are added with an "unprepped" domain, that starts with a capital letter.
Other changes
inbox_helper
contained nestedwait_until
calls, which resulted in an almost never-ending loop of retries in case of a permanent failure. The checking logic is flattened to a singlewait_until
now.