-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored hook handlers in mod_private #3865
Conversation
17eb0b1
to
cd28de6
Compare
small_tests_24 / small_tests / 17eb0b1 small_tests_25 / small_tests / 17eb0b1 ldap_mnesia_24 / ldap_mnesia / 17eb0b1 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 17eb0b1 ldap_mnesia_25 / ldap_mnesia / 17eb0b1 dynamic_domains_mysql_redis_25 / mysql_redis / 17eb0b1 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 17eb0b1 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 17eb0b1 internal_mnesia_25 / internal_mnesia / 17eb0b1 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 17eb0b1 riak_mnesia_24 / riak_mnesia / 17eb0b1 graphql_server_SUITE:admin_http:clustering_http_tests:remove_dead_from_cluster_http{error,
{{badrpc,
{'EXIT',
{#{cluster_member => mongooseim@localhost,
reason => set_extra_db_nodes_failed,
result => {ok,[]}},
[{mongoose_cluster,set_extra_db_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,132}]},
{mongoose_cluster,unsafe_join,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,116}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster_http,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,247}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} pgsql_mnesia_24 / pgsql_mnesia / 17eb0b1 pgsql_mnesia_25 / pgsql_mnesia / 17eb0b1 mysql_redis_25 / mysql_redis / 17eb0b1 mssql_mnesia_25 / odbc_mssql_mnesia / 17eb0b1 |
Codecov ReportBase: 82.77% // Head: 83.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3865 +/- ##
==========================================
+ Coverage 82.77% 83.11% +0.34%
==========================================
Files 535 535
Lines 34149 34147 -2
==========================================
+ Hits 28266 28382 +116
+ Misses 5883 5765 -118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
small_tests_24 / small_tests / cd28de6 small_tests_25 / small_tests / cd28de6 riak_mnesia_24 / riak_mnesia / cd28de6 graphql_server_SUITE:admin_http:clustering_http_tests:remove_dead_from_cluster_http{error,
{{badrpc,
{'EXIT',
{{badmatch,
{error,
{shutdown,
{gen_server,call,
[<8846.8410.1>,
{sync_dump_log,schema_prepare},
infinity]}}}},
[{mongoose_cluster,unsafe_join,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,118}]},
{mongoose_cluster,with_app_stopped,2,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim3@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster_http,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,247}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:admin_http:clustering_http_tests:remove_alive_from_cluster_http{error,
{{badrpc,
{'EXIT',
{#{cluster_member => mongooseim@localhost,
reason => set_extra_db_nodes_failed,
result =>
{error,
{merge_schema_failed,
"Incompatible schema cookies. Please, restart from old backup.mongooseim3@localhost = [{name,schema},{type,set},{ram_copies,[]},{disc_copies,[mongooseim3@localhost]},{disc_only_copies,[]},{load_order,0},{access_mode,read_write},{majority,false},{index,[]},{snmp,[]},{local_content,false},{record_name,schema},{attributes,[table,cstruct]},{user_properties,[]},{frag_properties,[]},{storage_properties,[]},{cookie,{{1669019176841103949,-576460752303392766,1},mongooseim3@localhost}},{version,{{3,0},{mongooseim3@localhost,{1669,19178,201171}}}}], mongooseim2@localhost = [{name,schema},{type,set},{ram_copies,[mongooseim3@localhost,mongooseim2@localhost]},{disc_copies,[mongooseim@localhost]},{disc_only_copies,[]},{load_order,0},{access_mode,read_write},{majority,false},{index,[]},{snmp,[]},{local_content,false},{record_name,schema},{attributes,[table,cstruct]},{user_properties,[]},{frag_properties,[]},{storage_properties,[]},{cookie,{{1669019171782072265,-576460752303241983,1},mongooseim@localhost}},{version,{{6,0},{mongooseim2@localhost,{1669,19179,581886}}}}]\n"}}},
[{mongoose_cluster,set_extra_db_nodes,1,
[{file,"/home/circleci/project/src/mongoose_cluster.erl"},
{line,132}]},
{mongoose_cluster,unsafe_join,2,
[{file,"/home/ci... graphql_server_SUITE:admin_cli:clustering_tests:join_successful{error,{{verify_result,[],
[{times,20,
[{#{node => mongooseim2@localhost},
[mongooseim@localhost],
true},
{#{node => mongooseim@localhost},
[mongooseim2@localhost],
true}]}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},
{distributed_helper,verify_result,2,
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,53}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:leave_successful{error,{#{expected_type => ok,
response_code => {exit_status,1},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,leave_successful,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,150}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:join_unsuccessful{error,
{{verify_result,[],
[{times,20,
{'EXIT',
{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
mnesia,system_info,
[running_db_nodes]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{distributed_helper,do_verify_result,2,
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,68}]},
{distributed_helper,'-verify_result/2-fun-0-',2,
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,53}]},
{mongoose_helper,do_wait_until,2,
[{file,
"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,374}]},
{distributed_helper,verify_result,2,
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,53}]},
{test_server,ts_tc,3,
[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}}]},
[{mongoose_helper,do_wait_until,2,
[{file,"/home/circleci/project/big_tests/tests/mongoose_helper.erl"},
{line,371}]},... graphql_server_SUITE:admin_cli:clustering_tests:leave_but_no_cluster{error,
{function_clause,
[{graphql_helper,get_error,
[1,
{{exit_status,3},
"Failed RPC connection to the node mongooseim@localhost: nodedown\n\nCommands to start a MongooseIM node:\n start Start a MongooseIM node as daemon (detached from terminal)\n debug Attach an interactive Erlang shell to a running MongooseIM node\n live Start MongooseIM node in live (interactive) mode\n foreground Start MongooseIM node in foreground (non-interactive) mode\nMongooseIM cluster management commands:\n join_cluster other_node_name Add current node to cluster\n leave_cluster Make the current node leave the cluster\n remove_from_cluster other_node_name Remove dead node from the cluster\nExtra Commands:\n bootstrap Executes MongooseIM init scripts (used for initial configuration)\n print_install_dir Prints path to MongooseIM release directory\n escript Runs escript command using embedded Erlang Runtime System\n\n"}],
[{file,
"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,229}]},
{graphql_helper,get_err_code,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,206}]},
{graphql_server_SUITE,leave_but_no_cluster,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,160}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},... graphql_server_SUITE:admin_cli:clustering_tests:join_twice{error,{#{expected_type => ok,
response_code => {exit_status,3},
what => invalid_response_code},
[{graphql_helper,assert_response_code,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,256}]},
{graphql_helper,get_ok_value,2,
[{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
{line,239}]},
{graphql_server_SUITE,join_twice,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,165}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_dead_from_cluster{error,
{{badrpc,
{'EXIT',
{pang,
[{mongoose_cluster,check_networking,
[mongooseim@localhost],
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,111}]},
{mongoose_cluster,'-do_join/1-fun-0-',1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,35}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_dead_from_cluster,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,175}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:admin_cli:clustering_tests:remove_alive_from_cluster{error,
{{badrpc,
{'EXIT',
{pang,
[{mongoose_cluster,check_networking,
[mongooseim@localhost],
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,111}]},
{mongoose_cluster,'-do_join/1-fun-0-',1,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,35}]},
{mongoose_cluster,with_app_stopped,2,
[{file,
"/home/circleci/project/src/mongoose_cluster.erl"},
{line,221}]},
{global,trans,4,[{file,"global.erl"},{line,463}]},
{mongoose_cluster,join,1,[]}]}}},
[{distributed_helper,rpc,
[#{node => mongooseim2@localhost,timeout => 60000},
mongoose_cluster,join,
[mongooseim@localhost]],
[{file,
"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{graphql_server_SUITE,remove_alive_from_cluster,1,
[{file,
"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,198}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} graphql_server_SUITE:end_per_suite{error,{{badrpc,nodedown},
[{distributed_helper,rpc,
[#{node => mongooseim@localhost},
gen_mod,loaded_modules_with_opts,
[<<"localhost">>]],
[{file,"/home/circleci/project/big_tests/tests/distributed_helper.erl"},
{line,121}]},
{dynamic_modules,restore_modules,3,
[{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
{line,50}]},
{dynamic_modules,'-restore_modules/2-lc$^0/1-0-',2,
[{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
{line,45}]},
{dynamic_modules,restore_modules,2,
[{file,"/home/circleci/project/big_tests/tests/dynamic_modules.erl"},
{line,46}]},
{graphql_server_SUITE,end_per_suite,1,
[{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
{line,76}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1380}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} ldap_mnesia_24 / ldap_mnesia / cd28de6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / cd28de6 service_domain_db_SUITE:db:db_keeps_syncing_after_cluster_join{error,{test_case_failed,{[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>],
[<<"example1.com">>,<<"example2.com">>,
<<"example3.com">>,<<"example4.com">>]}}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / cd28de6 ldap_mnesia_25 / ldap_mnesia / cd28de6 dynamic_domains_mysql_redis_25 / mysql_redis / cd28de6 internal_mnesia_25 / internal_mnesia / cd28de6 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / cd28de6 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / cd28de6 pgsql_mnesia_24 / pgsql_mnesia / cd28de6 pgsql_mnesia_25 / pgsql_mnesia / cd28de6 mysql_redis_25 / mysql_redis / cd28de6 mssql_mnesia_25 / odbc_mssql_mnesia / cd28de6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / cd28de6 riak_mnesia_24 / riak_mnesia / cd28de6 |
cd28de6
to
5498c57
Compare
5498c57
to
9cee7b5
Compare
small_tests_24 / small_tests / 9cee7b5 small_tests_25 / small_tests / 9cee7b5 ldap_mnesia_24 / ldap_mnesia / 9cee7b5 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 9cee7b5 ldap_mnesia_25 / ldap_mnesia / 9cee7b5 dynamic_domains_mysql_redis_25 / mysql_redis / 9cee7b5 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 9cee7b5 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 9cee7b5 internal_mnesia_25 / internal_mnesia / 9cee7b5 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 9cee7b5 pgsql_mnesia_24 / pgsql_mnesia / 9cee7b5 riak_mnesia_24 / riak_mnesia / 9cee7b5 mysql_redis_25 / mysql_redis / 9cee7b5 pgsql_mnesia_25 / pgsql_mnesia / 9cee7b5 mssql_mnesia_25 / odbc_mssql_mnesia / 9cee7b5 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2638@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2638@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"bWP6ScWqeTPs2xtXIq04vg==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} |
This PR changes all hook handlers in
mod_private
module togen_hook
format.