-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove domain/incremental db deletes #3889
Conversation
small_tests_24 / small_tests / 8e484f9 small_tests_25 / small_tests / 8e484f9 ldap_mnesia_24 / ldap_mnesia / 8e484f9 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 8e484f9 ldap_mnesia_25 / ldap_mnesia / 8e484f9 dynamic_domains_mysql_redis_25 / mysql_redis / 8e484f9 muc_SUITE:hibernation:hibernated_room_can_be_queried_for_archive{error,{{assertion_failed,assert,is_groupchat_message,
[<<"Restorable message">>],
undefined,"undefined"},
[{escalus_new_assert,assert_true,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{muc_SUITE,wait_for_mam_result,3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4394}]},
{muc_SUITE,'-hibernated_room_can_be_queried_for_archive/1-fun-0-',3,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4130}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{muc_SUITE,hibernated_room_can_be_queried_for_archive,1,
[{file,"/home/circleci/project/big_tests/tests/muc_SUITE.erl"},
{line,4126}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 8e484f9 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 8e484f9 internal_mnesia_25 / internal_mnesia / 8e484f9 pgsql_mnesia_24 / pgsql_mnesia / 8e484f9 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 8e484f9 riak_mnesia_24 / riak_mnesia / 8e484f9 mysql_redis_25 / mysql_redis / 8e484f9 pgsql_mnesia_25 / pgsql_mnesia / 8e484f9 mssql_mnesia_25 / odbc_mssql_mnesia / 8e484f9 dynamic_domains_mysql_redis_25 / mysql_redis / 8e484f9 |
Codecov ReportBase: 83.13% // Head: 83.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 535 535
Lines 34200 34203 +3
=======================================
+ Hits 28431 28434 +3
Misses 5769 5769
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR implements for inbox what was implemented already in #3777
Quoting and adapting to the inbox context, the current query, looking like:
DELETE FROM inbox WHERE domain = ?
is, while technically correct, surely going to fail because of timeouts, once it is actually removing any big data.
This PR introduces a configuration flag that allows to set a batch size, and then a delete work will commit only deleting that many records, and iterates until nothing more is deleted.