-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename c2s types as the module name already contains c2s #3908
Rename c2s types as the module name already contains c2s #3908
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## c2s/csi #3908 +/- ##
==========================================
Coverage ? 73.19%
==========================================
Files ? 540
Lines ? 34183
Branches ? 0
==========================================
Hits ? 25021
Misses ? 9162
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6b380a7
to
0031b71
Compare
small_tests_24 / small_tests / 0031b71 small_tests_25 / small_tests / 0031b71 ldap_mnesia_24 / ldap_mnesia / 0031b71 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0031b71 ldap_mnesia_25 / ldap_mnesia / 0031b71 pgsql_mnesia_24 / pgsql_mnesia / 0031b71 internal_mnesia_25 / internal_mnesia / 0031b71 riak_mnesia_24 / riak_mnesia / 0031b71 dynamic_domains_mysql_redis_25 / mysql_redis / 0031b71 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0031b71 elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0031b71 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0031b71 pgsql_mnesia_25 / pgsql_mnesia / 0031b71 mysql_redis_25 / mysql_redis / 0031b71 mssql_mnesia_25 / odbc_mssql_mnesia / 0031b71 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Simply rename the types,
mongoose_c2s:c2s_state()
contains duplicated information, we already know the type refers to c2s by its module name.