Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename c2s types as the module name already contains c2s #3908

Merged

Conversation

NelsonVides
Copy link
Collaborator

Simply rename the types, mongoose_c2s:c2s_state() contains duplicated information, we already know the type refers to c2s by its module name.

@mongoose-im

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

❗ No coverage uploaded for pull request base (c2s/csi@a356ac5). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 6b380a7 differs from pull request most recent head 0031b71. Consider uploading reports for the commit 0031b71 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             c2s/csi    #3908   +/-   ##
==========================================
  Coverage           ?   73.19%           
==========================================
  Files              ?      540           
  Lines              ?    34183           
  Branches           ?        0           
==========================================
  Hits               ?    25021           
  Misses             ?     9162           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NelsonVides NelsonVides force-pushed the c2s/rename_redundantly_named_types branch from 6b380a7 to 0031b71 Compare January 4, 2023 11:26
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jan 4, 2023

small_tests_24 / small_tests / 0031b71
Reports root / small


small_tests_25 / small_tests / 0031b71
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 0031b71
Reports root/ big
OK: 1745 / Failed: 0 / User-skipped: 797 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 0031b71
Reports root/ big
OK: 3879 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 0031b71
Reports root/ big
OK: 1745 / Failed: 0 / User-skipped: 797 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 0031b71
Reports root/ big
OK: 4055 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 0031b71
Reports root/ big
OK: 1897 / Failed: 0 / User-skipped: 645 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 0031b71
Reports root/ big
OK: 2087 / Failed: 0 / User-skipped: 624 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 0031b71
Reports root/ big
OK: 3853 / Failed: 0 / User-skipped: 104 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 0031b71
Reports root/ big
OK: 3879 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 0031b71
Reports root/ big
OK: 2249 / Failed: 0 / User-skipped: 632 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 0031b71
Reports root/ big
OK: 3879 / Failed: 0 / User-skipped: 78 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 0031b71
Reports root/ big
OK: 4055 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 0031b71
Reports root/ big
OK: 4041 / Failed: 0 / User-skipped: 103 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 0031b71
Reports root/ big
OK: 4055 / Failed: 0 / User-skipped: 89 / Auto-skipped: 0

Base automatically changed from c2s/csi to feature/mongoose_c2s January 4, 2023 12:47
@NelsonVides NelsonVides marked this pull request as ready for review January 4, 2023 12:48
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JanuszJakubiec JanuszJakubiec merged commit 025f2a7 into feature/mongoose_c2s Jan 4, 2023
@JanuszJakubiec JanuszJakubiec deleted the c2s/rename_redundantly_named_types branch January 4, 2023 12:54
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants