Update dependencies #3918

pawlooss1 · 2023-01-05T12:26:17Z

This PR updates all dependencies in the project and big_tests. Also, rebar3 is upgraded.

Changes I needed to made due to upgraded versions of libraries:

While generating config for big_tests when we want to enable some module we create a variable which is injected into template with bbmustache. In current version empty binary is considered falsey in conditions, so now when we want to enable module with no additional configuration we could inject a newline character.
Deleting users.csv.tmp file after running graphql_account_SUITE
Arguments for init function in redis_client module changed from list to proplist. Now we are creating them according to this.

codecov · 2023-01-05T12:36:51Z

Codecov Report

Base: 83.53% // Head: 83.54% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (687a772) compared to base (997ce8c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3918   +/-   ##
=======================================
  Coverage   83.53%   83.54%           
=======================================
  Files         538      538           
  Lines       34003    34003           
=======================================
+ Hits        28406    28407    +1     
+ Misses       5597     5596    -1

Impacted Files	Coverage Δ
src/mongoose_redis.erl	`87.50% <ø> (ø)`
src/wpool/mongoose_wpool_redis.erl	`100.00% <100.00%> (ø)`
src/domain/service_domain_db.erl	`83.33% <0.00%> (-2.09%)`	⬇️
src/pubsub/node_pep.erl	`77.77% <0.00%> (-1.86%)`	⬇️
src/ejabberd_sm_redis.erl	`94.64% <0.00%> (-1.79%)`	⬇️
src/inbox/mod_inbox_rdbms_async.erl	`70.58% <0.00%> (-1.48%)`	⬇️
src/mod_muc_log.erl	`63.08% <0.00%> (+0.26%)`	⬆️
src/rdbms/mongoose_rdbms.erl	`66.31% <0.00%> (+0.35%)`	⬆️
src/mongoose_tcp_listener.erl	`74.46% <0.00%> (+6.38%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

NelsonVides

rebar.lock files are not updated, changes to the versions in the rebar.config files are ignored, what rebar really applies is what's written on the lockfile. You need to run rebar3 upgrade --all and rebar will actually install the new versions and carefully update the lockfile automatically 🙂

mongoose-im · 2023-02-07T13:07:49Z

small_tests_24 / small_tests / e18c41f
Reports root / small

small_tests_25 / small_tests / e18c41f
Reports root / small

ldap_mnesia_24 / ldap_mnesia / e18c41f
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / e18c41f
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / e18c41f
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / e18c41f
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / e18c41f
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / e18c41f
Reports root/ big
OK: 4143 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / e18c41f
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / e18c41f
Reports root/ big
OK: 2739 / Failed: 1 / User-skipped: 662 / Auto-skipped: 0

pubsub_SUITE:dag+basic:publish_with_max_items_test

{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,491}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,481}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,471}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mysql_redis_25 / mysql_redis / e18c41f
Reports root/ big
OK: 4534 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

push_integration_SUITE:pubsub_less:pm_notifications_with_inbox:inbox_msg_reset_unread_count_fcm

{error,
  {{assertion_failed,assert_many,false,
     [is_presence,is_message,is_message],
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_inbox_msg_reset_unread_count_fcm_2777@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2777@localhost">>},
         {<<"type">>,<<"chat">>},
         {<<"id">>,<<"c4afb70960e8f87933474eac8b1b9a65">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"FIRST MESSAGE">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2023-02-07T13:18:12.365415Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"Offline Storage">>}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2777@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2777@localhost/res1">>}],
        []}],
     "   <message from='alice_inbox_msg_reset_unread_count_fcm_2777@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2777@localhost' type='chat' id='c4afb70960e8f87933474eac8b1b9a65'><body>FIRST MESSAGE</body><delay xmlns='urn:xmpp:delay' stamp='2023-02-07T13:18:12.365415Z' from='localhost'>Offline Storage</delay></message>   <presence from='bob_inbox_msg_reset_unread_count_fcm_2777@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2777@localhost/res1'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_buil...

Report log

pgsql_mnesia_25 / pgsql_mnesia / e18c41f
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / e18c41f
Reports root/ big
OK: 4543 / Failed: 3 / User-skipped: 100 / Auto-skipped: 0

mam_SUITE:rdbms_mnesia_prefs_cases:run_set_and_get_prefs_cases

{error,
  {thrown,
    {timeout,
      [{escalus_connection,receive_stanza,2,
         [{file,
            "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
          {line,303}]},
       {mam_helper,run_set_and_get_prefs_case,4,
         [{file,
            "/home/circleci/project/big_tests/tests/mam_helper.erl"},
          {line,1299}]},
       {mam_SUITE,'-run_set_and_get_prefs_cases/1-lc$^0/1-0-',4,
         [{file,
            "/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
          {line,3028}]},
       {escalus_story,story,4,
         [{file,
            "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
          {line,72}]},
       {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
       {test_server,run_test_case_eval1,6,
         [{file,"test_server.erl"},{line,1291}]},
       {test_server,run_test_case_eval,9,
         [{file,"test_server.erl"},{line,1223}]}]}}}

Report log

mam_SUITE:rdbms_mnesia_prefs_cases:messages_filtered_when_prefs_default_policy_is_never

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"bf9c6b1dab77af60b5a4f978fd7dae6c">>}],
        [{xmlel,<<"prefs">>,
           [{<<"xmlns">>,<<"urn:xmpp:mam:1">>},
          {<<"default">>,<<"never">>}],
           [{xmlel,<<"always">>,[],[]},{xmlel,<<"never">>,[],[]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"alice_messages_filtered_when_prefs_default_policy_is_never_1991@localhost">>},
        {<<"to">>,
         <<"alice_messages_filtered_when_prefs_default_policy_is_never_1991@localhost/res1">>},
        {<<"id">>,<<"push1fe21e38b59cd798">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:roster">>}],
          [{xmlel,<<"item">>,
             [{<<"subscription">>,<<"both">>},
            {<<"jid">>,
             <<"bob_messages_filtered_when_prefs_default_policy_is_never_1991@localhost">>}],
             []}]}]},
     "<iq from='alice_messages_filtered_when_prefs_default_policy_is_never_1991@localhost' to='alice_messages_filtered_when_prefs_default_policy_is_never_1991@localhost/res1' id='push1fe21e38b59cd798' type='set'><query xmlns='jabber:iq:roster'><item subscription='both' jid='bob_messages_filtered_when_prefs_default_policy_is_never_1991@localhost'/></query></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
  ...

Report log

mam_SUITE:rdbms_mnesia_prefs_cases:messages_filtered_when_prefs_default_policy_is_always

{error,
  {{assertion_failed,assert,is_iq_result,
     [{xmlel,<<"iq">>,
        [{<<"type">>,<<"set">>},
         {<<"id">>,<<"9ad5731c8921c5d17bbe1c96cf2a347e">>}],
        [{xmlel,<<"prefs">>,
           [{<<"xmlns">>,<<"urn:xmpp:mam:1">>},
          {<<"default">>,<<"always">>}],
           [{xmlel,<<"always">>,[],[]},{xmlel,<<"never">>,[],[]}]}]}],
     {xmlel,<<"iq">>,
       [{<<"from">>,
         <<"alice_messages_filtered_when_prefs_default_policy_is_always_1986@localhost">>},
        {<<"to">>,
         <<"alice_messages_filtered_when_prefs_default_policy_is_always_1986@localhost/res1">>},
        {<<"id">>,<<"push9f674d1f6a58e544">>},
        {<<"type">>,<<"set">>}],
       [{xmlel,<<"query">>,
          [{<<"xmlns">>,<<"jabber:iq:roster">>}],
          [{xmlel,<<"item">>,
             [{<<"subscription">>,<<"both">>},
            {<<"jid">>,
             <<"bob_messages_filtered_when_prefs_default_policy_is_always_1986@localhost">>}],
             []}]}]},
     "<iq from='alice_messages_filtered_when_prefs_default_policy_is_always_1986@localhost' to='alice_messages_filtered_when_prefs_default_policy_is_always_1986@localhost/res1' id='push9f674d1f6a58e544' type='set'><query xmlns='jabber:iq:roster'><item subscription='both' jid='bob_messages_filtered_when_prefs_default_policy_is_always_1986@localhost'/></query></iq>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.er...

Report log

riak_mnesia_24 / riak_mnesia / e18c41f
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / e18c41f
Reports root/ big
OK: 4534 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

push_integration_SUITE:pubsub_less:pm_notifications_with_inbox:inbox_msg_reset_unread_count_fcm

{error,
  {{assertion_failed,assert_many,false,
     [is_presence,is_message,is_message],
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_inbox_msg_reset_unread_count_fcm_2790@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2790@localhost">>},
         {<<"type">>,<<"chat">>},
         {<<"id">>,<<"f802823a00854d37e56bc85dbf583ac8">>}],
        [{xmlel,<<"body">>,[],[{xmlcdata,<<"FIRST MESSAGE">>}]},
         {xmlel,<<"delay">>,
           [{<<"xmlns">>,<<"urn:xmpp:delay">>},
          {<<"stamp">>,<<"2023-02-08T09:34:41.246524Z">>},
          {<<"from">>,<<"localhost">>}],
           [{xmlcdata,<<"Offline Storage">>}]}]},
      {xmlel,<<"presence">>,
        [{<<"from">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2790@localhost/res1">>},
         {<<"to">>,
        <<"bob_inbox_msg_reset_unread_count_fcm_2790@localhost/res1">>}],
        []}],
     "   <message from='alice_inbox_msg_reset_unread_count_fcm_2790@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2790@localhost' type='chat' id='f802823a00854d37e56bc85dbf583ac8'><body>FIRST MESSAGE</body><delay xmlns='urn:xmpp:delay' stamp='2023-02-08T09:34:41.246524Z' from='localhost'>Offline Storage</delay></message>   <presence from='bob_inbox_msg_reset_unread_count_fcm_2790@localhost/res1' to='bob_inbox_msg_reset_unread_count_fcm_2790@localhost/res1'/>"},
   [{escalus_new_assert,assert_true,2,
      [{file,
         "/home/circleci/project/big_tests/_buil...

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / e18c41f
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / e18c41f
Reports root/ big
OK: 4535 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

chrzaszcz

Looks good. My only concern is https://github.com/esl/MongooseIM/blob/master/tools/test_runner/apply_templates.erl#L37

Does this line suffer from the same empty binary issue? It won't be caught by CI, because it is only used when you run tests locally with test-runner.sh

pawlooss1 · 2023-02-09T10:15:21Z

Looks good. My only concern is https://github.com/esl/MongooseIM/blob/master/tools/test_runner/apply_templates.erl#L37

Does this line suffer from the same empty binary issue? It won't be caught by CI, because it is only used when you run tests locally with test-runner.sh

I double-checked it and surprisingly when I add a similar line to this code tests fail because the nodes can't start. In this case such code is probably breaking the config. Without it all big_tests pass when run locally.

NelsonVides

Just a tiny little comment, same applies to both rebar.config files 😬

big_tests/rebar.config

mongoose-im · 2023-02-09T13:07:19Z

small_tests_24 / small_tests / 687a772
Reports root / small

small_tests_25 / small_tests / 687a772
Reports root / small

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 687a772
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 687a772
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 687a772
Reports root/ big
OK: 4169 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0

ldap_mnesia_25 / ldap_mnesia / 687a772
Reports root/ big
OK: 2219 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 687a772
Reports root/ big
OK: 4143 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 687a772
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 687a772
Reports root/ big
OK: 4166 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0

internal_mnesia_25 / internal_mnesia / 687a772
Reports root/ big
OK: 2361 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0

riak_mnesia_24 / riak_mnesia / 687a772
Reports root/ big
OK: 2559 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 687a772
Reports root/ big
OK: 2721 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 687a772
Reports root/ big
OK: 4549 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 687a772
Reports root/ big
OK: 4534 / Failed: 1 / User-skipped: 111 / Auto-skipped: 0

graphql_session_SUITE:admin_session:admin_session_cli:admin_kick_user_session

{error,
  {function_clause,
    [{graphql_helper,get_error,
       [1,
        {{<<"200">>,<<"OK">>},
         #{<<"data">> =>
           #{<<"session">> =>
               #{<<"kickUserSession">> =>
                 #{<<"code">> => null,
                   <<"jid">> =>
                     <<"alice_admin_kick_user_session_1170@localhost/res1">>,
                   <<"kicked">> => true,
                   <<"message">> => <<"Session kicked">>}}}}}],
       []},
     {graphql_helper,get_err_msg,2,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_helper.erl"},
        {line,227}]},
     {graphql_session_SUITE,admin_kick_user_session_story,3,
       [{file,
          "/home/circleci/project/big_tests/tests/graphql_session_SUITE.erl"},
        {line,441}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1291}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1223}]}]}}

Report log

mssql_mnesia_25 / odbc_mssql_mnesia / 687a772
Reports root/ big
OK: 4546 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 687a772
Reports root/ big
OK: 4535 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0

NelsonVides

LGTM 👌🏽

pawlooss1 force-pushed the update-deps branch from 4b860f5 to 21f1425 Compare January 5, 2023 12:28