Implement mod_pubsub_db without dynamic modules MIM-1801 #3953
Conversation
|
small_tests_24 / small_tests / c452d67 small_tests_25 / small_tests / c452d67 ldap_mnesia_24 / ldap_mnesia / c452d67 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / c452d67 ldap_mnesia_25 / ldap_mnesia / c452d67 dynamic_domains_mysql_redis_25 / mysql_redis / c452d67 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c452d67 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / c452d67 internal_mnesia_25 / internal_mnesia / c452d67 pgsql_mnesia_24 / pgsql_mnesia / c452d67 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_2725@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_2725@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"8t/aE+jvoSj0gLWgzBEoDw==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pep_SUITE.erl"},
{line,384}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}}elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / c452d67 riak_mnesia_24 / riak_mnesia / c452d67 mysql_redis_25 / mysql_redis / c452d67 pgsql_mnesia_25 / pgsql_mnesia / c452d67 mssql_mnesia_25 / odbc_mssql_mnesia / c452d67 |
arcusfelis
force-pushed
the
mu-pubsub-without-dyn-mods
branch
from
c452d67 to
931d39d
Compare
Codecov ReportBase: 83.17% // Head: 83.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3953 +/- ##
==========================================
+ Coverage 83.17% 83.20% +0.02%
==========================================
Files 534 534
Lines 34118 34168 +50
==========================================
+ Hits 28377 28428 +51
+ Misses 5741 5740 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
small_tests_24 / small_tests / 931d39d small_tests_25 / small_tests / 931d39d dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 931d39d ldap_mnesia_24 / ldap_mnesia / 931d39d dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 931d39d ldap_mnesia_25 / ldap_mnesia / 931d39d dynamic_domains_mysql_redis_25 / mysql_redis / 931d39d internal_mnesia_25 / internal_mnesia / 931d39d dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 931d39d pgsql_mnesia_24 / pgsql_mnesia / 931d39d elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 931d39d riak_mnesia_24 / riak_mnesia / 931d39d mysql_redis_25 / mysql_redis / 931d39d pgsql_mnesia_25 / pgsql_mnesia / 931d39d mssql_mnesia_25 / odbc_mssql_mnesia / 931d39d |
rebar.config
Outdated
| @@ -209,7 +209,7 @@ | |||
|
|
|||
| {dialyzer, [ | |||
| %% Disabled till mod_pubsub is converted to dynamic domains style | |||
src/pubsub/mod_pubsub_db_backend.erl
Outdated
| init(HostType, Opts) -> | ||
| TrackedFuns = [create_node, del_node, get_state, get_states, | ||
| get_states_by_lus, get_states_by_bare, | ||
| get_states_by_full, get_own_nodes_states, |
There was a problem hiding this comment.
These two functions don't exist, could you double-check them all?
Remove backend_module
arcusfelis
force-pushed
the
mu-pubsub-without-dyn-mods
branch
from
931d39d to
49ade5b
Compare
|
small_tests_24 / small_tests / 49ade5b small_tests_25 / small_tests / 49ade5b dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 49ade5b ldap_mnesia_24 / ldap_mnesia / 49ade5b dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 49ade5b dynamic_domains_mysql_redis_25 / mysql_redis / 49ade5b ldap_mnesia_25 / ldap_mnesia / 49ade5b pgsql_mnesia_24 / pgsql_mnesia / 49ade5b internal_mnesia_25 / internal_mnesia / 49ade5b dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 49ade5b elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 49ade5b riak_mnesia_24 / riak_mnesia / 49ade5b pgsql_mnesia_25 / pgsql_mnesia / 49ade5b mysql_redis_25 / mysql_redis / 49ade5b mssql_mnesia_25 / odbc_mssql_mnesia / 49ade5b |
|
small_tests_24 / small_tests / ef5735f small_tests_25 / small_tests / ef5735f dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ef5735f ldap_mnesia_24 / ldap_mnesia / ef5735f ldap_mnesia_25 / ldap_mnesia / ef5735f dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ef5735f dynamic_domains_mysql_redis_25 / mysql_redis / ef5735f internal_mnesia_25 / internal_mnesia / ef5735f pgsql_mnesia_24 / pgsql_mnesia / ef5735f dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ef5735f elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ef5735f riak_mnesia_24 / riak_mnesia / ef5735f pgsql_mnesia_25 / pgsql_mnesia / ef5735f mssql_mnesia_25 / odbc_mssql_mnesia / ef5735f mysql_redis_25 / mysql_redis / ef5735f |
This PR addresses MIM-1801
Proposed changes include:
{warnings, [unknown]}check