Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason to batch worker when it terminates with pending flush #3985

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e161c12) 83.52% compared to head (68fc0c9) 83.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
- Coverage   83.52%   83.51%   -0.01%     
==========================================
  Files         538      538              
  Lines       33980    33981       +1     
==========================================
- Hits        28382    28380       -2     
- Misses       5598     5601       +3     
Impacted Files Coverage Δ
src/async_pools/mongoose_batch_worker.erl 64.81% <0.00%> (-1.23%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 12, 2023

small_tests_24 / small_tests / 68fc0c9
Reports root / small


small_tests_25 / small_tests / 68fc0c9
Reports root / small


ldap_mnesia_24 / ldap_mnesia / 68fc0c9
Reports root/ big
OK: 2226 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 68fc0c9
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 68fc0c9
Reports root/ big
OK: 4178 / Failed: 0 / User-skipped: 88 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / 68fc0c9
Reports root/ big
OK: 2226 / Failed: 0 / User-skipped: 825 / Auto-skipped: 0


dynamic_domains_mysql_redis_25 / mysql_redis / 68fc0c9
Reports root/ big
OK: 4152 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_mnesia_24 / pgsql_mnesia / 68fc0c9
Reports root/ big
OK: 4558 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 68fc0c9
Reports root/ big
OK: 4175 / Failed: 0 / User-skipped: 91 / Auto-skipped: 0


internal_mnesia_25 / internal_mnesia / 68fc0c9
Reports root/ big
OK: 2368 / Failed: 0 / User-skipped: 683 / Auto-skipped: 0


riak_mnesia_24 / riak_mnesia / 68fc0c9
Reports root/ big
OK: 2566 / Failed: 0 / User-skipped: 654 / Auto-skipped: 0


elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 68fc0c9
Reports root/ big
OK: 2728 / Failed: 0 / User-skipped: 662 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 68fc0c9
Reports root/ big
OK: 4558 / Failed: 0 / User-skipped: 97 / Auto-skipped: 0


mysql_redis_25 / mysql_redis / 68fc0c9
Reports root/ big
OK: 4544 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


mssql_mnesia_25 / odbc_mssql_mnesia / 68fc0c9
Reports root/ big
OK: 4555 / Failed: 0 / User-skipped: 100 / Auto-skipped: 0

@NelsonVides NelsonVides marked this pull request as ready for review March 13, 2023 08:08
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chrzaszcz chrzaszcz merged commit 18fd129 into master Mar 13, 2023
@chrzaszcz chrzaszcz deleted the add_reason_to_batch_worker_termination branch March 13, 2023 08:42
@jacekwegr jacekwegr added this to the 6.1.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants