Config in one persistent term #4093
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4093 +/- ##
==========================================
+ Coverage 83.88% 83.92% +0.03%
==========================================
Files 551 551
Lines 33594 33583 -11
==========================================
+ Hits 28180 28184 +4
+ Misses 5414 5399 -15
☔ View full report in Codecov by Sentry. |
chrzaszcz
force-pushed
the
config-in-one-term
branch
from
434a263 to
55da7c8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
config-in-one-term
branch
from
55da7c8 to
94ecf32
Compare
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
config-in-one-term
branch
from
94ecf32 to
7513cb7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Motivation: - Performance: adding Nth term has O(N) complexity - Simplicity: no need to store and expose config state - Consistency: top-level options are accessed the same way as nested ones Getters for config states from the cluster are removed, because: - Config module is responsible only for the local config (SoC) - There is no "config state" anymore - you can just get the persistent term - The code was a leftover from the legacy config
- Set the whole config at once - Erase the whole config Also - Add some options that were not needed only because of incomplete cleanup of previous tests
chrzaszcz
force-pushed
the
config-in-one-term
branch
from
7513cb7 to
6b846c6
Compare
|
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 6b846c6 small_tests_24 / small_tests / 6b846c6 small_tests_25 / small_tests / 6b846c6 small_tests_25_arm64 / small_tests / 6b846c6 ldap_mnesia_24 / ldap_mnesia / 6b846c6 ldap_mnesia_25 / ldap_mnesia / 6b846c6 dynamic_domains_mysql_redis_25 / mysql_redis / 6b846c6 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 6b846c6 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6b846c6 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 6b846c6 internal_mnesia_25 / internal_mnesia / 6b846c6 mysql_redis_25 / mysql_redis / 6b846c6 pgsql_mnesia_24 / pgsql_mnesia / 6b846c6 pgsql_cets_25 / pgsql_cets / 6b846c6 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_565@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_565@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_565@localhost/res1">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_565@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv...mssql_mnesia_25 / odbc_mssql_mnesia / 6b846c6 pgsql_mnesia_25 / pgsql_mnesia / 6b846c6 pgsql_cets_25 / pgsql_cets / 6b846c6 |
Put the whole config in one persistent term.
Motivation: