-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for when a bad resource is provided #4107
Conversation
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / d7a88d7 small_tests_24 / small_tests / d7a88d7 small_tests_25 / small_tests / d7a88d7 small_tests_25_arm64 / small_tests / d7a88d7 ldap_mnesia_24 / ldap_mnesia / d7a88d7 dynamic_domains_mysql_redis_25 / mysql_redis / d7a88d7 dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / d7a88d7 ldap_mnesia_25 / ldap_mnesia / d7a88d7 pubsub_SUITE:tree+basic:create_delete_node_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1291}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1223}]}]}} dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d7a88d7 dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / d7a88d7 internal_mnesia_25 / internal_mnesia / d7a88d7 pgsql_cets_25 / pgsql_cets / d7a88d7 mysql_redis_25 / mysql_redis / d7a88d7 pgsql_mnesia_25 / pgsql_mnesia / d7a88d7 mssql_mnesia_25 / odbc_mssql_mnesia / d7a88d7 pgsql_mnesia_24 / pgsql_mnesia / d7a88d7 ldap_mnesia_25 / ldap_mnesia / d7a88d7 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4107 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 551 551
Lines 33589 33589
=======================================
+ Hits 28192 28193 +1
+ Misses 5397 5396 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Simply increasing test coverage for a case that wasn't covered: https://app.codecov.io/gh/esl/MongooseIM/blob/master/src%2Fc2s%2Fmongoose_c2s.erl#L469