Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle the case when TLS is disabled #4150

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Correctly handle the case when TLS is disabled #4150

merged 5 commits into from
Oct 16, 2023

Commits on Oct 13, 2023

  1. Add tests for STARTTLS 

    - When STARTTLS is disabled, no features should be advertised,
  and TLS upgrade should be rejected
- STARTTLS features should be correctly advertised before and after
  performing the TLS upgrade

Also: reorganize tests, making group and test names more intuitive

testf
    @chrzaszcz
    chrzaszcz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    53932f9 View commit details
    Browse the repository at this point in the history

  2. Parallelize more tests in connect_SUITE

    @chrzaszcz
    chrzaszcz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7a085cb View commit details
    Browse the repository at this point in the history

  3. Advertise STARTTLS only when enabled (no TLS section = disabled)

    @chrzaszcz
    chrzaszcz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    0c4cc3e View commit details
    Browse the repository at this point in the history

  4. Do not accept STARTTLS if it is disabled 

    Previously STARTTLS would be attempted, resulting in a crash.
Now the result is a failure, as defined in RFC 6120, section 5.4.2.2
    @chrzaszcz
    chrzaszcz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    37706b5 View commit details
    Browse the repository at this point in the history

  5. Make docs for TLS more obvious

    @chrzaszcz
    chrzaszcz committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ebe60bb View commit details
    Browse the repository at this point in the history