Add new helper function to enable cets/mnesia in big_tests #4155
Conversation
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 67bb910 small_tests_25 / small_tests / 67bb910 small_tests_26 / small_tests / 67bb910 small_tests_26_arm64 / small_tests / 67bb910 ldap_mnesia_25 / ldap_mnesia / 67bb910 ldap_mnesia_26 / ldap_mnesia / 67bb910 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 67bb910 dynamic_domains_mysql_redis_26 / mysql_redis / 67bb910 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 67bb910 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 67bb910 internal_mnesia_26 / internal_mnesia / 67bb910 s2s_SUITE:node1_tls_optional_node2_tls_required:simple_message{error,
{timeout_when_waiting_for_stanza,
[{escalus_client,wait_for_stanza,
[{client,<<"alice_simple_message_2001@fed1/res1">>,escalus_tcp,
<0.57580.0>,
[{event_manager,<0.57576.0>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_2001">>},
{resource,<<"res1">>}],
[{event_client,
[{event_manager,<0.57576.0>},
{server,<<"fed1">>},
{username,<<"alice_simple_message_2001">>},
{resource,<<"res1">>}]},
{resource,<<"res1">>},
{username,<<"alice_simple_message_2001">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{auth,{escalus_auth,auth_plain}},
{wspath,undefined},
{username,<<"alice_simple_message_2001">>},
{server,<<"fed1">>},
{host,<<"localhost">>},
{port,5242},
{password,<<"makota2">>},
{stream_id,<<"d754bd6424b5f47f">>}]},
10000],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
{line,136}]},
{s2s_SUITE,'-simple_message/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/s2s_SUITE.erl"},
{line,138}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{f...pgsql_mnesia_25 / pgsql_mnesia / 67bb910 pgsql_mnesia_26 / pgsql_mnesia / 67bb910 mysql_redis_26 / mysql_redis / 67bb910 mssql_mnesia_26 / odbc_mssql_mnesia / 67bb910 internal_mnesia_26 / internal_mnesia / 67bb910 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4155 +/- ##
=======================================
Coverage 84.04% 84.04%
=======================================
Files 564 564
Lines 34050 34050
=======================================
+ Hits 28618 28619 +1
+ Misses 5432 5431 -1 ☔ View full report in Codecov by Sentry. |
pawlooss1
force-pushed
the
fix-rerun-tests
branch
from
67bb910 to
ae21542
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / ae21542 small_tests_25 / small_tests / ae21542 small_tests_26_arm64 / small_tests / ae21542 small_tests_26 / small_tests / ae21542 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ae21542 ldap_mnesia_25 / ldap_mnesia / ae21542 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / ae21542 ldap_mnesia_26 / ldap_mnesia / ae21542 dynamic_domains_mysql_redis_26 / mysql_redis / ae21542 internal_mnesia_26 / internal_mnesia / ae21542 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / ae21542 pgsql_mnesia_25 / pgsql_mnesia / ae21542 pgsql_cets_26 / pgsql_cets / ae21542 mysql_redis_26 / mysql_redis / ae21542 mssql_mnesia_26 / odbc_mssql_mnesia / ae21542 pgsql_mnesia_26 / pgsql_mnesia / ae21542 |
pawlooss1
changed the title
| @@ -246,9 +246,6 @@ | |||
| {component_backend, "\"cets\""}, | |||
| {s2s_backend, "\"cets\""}, | |||
| {stream_management_backend, cets}, | |||
| {muc_online_backend, cets}, | |||
There was a problem hiding this comment.
There are a few more options to clean up here, and they are unused. This can be done separately.
This PR addresses MIM-2081.
It introduces new helper function
ct_helper:get_internal_database/0and replaces callsct_helper:get_preset_var(Config, keystore_backend, mnesia)}with it. New function does not depend on test config but on configuration of MIM nodes under tests. Former approach was not developer friendly, i.e. it didn't work while:--rerun-big-testsoption oftest-runner.shmake quicktestmake consoleAlso, I fixed existing
ct_helper:get_preset_var/3implementation - 2nd clause ofcaseinstruction could never match, so instead of returningDefaultit raised anbad_argerror duringlist_to_existing_atom/1call.