Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coverage report for eunit #4167

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Enable coverage report for eunit #4167

merged 1 commit into from
Nov 14, 2023

Conversation

chrzaszcz
Copy link
Member

@chrzaszcz chrzaszcz commented Nov 13, 2023

Coverage was not reported for eunit, resulting in false reports for uncovered lines.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Nov 13, 2023

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 6c56562
Reports root/ big
OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0


small_tests_25 / small_tests / 6c56562
Reports root / small


small_tests_26 / small_tests / 6c56562
Reports root / small


small_tests_26_arm64 / small_tests / 6c56562
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 6c56562
Reports root/ big
OK: 2310 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 6c56562
Reports root/ big
OK: 4243 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 6c56562
Reports root/ big
OK: 2310 / Failed: 0 / User-skipped: 865 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6c56562
Reports root/ big
OK: 4275 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 6c56562
Reports root/ big
OK: 4275 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 6c56562
Reports root/ big
OK: 4272 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 6c56562
Reports root/ big
OK: 2460 / Failed: 0 / User-skipped: 715 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 6c56562
Reports root/ big
OK: 4664 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 6c56562
Reports root/ big
OK: 4662 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 6c56562
Reports root/ big
OK: 4644 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 6c56562
Reports root/ big
OK: 4664 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 6c56562
Reports root/ big
OK: 4661 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c618b6) 84.04% compared to head (6c56562) 84.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4167      +/-   ##
==========================================
+ Coverage   84.04%   84.08%   +0.04%     
==========================================
  Files         564      564              
  Lines       34067    34067              
==========================================
+ Hits        28630    28644      +14     
+ Misses       5437     5423      -14     

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review November 14, 2023 07:10
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@arcusfelis arcusfelis merged commit fc6ce64 into master Nov 14, 2023
4 checks passed
@arcusfelis arcusfelis deleted the eunit-coverage branch November 14, 2023 08:27
@chrzaszcz chrzaszcz added this to the 6.2.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants