-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename db and node to mongooseim #4172
Conversation
ca18847
to
d18a4d7
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d18a4d7 small_tests_25 / small_tests / d18a4d7 small_tests_26 / small_tests / d18a4d7 small_tests_26_arm64 / small_tests / d18a4d7 ldap_mnesia_25 / ldap_mnesia / d18a4d7 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d18a4d7 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d18a4d7 ldap_mnesia_26 / ldap_mnesia / d18a4d7 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d18a4d7 internal_mnesia_26 / internal_mnesia / d18a4d7 pgsql_cets_26 / pgsql_cets / d18a4d7 bosh_SUITE:essential_https:accept_higher_hold_value{error,
{{assertEqual,
[{module,bosh_SUITE},
{line,260},
{expression,"get_bosh_sessions ( )"},
{expected,[]},
{value,
[{bosh_session,<<"a545f310b0fac77231bd7082bf5596180f9a6ddc">>,
<10240.11315.0>}]}]},
[{bosh_SUITE,accept_higher_hold_value,1,
[{file,"/home/circleci/project/big_tests/tests/bosh_SUITE.erl"},
{line,260}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}} pgsql_mnesia_25 / pgsql_mnesia / d18a4d7 pgsql_mnesia_26 / pgsql_mnesia / d18a4d7 mysql_redis_26 / mysql_redis / d18a4d7 mssql_mnesia_26 / odbc_mssql_mnesia / d18a4d7 pgsql_cets_26 / pgsql_cets / d18a4d7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4172 +/- ##
==========================================
+ Coverage 84.05% 84.07% +0.02%
==========================================
Files 564 564
Lines 34064 34064
==========================================
+ Hits 28633 28640 +7
+ Misses 5431 5424 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
MIM-2013
We are using the name ejabberd for user name and password. Change it to mongooseim for ease of use, consistency, and to share tools like setup-db.sh without referencing ejabberd.
Change it also in CI scripts. Cleanup ejabberd2 nodename. It appears in two places. Add note to docs that it is possible to setup the database using script tools/setup-db.sh