-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase idle_timeout for SSE connections #4196
Conversation
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 6584477 small_tests_25 / small_tests / 6584477 small_tests_26 / small_tests / 6584477 small_tests_26_arm64 / small_tests / 6584477 ldap_mnesia_25 / ldap_mnesia / 6584477 ldap_mnesia_26 / ldap_mnesia / 6584477 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 6584477 dynamic_domains_mysql_redis_26 / mysql_redis / 6584477 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 6584477 internal_mnesia_26 / internal_mnesia / 6584477 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 6584477 pgsql_cets_26 / pgsql_cets / 6584477 pgsql_mnesia_25 / pgsql_mnesia / 6584477 pgsql_mnesia_26 / pgsql_mnesia / 6584477 mysql_redis_26 / mysql_redis / 6584477 mssql_mnesia_26 / odbc_mssql_mnesia / 6584477 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4196 +/- ##
==========================================
+ Coverage 84.24% 84.29% +0.04%
==========================================
Files 551 551
Lines 33473 33475 +2
==========================================
+ Hits 28201 28218 +17
+ Misses 5272 5257 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see that there is an easy option to change. I added some comments.
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d7e12b6 small_tests_25 / small_tests / d7e12b6 small_tests_26 / small_tests / d7e12b6 small_tests_26_arm64 / small_tests / d7e12b6 ldap_mnesia_26 / ldap_mnesia / d7e12b6 ldap_mnesia_25 / ldap_mnesia / d7e12b6 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d7e12b6 dynamic_domains_mysql_redis_26 / mysql_redis / d7e12b6 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d7e12b6 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d7e12b6 internal_mnesia_26 / internal_mnesia / d7e12b6 pgsql_cets_26 / pgsql_cets / d7e12b6 pgsql_mnesia_25 / pgsql_mnesia / d7e12b6 mysql_redis_26 / mysql_redis / d7e12b6 pgsql_mnesia_26 / pgsql_mnesia / d7e12b6 mssql_mnesia_26 / odbc_mssql_mnesia / d7e12b6 |
d7e12b6
to
440c8cc
Compare
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 440c8cc small_tests_25 / small_tests / 440c8cc small_tests_26 / small_tests / 440c8cc small_tests_26_arm64 / small_tests / 440c8cc ldap_mnesia_25 / ldap_mnesia / 440c8cc ldap_mnesia_26 / ldap_mnesia / 440c8cc dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 440c8cc dynamic_domains_mysql_redis_26 / mysql_redis / 440c8cc dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 440c8cc pgsql_cets_26 / pgsql_cets / 440c8cc internal_mnesia_26 / internal_mnesia / 440c8cc dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 440c8cc pgsql_mnesia_25 / pgsql_mnesia / 440c8cc pgsql_mnesia_26 / pgsql_mnesia / 440c8cc mysql_redis_26 / mysql_redis / 440c8cc mssql_mnesia_26 / odbc_mssql_mnesia / 440c8cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added a few minor comments.
Co-authored-by: Paweł Chrząszcz <pawel.chrzaszcz@erlang-solutions.com>
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / b2ad71e small_tests_25 / small_tests / b2ad71e small_tests_26 / small_tests / b2ad71e small_tests_26_arm64 / small_tests / b2ad71e ldap_mnesia_25 / ldap_mnesia / b2ad71e dynamic_domains_mysql_redis_26 / mysql_redis / b2ad71e ldap_mnesia_26 / ldap_mnesia / b2ad71e dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / b2ad71e dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / b2ad71e dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / b2ad71e internal_mnesia_26 / internal_mnesia / b2ad71e pgsql_mnesia_25 / pgsql_mnesia / b2ad71e pgsql_cets_26 / pgsql_cets / b2ad71e mysql_redis_26 / mysql_redis / b2ad71e mssql_mnesia_26 / odbc_mssql_mnesia / b2ad71e graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,3},
{unregistered_items,
[{{<<"_admin_change_room_config_errors_1109">>,
[{escalus_event_mgr,<0.25057.0>},
{tc_name,admin_change_room_config_errors},
{escalus_cleaner,<0.25056.0>},
{watchdog,<0.25055.0>},
{muc_light_host,<<"muclight.localhost">>},
{secondary_muc_light_host,<<"muclight.localhost.bis">>},
{protocol,http},
{domain_admin,{<<"admin@localhost">>,<<"6cccac45695afbd0">>}},
{schema_endpoint,domain_admin},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4196/205108/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40ccc28f7e7cf8.2024-01-05_10.53.58/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-05_10.58.19/graphql_muc_light_suite.admin_change_room_config_errors.16773.html"},
{tc_group_properties,[{name,domain_admin_muc_light}]},
{tc_group_path,[[{name,domain_admin}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4196/205108/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%40ccc28f7e7cf8.2024-01-05_10.53.58/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-01-05_10.58.19/log_private/"},
{{saved_modules,mongooseim@localhost,<<"localhost">>},
#{mod_vcard =>
#{match... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👌
This PR addresses Issue # 2754 (MIM-2100).
It increases
idle_timeout
in cowboy's requests options for all SSE connections (both REST and GraphQL) to 1 hour. This will ensure that client connections are not closed after 1 minute.