-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version of XEP-0313: Message Archive Management pt. 2 #4225
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4225 +/- ##
==========================================
+ Coverage 84.35% 84.39% +0.03%
==========================================
Files 552 552
Lines 33507 33538 +31
==========================================
+ Hits 28266 28305 +39
+ Misses 5241 5233 -8 ☔ View full report in Codecov by Sentry. |
be046b7
to
456f6d3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
456f6d3
to
2ad8096
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
71f5a32
to
0dfe8c9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
0dfe8c9
to
2b8e96f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good in general. I added a few comments, and I think that the ones in mongoose_data_forms
are the most important.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / db4ed10 small_tests_25 / small_tests / db4ed10 small_tests_26 / small_tests / db4ed10 small_tests_26_arm64 / small_tests / db4ed10 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / db4ed10 ldap_mnesia_25 / ldap_mnesia / db4ed10 ldap_mnesia_26 / ldap_mnesia / db4ed10 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / db4ed10 dynamic_domains_mysql_redis_26 / mysql_redis / db4ed10 internal_mnesia_26 / internal_mnesia / db4ed10 pgsql_cets_26 / pgsql_cets / db4ed10 mysql_redis_26 / mysql_redis / db4ed10 pgsql_mnesia_25 / pgsql_mnesia / db4ed10 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / db4ed10 graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group{error,
{{unregistering_failed,
{amount,1},
{unregistered_items,
[{{<<"_admin_create_room_with_unprepped_domain_1099">>,
[{escalus_event_mgr,<0.24620.0>},
{tc_name,admin_create_room_with_unprepped_domain},
{escalus_cleaner,<0.24619.0>},
{watchdog,<0.24618.0>},
{muc_light_host,<<"muclight.domain.example.com">>},
{secondary_muc_light_host,<<"muclight.domain.example.org">>},
{protocol,http},
{domain_admin,{<<"admin@domain.example.com">>,<<"1e24ce74c525ecff">>}},
{schema_endpoint,domain_admin},
{{ejabberd_cwd,mongooseim@localhost},
"/home/circleci/project/_build/mim1/rel/mongooseim"},
{preset,"odbc_mssql_mnesia"},
{mim_data_dir,
"/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
{tc_logfile,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4225/209378/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4020ad491dc3f6.2024-02-27_11.16.20/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-27_11.20.51/graphql_muc_light_suite.admin_create_room_with_unprepped_domain.54658.html"},
{tc_group_properties,[{name,domain_admin_muc_light}]},
{tc_group_path,[[{name,domain_admin}]]},
{data_dir,
"/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
{priv_dir,
"https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4225/209378/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4020ad491dc3f6.2024-02-27_11.16.20/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-27_11.20.51/log_private/"},
{{saved_modules,mongooseim@localhost,<<"t... pgsql_mnesia_26 / pgsql_mnesia / db4ed10 mssql_mnesia_26 / odbc_mssql_mnesia / db4ed10 ldap_mnesia_25 / ldap_mnesia / db4ed10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR introduces the ability to fetch specific messages by using the
ids
field. Additionally, it includes the advertisement of theurn:xmpp:mam:2#extended
feature, as all the features required by it are now supported.This is a follow-up to an earlier pull request: #4218.