Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of XEP-0313: Message Archive Management pt. 2 #4225

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

jacekwegr
Copy link
Contributor

@jacekwegr jacekwegr commented Feb 19, 2024

This PR introduces the ability to fetch specific messages by using the ids field. Additionally, it includes the advertisement of the urn:xmpp:mam:2#extended feature, as all the features required by it are now supported.

This is a follow-up to an earlier pull request: #4218.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (fbd57db) to head (db4ed10).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4225      +/-   ##
==========================================
+ Coverage   84.35%   84.39%   +0.03%     
==========================================
  Files         552      552              
  Lines       33507    33538      +31     
==========================================
+ Hits        28266    28305      +39     
+ Misses       5241     5233       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr marked this pull request as ready for review February 21, 2024 09:05
Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good in general. I added a few comments, and I think that the ones in mongoose_data_forms are the most important.

big_tests/tests/mam_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/mam_helper.erl Outdated Show resolved Hide resolved
big_tests/tests/mam_SUITE.erl Outdated Show resolved Hide resolved
big_tests/tests/mam_SUITE.erl Outdated Show resolved Hide resolved
src/mongoose_data_forms.erl Outdated Show resolved Hide resolved
src/mam/mod_mam_utils.erl Outdated Show resolved Hide resolved
src/mam/mod_mam_utils.erl Show resolved Hide resolved
src/mam/mod_mam_utils.erl Outdated Show resolved Hide resolved
src/mam/mod_mam_utils.erl Outdated Show resolved Hide resolved
src/mam/mam_iq.erl Outdated Show resolved Hide resolved
@mongoose-im

This comment was marked as outdated.

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

src/mongoose_data_forms.erl Outdated Show resolved Hide resolved
src/mongoose_data_forms.erl Outdated Show resolved Hide resolved
@mongoose-im
Copy link
Collaborator

mongoose-im commented Feb 27, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / db4ed10
Reports root/ big
OK: 429 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0


small_tests_25 / small_tests / db4ed10
Reports root / small


small_tests_26 / small_tests / db4ed10
Reports root / small


small_tests_26_arm64 / small_tests / db4ed10
Reports root / small


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / db4ed10
Reports root/ big
OK: 4463 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / db4ed10
Reports root/ big
OK: 2274 / Failed: 1 / User-skipped: 856 / Auto-skipped: 0

sm_SUITE:ping_timeout
{error,{noproc,{gen_server,call,[<0.27981.1>,get_sm_h]}}}

Report log


ldap_mnesia_26 / ldap_mnesia / db4ed10
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 856 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / db4ed10
Reports root/ big
OK: 4463 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / db4ed10
Reports root/ big
OK: 4430 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / db4ed10
Reports root/ big
OK: 2415 / Failed: 0 / User-skipped: 716 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / db4ed10
Reports root/ big
OK: 4386 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / db4ed10
Reports root/ big
OK: 4831 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / db4ed10
Reports root/ big
OK: 4852 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / db4ed10
Reports root/ big
OK: 4460 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0

graphql_muc_light_SUITE:domain_admin:domain_admin_muc_light:end_per_group
{error,
 {{unregistering_failed,
   {amount,1},
   {unregistered_items,
  [{{<<"_admin_create_room_with_unprepped_domain_1099">>,
     [{escalus_event_mgr,<0.24620.0>},
    {tc_name,admin_create_room_with_unprepped_domain},
    {escalus_cleaner,<0.24619.0>},
    {watchdog,<0.24618.0>},
    {muc_light_host,<<"muclight.domain.example.com">>},
    {secondary_muc_light_host,<<"muclight.domain.example.org">>},
    {protocol,http},
    {domain_admin,{<<"admin@domain.example.com">>,<<"1e24ce74c525ecff">>}},
    {schema_endpoint,domain_admin},
    {{ejabberd_cwd,mongooseim@localhost},
     "/home/circleci/project/_build/mim1/rel/mongooseim"},
    {preset,"odbc_mssql_mnesia"},
    {mim_data_dir,
     "/home/circleci/project/big_tests/tests/graphql_muc_light_SUITE_data"},
    {tc_logfile,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4225/209378/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4020ad491dc3f6.2024-02-27_11.16.20/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-27_11.20.51/graphql_muc_light_suite.admin_create_room_with_unprepped_domain.54658.html"},
    {tc_group_properties,[{name,domain_admin_muc_light}]},
    {tc_group_path,[[{name,domain_admin}]]},
    {data_dir,
     "/home/circleci/project/big_tests/_build/default/lib/mongoose_tests/ebin/graphql_muc_light_SUITE_data/"},
    {priv_dir,
     "https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4225/209378/odbc_mssql_mnesia.26.1.2-amd64/big/ct_run.test%4020ad491dc3f6.2024-02-27_11.16.20/big_tests.tests.graphql_muc_light_SUITE.logs/run.2024-02-27_11.20.51/log_private/"},
    {{saved_modules,mongooseim@localhost,<<"t...

Report log


pgsql_mnesia_26 / pgsql_mnesia / db4ed10
Reports root/ big
OK: 4852 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / db4ed10
Reports root/ big
OK: 4849 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0


ldap_mnesia_25 / ldap_mnesia / db4ed10
Reports root/ big
OK: 2275 / Failed: 0 / User-skipped: 856 / Auto-skipped: 0

Copy link
Member

@chrzaszcz chrzaszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrzaszcz chrzaszcz merged commit 0478cfb into master Feb 27, 2024
4 checks passed
@chrzaszcz chrzaszcz deleted the fetch-specific-msgs-mam branch February 27, 2024 11:58
@jacekwegr jacekwegr added this to the 6.2.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants