-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate migration files #4230
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4230 +/- ##
==========================================
- Coverage 84.37% 84.35% -0.02%
==========================================
Files 552 552
Lines 33484 33484
==========================================
- Hits 28251 28245 -6
- Misses 5233 5239 +6 ☔ View full report in Codecov by Sentry. |
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 5ba68f2 small_tests_25 / small_tests / 5ba68f2 small_tests_26 / small_tests / 5ba68f2 small_tests_26_arm64 / small_tests / 5ba68f2 dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 5ba68f2 ldap_mnesia_25 / ldap_mnesia / 5ba68f2 ldap_mnesia_26 / ldap_mnesia / 5ba68f2 dynamic_domains_mysql_redis_26 / mysql_redis / 5ba68f2 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_589@domain.example.com">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_589@domain.example.com/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_589@domain.example.com/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_589@domain.example.com/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_c... dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 5ba68f2 pgsql_mnesia_25 / pgsql_mnesia / 5ba68f2 internal_mnesia_26 / internal_mnesia / 5ba68f2 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 5ba68f2 muc_SUITE:register:user_unregisters_nick{error,
{{assertion_failed,assert,is_iq_result,
[{xmlel,<<"iq">>,
[{<<"type">>,<<"set">>},
{<<"id">>,<<"21888ca632d3a455c1c6687f0afe9e32">>},
{<<"to">>,<<"groupchats.domain.example.com">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,<<"jabber:iq:register">>}]}]},
{xmlel,<<"field">>,
[{<<"type">>,<<"text-single">>},
{<<"var">>,<<"nick">>}],
[{xmlel,<<"value">>,[],
[{xmlcdata,
<<"thirdwitch1room-7fcf04dcc0">>}]}]}]}]}]}],
{xmlel,<<"iq">>,
[{<<"from">>,<<"groupchats.domain.example.com">>},
{<<"to">>,
<<"alice_user_unregisters_nick_2786@domain.example.com/res1">>},
{<<"type">>,<<"error">>},
{<<"id">>,<<"21888ca632d3a455c1c6687f0afe9e32">>}],
[{xmlel,<<"query">>,
[{<<"xmlns">>,<<"jabber:iq:register">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"jabber:x:data">>},
{<<"type">>,<<"submit">>}],
[{xmlel,<<"field">>,
[{<<"type">>,<<"hidden">>},
{<<"var">>,<<"FORM_TYPE">>}],
... pgsql_cets_26 / pgsql_cets / 5ba68f2 mysql_redis_26 / mysql_redis / 5ba68f2 pgsql_mnesia_26 / pgsql_mnesia / 5ba68f2 mssql_mnesia_26 / odbc_mssql_mnesia / 5ba68f2 small_tests_25 / small_tests / 5ba68f2 dynamic_domains_mysql_redis_26 / mysql_redis / 5ba68f2 dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 5ba68f2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
These were duplicated in two different PRs, unify them here