Instrument/hook handlers: auth - register #4301
Conversation
chrzaszcz
changed the base branch from
feature/instrument
to
instrument/hook-handlers-privacy
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/instrument #4301 +/- ##
===================================================
Coverage 84.76% 84.76%
===================================================
Files 557 557
Lines 33873 33881 +8
===================================================
+ Hits 28711 28719 +8
Misses 5162 5162 ☔ View full report in Codecov by Sentry. |
chrzaszcz
force-pushed
the
instrument/hook-handlers-auth
branch
from
ddda747
to
eeeed78
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / eeeed78 small_tests_25 / small_tests / eeeed78 small_tests_26 / small_tests / eeeed78 small_tests_26_arm64 / small_tests / eeeed78 ldap_mnesia_25 / ldap_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}ldap_mnesia_26 / ldap_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_mysql_redis_26 / mysql_redis / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_cets_26 / pgsql_cets / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}internal_mnesia_26 / internal_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_mnesia_25 / pgsql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}mysql_redis_26 / mysql_redis / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_mnesia_26 / pgsql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}mssql_mnesia_26 / odbc_mssql_mnesia / eeeed78 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'} |
chrzaszcz
changed the title
- 'register' used the hook-related metric; - 'unregister' didn't have any metrics.
It already has the 'auth_anonymous_unregister_user' event.
Note: no hooks are removed - even for remove_user, which has no handlers now. The hook seems to be useful not only for instrumentation.
They are now covered by the events checked in accounts_SUITE
chrzaszcz
force-pushed
the
instrument/hook-handlers-auth
branch
from
eeeed78
to
d2ab907
Compare
|
elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / d2ab907 small_tests_25 / small_tests / d2ab907 small_tests_26 / small_tests / d2ab907 small_tests_26_arm64 / small_tests / d2ab907 ldap_mnesia_25 / ldap_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}ldap_mnesia_26 / ldap_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_mysql_redis_26 / mysql_redis / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}internal_mnesia_26 / internal_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_cets_26 / pgsql_cets / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_mnesia_25 / pgsql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}mysql_redis_26 / mysql_redis / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}pgsql_mnesia_26 / pgsql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'}mssql_mnesia_26 / odbc_mssql_mnesia / d2ab907 ct_framework:error_in_suite{error,'metrics_register_SUITE cannot be compiled or loaded'} |
The goal is to use
mongoose_instrumentfor user registration metrics instead of handlers updatingmongoose_metrics.instrumentationcallback is added tomongoose_gen_auth.accounts_SUITEandanonymous_SUITEare updated, and they cover all events. This means thatmetrics_register_SUITEcan be removed.anonymous_purgeoperation is now instrumented, so this hook doesn't need its instrumentation event anymore.register_userhas no handlers, it looks useful for purposes other than instrumentation.