Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate CircleCI deps cache if the plugin list changes #4346

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Jul 29, 2024

This PR addresses MIM-2265.

It is hard to handle updates of plugins, circleci would always use the cached old version. And rebar.lock is not tracking plugins.

Proposed changes include:

  • Hashing of {plugins, ...}. block. Useful if you are developing or updating plugins
  • Invalidate CircleCI deps cache if the plugin list changes
  • We use base circle ci image for initial template generation, which has no Erlang. So we use sed to match plugins block and we hash it.

Useful if you are developing or updating plugins
@mongoose-im
Copy link
Collaborator

mongoose-im commented Jul 29, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / 78ebda1
Reports root/ big
OK: 439 / Failed: 0 / User-skipped: 47 / Auto-skipped: 0


small_tests_25 / small_tests / 78ebda1
Reports root / small


small_tests_26 / small_tests / 78ebda1
Reports root / small


small_tests_26_arm64 / small_tests / 78ebda1
Reports root / small


ldap_mnesia_25 / ldap_mnesia / 78ebda1
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 78ebda1
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / 78ebda1
Reports root/ big
OK: 2337 / Failed: 0 / User-skipped: 905 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / 78ebda1
Reports root/ big
OK: 4588 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 78ebda1
Reports root/ big
OK: 4621 / Failed: 0 / User-skipped: 111 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / 78ebda1
Reports root/ big
OK: 4618 / Failed: 0 / User-skipped: 114 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / 78ebda1
Reports root/ big
OK: 4532 / Failed: 0 / User-skipped: 178 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / 78ebda1
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / 78ebda1
Reports root/ big
OK: 2477 / Failed: 0 / User-skipped: 765 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 78ebda1
Reports root/ big
OK: 5012 / Failed: 0 / User-skipped: 118 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / 78ebda1
Reports root/ big
OK: 4991 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / 78ebda1
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (4cbb09c) to head (78ebda1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4346   +/-   ##
=======================================
  Coverage   84.33%   84.34%           
=======================================
  Files         553      553           
  Lines       33730    33730           
=======================================
+ Hits        28447    28449    +2     
+ Misses       5283     5281    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review July 29, 2024 21:58
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 👌🏽

@NelsonVides NelsonVides merged commit 9fb5603 into master Jul 30, 2024
4 checks passed
@NelsonVides NelsonVides deleted the invalidate-circleci-cache-with-plugins branch July 30, 2024 04:59
@jacekwegr jacekwegr added this to the 6.3.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants