-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip summarise-ct-results in small tests #4370
Conversation
We use rebar3 for small tests, it is smart enough to fail properly. We also need to pull ct_groups_summary_hook dependency to use summarise-ct-results.
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 77b6f76 small_tests_26 / small_tests / 77b6f76 small_tests_27 / small_tests / 77b6f76 small_tests_27_arm64 / small_tests / 77b6f76 ldap_mnesia_27 / ldap_mnesia / 77b6f76 ldap_mnesia_26 / ldap_mnesia / 77b6f76 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 77b6f76 dynamic_domains_mysql_redis_27 / mysql_redis / 77b6f76 internal_mnesia_27 / internal_mnesia / 77b6f76 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 77b6f76 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 77b6f76 pgsql_cets_27 / pgsql_cets / 77b6f76 pgsql_mnesia_27 / pgsql_mnesia / 77b6f76 pgsql_mnesia_26 / pgsql_mnesia / 77b6f76 mysql_redis_27 / mysql_redis / 77b6f76 sm_SUITE:tcp_tests:parallel_unacknowledged_message_hook:unacknowledged_message_hook_filter{error,{{badmatch,false},
[{escalus_session,stream_resumption,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
{line,259}]},
{escalus_connection,connection_step,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,161}]},
{lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
{escalus_connection,start,2,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
{line,145}]},
{sm_helper,connect_spec,3,
[{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
{line,154}]},
{sm_SUITE,unacknowledged_message_hook_filter,1,
[{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
{line,835}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]}]}} mssql_mnesia_27 / odbc_mssql_mnesia / 77b6f76 mysql_redis_27 / mysql_redis / 77b6f76 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_584@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_584@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_584@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_584@localhost/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... mysql_redis_27 / mysql_redis / 77b6f76 carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_610@localhost">>},
{<<"to">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_610@localhost/res2">>},
{<<"xmlns">>,<<"jabber:client">>},
{<<"type">>,<<"chat">>}],
[{xmlel,<<"sent">>,
[{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
[{xmlel,<<"forwarded">>,
[{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_dropped_client_doesnt_create_duplicate_carbons_610@localhost/res1">>},
{<<"type">>,<<"chat">>},
{<<"to">>,
<<"bob_dropped_client_doesnt_create_duplicate_carbons_610@localhost/res1">>},
{<<"xmlns">>,<<"jabber:client">>}],
[{xmlel,<<"body">>,[],
[{xmlcdata,
<<"And pious action">>}]}]}]}]}]}]},
[{carboncopy_SUITE,
'-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
[{file,
"/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
{line,189}]},
{escalus_story,story,4,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_serv... mysql_redis_27 / mysql_redis / 77b6f76 push_SUITE:pubsub_less:pm_msg_notifications:pm_msg_notify_if_user_offline{skip,
{failed,
{push_SUITE,init_per_testcase,
{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_unnamed_3125">>,<<"localhost">>,<<"matygrysa">>],
3000,mongooseim],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2310}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{push_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,119}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1564}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1265}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} push_SUITE:pubsub_less:pm_msg_notifications:pm_msg_notify_stops_after_disabling{skip,
{failed,
{push_SUITE,init_per_testcase,
{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_unnamed_3126">>,<<"localhost">>,<<"matygrysa">>],
3000,mongooseim],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2310}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{push_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,119}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1564}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1265}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} push_SUITE:pubsub_less:pm_msg_notifications:pm_msg_notify_if_user_offline_with_publish_options{skip,
{failed,
{push_SUITE,init_per_testcase,
{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_unnamed_3127">>,<<"localhost">>,<<"matygrysa">>],
3000,mongooseim],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2310}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{push_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,119}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1564}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1265}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} push_SUITE:pubsub_less:pm_msg_notifications:pm_msg_notify_stops_after_removal{skip,
{failed,
{push_SUITE,init_per_testcase,
{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"alicE_unnamed_3128">>,<<"localhost">>,<<"matygrysa">>],
3000,mongooseim],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2310}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{push_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,119}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1564}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1265}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} push_SUITE:pubsub_less:pm_msg_notifications:pm_no_msg_notifications_if_not_enabled{skip,
{failed,
{push_SUITE,init_per_testcase,
{{badrpc,timeout},
[{escalus_rpc,call_with_cookie_match,
[mongooseim@localhost,ejabberd_admin,register,
[<<"bOb_unnamed_3123">>,<<"localhost">>,<<"makrolika">>],
3000,mongooseim],
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_rpc.erl"},
{line,34}]},
{lists,foreach_1,2,[{file,"lists.erl"},{line,2310}]},
{escalus_ejabberd,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_ejabberd.erl"},
{line,211}]},
{escalus_fresh,create_users,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_fresh.erl"},
{line,62}]},
{push_SUITE,init_per_testcase,2,
[{file,
"/home/circleci/project/big_tests/tests/push_SUITE.erl"},
{line,119}]},
{test_server,do_init_per_testcase,2,
[{file,"test_server.erl"},{line,1564}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1265}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}}}} mysql_redis_27 / mysql_redis / 77b6f76 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4370 +/- ##
==========================================
+ Coverage 84.94% 84.97% +0.02%
==========================================
Files 552 552
Lines 33720 33720
==========================================
+ Hits 28645 28652 +7
+ Misses 5075 5068 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, should fix the problem of failing small tests 👍
This PR addresses:
CI is failing from the recent PR merge:
Proposed changes include:
Hook is not used in small tests, so only basic info printed from summarise-ct-results.
We loose printing the number of groups run, but it is ok, I think (not super useful anyway).