Don't create /usr/lib/mongooseim, because it already exists #4410
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4410 +/- ##
==========================================
- Coverage 85.42% 85.33% -0.10%
==========================================
Files 550 550
Lines 33911 33911
==========================================
- Hits 28969 28937 -32
- Misses 4942 4974 +32 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This issue affected Debian/Ubuntu.
chrzaszcz
force-pushed
the
fix-package-warning
branch
from
2142c2a to
a93c336
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
chrzaszcz
force-pushed
the
fix-package-warning
branch
from
6e5bbfc to
6ed3109
Compare
|
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 6ed3109 small_tests_26 / small_tests / 6ed3109 small_tests_27 / small_tests / 6ed3109 small_tests_27_arm64 / small_tests / 6ed3109 ldap_mnesia_26 / ldap_mnesia / 6ed3109 dynamic_domains_mysql_redis_27 / mysql_redis / 6ed3109 ldap_mnesia_27 / ldap_mnesia / 6ed3109 jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1060@localhost/res1">>},
{<<"id">>,<<"c06566ac-2a67-4811-aa25-1eb83942efd2">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"2635d74a-dade-4ea8-881f-e4eb6871fe78">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_1060@localhost/res1' id='c06566ac-2a67-4811-aa25-1eb83942efd2' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='2635d74a-dade-4ea8-881f-e4eb6871fe78'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/project/big_tests/tests/jingle_SUITE.erl"},
{line,390}]},
{jingle_SUITE,
'-resp_...dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 6ed3109 internal_mnesia_27 / internal_mnesia / 6ed3109 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 6ed3109 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 6ed3109 pgsql_cets_27 / pgsql_cets / 6ed3109 mysql_redis_27 / mysql_redis / 6ed3109 cockroachdb_cets_27 / cockroachdb_cets / 6ed3109 pgsql_mnesia_27 / pgsql_mnesia / 6ed3109 pgsql_mnesia_26 / pgsql_mnesia / 6ed3109 mssql_mnesia_27 / odbc_mssql_mnesia / 6ed3109 |
This issue affected Debian/Ubuntu, resulting in warnings being printed out on installation.
/usr/lib/mongooseim, because it already existsI verified manually, that the issue was present for Debian/Ubuntu before the fix, and that it is gone after the fix (see the CI workflow with packages enabled).
Note: I decided not to add automatic tests. We could add a condition to fail if anything is printed to
stderr, but for me it might be too restrictive, i.e. there might be some unrelated output. I think we could add an automatic check later if we find any similar issue.