-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start CT node as hidden to avoid global doing netsplits #4419
Conversation
mim, mim2 gets connected to fed1 Which should not happen, but global would connect it It reduces the chance of a netsplit a bit
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / fa333ae small_tests_26 / small_tests / fa333ae small_tests_27 / small_tests / fa333ae small_tests_27_arm64 / small_tests / fa333ae ldap_mnesia_27 / ldap_mnesia / fa333ae dynamic_domains_mysql_redis_27 / mysql_redis / fa333ae dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / fa333ae internal_mnesia_27 / internal_mnesia / fa333ae pubsub_SUITE:tree+basic:subscribe_options_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,379}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / fa333ae pgsql_cets_27 / pgsql_cets / fa333ae dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / fa333ae cockroachdb_cets_27 / cockroachdb_cets / fa333ae mysql_redis_27 / mysql_redis / fa333ae pgsql_mnesia_26 / pgsql_mnesia / fa333ae mssql_mnesia_27 / odbc_mssql_mnesia / fa333ae pgsql_mnesia_27 / pgsql_mnesia / fa333ae ldap_mnesia_26 / ldap_mnesia / fa333ae internal_mnesia_27 / internal_mnesia / fa333ae |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4419 +/- ##
==========================================
+ Coverage 85.12% 85.37% +0.24%
==========================================
Files 550 550
Lines 33911 33911
==========================================
+ Hits 28868 28951 +83
+ Misses 5043 4960 -83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Riiiiiiiiiiight, this makes a lot of sense 😄
mim, mim2 get connected to fed1
Which should not happen, but global would connect it It reduces the chance of a netsplit a bit
This PR addresses "MIM-2350".
Verified: manually, by connecting to mim1 and running
nodes()
in the debug shell.Proposed changes include:
Log:
https://esl.github.io/html-zip-reader/PR/4413/247303/ldap_mnesia.26.2.5.4-amd64/big.tar.gz//ct_run.test@1e3d8eb53586.2024-12-05_15.57.32/mongooseim@localhost.log.html#L4084
Fail:
https://esl.github.io/html-zip-reader/PR/4413/247303/ldap_mnesia.26.2.5.4-amd64/big.tar.gz//ct_run.test%401e3d8eb53586.2024-12-05_15.57.32/big_tests.tests.cluster_commands_SUITE.logs/run.2024-12-05_15.58.21/cluster_commands_suite.init_per_group.html