Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start CT node as hidden to avoid global doing netsplits #4419

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

arcusfelis
Copy link
Contributor

@arcusfelis arcusfelis commented Dec 6, 2024

mim, mim2 get connected to fed1
Which should not happen, but global would connect it It reduces the chance of a netsplit a bit

This PR addresses "MIM-2350".

Verified: manually, by connecting to mim1 and running nodes() in the debug shell.

Proposed changes include:

  • It helps with that:
26 when=2024-12-05T15:57:29.709626+00:00 level=error pid=<0.3532.0> at=: unstructured_log="** Connection attempt from node reg1@localhost rejected. Invalid challenge reply. **\
27 " 
28 when=2024-12-05T15:57:29.709940+00:00 level=warning pid=<0.3529.0> at=: unstructured_log="'global' at mongooseim@localhost failed to connect to reg1@localhost\
29 " 
30 when=2024-12-05T15:57:29.710974+00:00 level=warning pid=<0.59.0> at=: unstructured_log="'global' at node mongooseim@localhost disconnected node mongooseim2@localhost in order to prevent overlapping partitions" 
31 when=2024-12-05T15:57:29.711431+00:00 level=warning pid=<0.59.0> at=: unstructured_log="'global' at node mongooseim@localhost disconnected node mongooseim3@localhost in order to prevent overlapping partitions" 
32 when=2024-12-05T15:57:29.711756+00:00 level=warning pid=<0.59.0> at=: unstructured_log="'global' at node mongooseim@localhost disconnected node fed1@localhost in order to prevent overlapping partitions" 

Log:
https://esl.github.io/html-zip-reader/PR/4413/247303/ldap_mnesia.26.2.5.4-amd64/big.tar.gz//ct_run.test@1e3d8eb53586.2024-12-05_15.57.32/mongooseim@localhost.log.html#L4084
Fail:
https://esl.github.io/html-zip-reader/PR/4413/247303/ldap_mnesia.26.2.5.4-amd64/big.tar.gz//ct_run.test%401e3d8eb53586.2024-12-05_15.57.32/big_tests.tests.cluster_commands_SUITE.logs/run.2024-12-05_15.58.21/cluster_commands_suite.init_per_group.html

mim, mim2 gets connected to fed1
Which should not happen, but global would connect it
It reduces the chance of a netsplit a bit
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 6, 2024

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / fa333ae
Reports root/ big
OK: 473 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0


small_tests_26 / small_tests / fa333ae
Reports root / small


small_tests_27 / small_tests / fa333ae
Reports root / small


small_tests_27_arm64 / small_tests / fa333ae
Reports root / small


ldap_mnesia_27 / ldap_mnesia / fa333ae
Reports root/ big
OK: 2352 / Failed: 0 / User-skipped: 912 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / fa333ae
Reports root/ big
OK: 4724 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / fa333ae
Reports root/ big
OK: 4759 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / fa333ae
Reports root/ big
OK: 2493 / Failed: 1 / User-skipped: 770 / Auto-skipped: 0

pubsub_SUITE:tree+basic:subscribe_options_test
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {pubsub_SUITE,'-subscribe_options_test/1-fun-1-',3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,379}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / fa333ae
Reports root/ big
OK: 4759 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / fa333ae
Reports root/ big
OK: 4849 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / fa333ae
Reports root/ big
OK: 4754 / Failed: 0 / User-skipped: 124 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / fa333ae
Reports root/ big
OK: 4849 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / fa333ae
Reports root/ big
OK: 5129 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / fa333ae
Reports root/ big
OK: 5150 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / fa333ae
Reports root/ big
OK: 5145 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / fa333ae
Reports root/ big
OK: 5150 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / fa333ae
Reports root/ big
OK: 2352 / Failed: 0 / User-skipped: 912 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / fa333ae
Reports root/ big
OK: 2494 / Failed: 0 / User-skipped: 770 / Auto-skipped: 0

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (ae7aad7) to head (fa333ae).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4419      +/-   ##
==========================================
+ Coverage   85.12%   85.37%   +0.24%     
==========================================
  Files         550      550              
  Lines       33911    33911              
==========================================
+ Hits        28868    28951      +83     
+ Misses       5043     4960      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arcusfelis arcusfelis marked this pull request as ready for review December 6, 2024 11:55
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riiiiiiiiiiight, this makes a lot of sense 😄

@NelsonVides NelsonVides merged commit 9275853 into master Dec 6, 2024
4 checks passed
@NelsonVides NelsonVides deleted the hidden-ct-node branch December 6, 2024 12:36
@jacekwegr jacekwegr added this to the 6.3.1 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants