-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cth_surefire to report errors in end_per_testcase #4433
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4433 +/- ##
==========================================
+ Coverage 84.84% 85.36% +0.52%
==========================================
Files 549 549
Lines 33875 33875
==========================================
+ Hits 28740 28919 +179
+ Misses 5135 4956 -179 ☔ View full report in Codecov by Sentry. |
f16c5d3
to
c4d16bc
Compare
c4d16bc
to
24021fe
Compare
Note: the 4th argument of post_end_per_testcase (Result) should be {fail, ...} (as documented), but it is actually {failed, ...}.
24021fe
to
37836b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 37836b8 small_tests_26 / small_tests / 37836b8 small_tests_27 / small_tests / 37836b8 small_tests_27_arm64 / small_tests / 37836b8 ldap_mnesia_26 / ldap_mnesia / 37836b8 ldap_mnesia_27 / ldap_mnesia / 37836b8 pubsub_SUITE:tree+basic:publish_only_retract_items_scope_test{error,{{badmatch,false},
[{pubsub_tools,check_response,2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,444}]},
{pubsub_tools,receive_response,3,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,434}]},
{pubsub_tools,receive_and_check_response,4,
[{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
{line,424}]},
{pubsub_SUITE,'-publish_only_retract_items_scope_test/1-fun-0-',2,
[{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
{line,685}]},
{escalus_story,story,4,
[{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1303}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1235}]}]}} internal_mnesia_27 / internal_mnesia / 37836b8 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 37836b8 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 37836b8 dynamic_domains_mysql_redis_27 / mysql_redis / 37836b8 pgsql_cets_27 / pgsql_cets / 37836b8 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 37836b8 mysql_redis_27 / mysql_redis / 37836b8 cockroachdb_cets_27 / cockroachdb_cets / 37836b8 pgsql_mnesia_26 / pgsql_mnesia / 37836b8 pgsql_mnesia_27 / pgsql_mnesia / 37836b8 mssql_mnesia_27 / odbc_mssql_mnesia / 37836b8 ldap_mnesia_27 / ldap_mnesia / 37836b8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update, looks good! 👍
Since the CI build fails if there is any fail in
end_per_testcase
, ourcth_surefire
plugin generating the report should behave the same way.I ran the unit test manually to confirm that the change is working correctly: