-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cleanups #4441
Minor cleanups #4441
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4441 +/- ##
==========================================
+ Coverage 85.30% 85.37% +0.06%
==========================================
Files 550 550
Lines 33886 33883 -3
==========================================
+ Hits 28907 28928 +21
+ Misses 4979 4955 -24 ☔ View full report in Codecov by Sentry. |
c3a73d7
to
1437e22
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1437e22
to
6e9a26c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6e9a26c
to
4357536
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f93f179
to
9408ed3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9408ed3
to
b834f9d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Note that previously we were giving `mongoose_listener_sup` a `mongoose_c2s_listener` supervisor whose only children was a `ranch_sup`. We can instead give this `ranch_sup` directly to `mongoose_c2s_listener`.
b834f9d
to
aca6ad9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
aca6ad9
to
08f53a0
Compare
elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 08f53a0 small_tests_26 / small_tests / 08f53a0 small_tests_27_arm64 / small_tests / 08f53a0 ldap_mnesia_26 / ldap_mnesia / 08f53a0 ldap_mnesia_27 / ldap_mnesia / 08f53a0 dynamic_domains_mysql_redis_27 / mysql_redis / 08f53a0 dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 08f53a0 internal_mnesia_27 / internal_mnesia / 08f53a0 dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 08f53a0 pgsql_cets_27 / pgsql_cets / 08f53a0 cockroachdb_cets_27 / cockroachdb_cets / 08f53a0 mssql_mnesia_27 / odbc_mssql_mnesia / 08f53a0 mysql_redis_27 / mysql_redis / 08f53a0 pgsql_mnesia_26 / pgsql_mnesia / 08f53a0 dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 08f53a0 pgsql_mnesia_27 / pgsql_mnesia / 08f53a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
A few cosmetic changes that can be taken out of the rework for components and merged already to master.