Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups #4441

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Minor cleanups #4441

merged 6 commits into from
Dec 19, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Dec 17, 2024

A few cosmetic changes that can be taken out of the rework for components and merged already to master.

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (f813f94) to head (08f53a0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4441      +/-   ##
==========================================
+ Coverage   85.30%   85.37%   +0.06%     
==========================================
  Files         550      550              
  Lines       33886    33883       -3     
==========================================
+ Hits        28907    28928      +21     
+ Misses       4979     4955      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@NelsonVides NelsonVides force-pushed the minor_cleanups branch 2 times, most recently from f93f179 to 9408ed3 Compare December 18, 2024 07:00
@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

Note that previously we were giving `mongoose_listener_sup` a
`mongoose_c2s_listener` supervisor whose only children was a
`ranch_sup`. We can instead give this `ranch_sup` directly to
`mongoose_c2s_listener`.
@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 18, 2024

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 08f53a0
Reports root/ big
OK: 472 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0


small_tests_26 / small_tests / 08f53a0
Reports root / small


small_tests_27_arm64 / small_tests / 08f53a0
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 08f53a0
Reports root/ big
OK: 2353 / Failed: 0 / User-skipped: 912 / Auto-skipped: 0


ldap_mnesia_27 / ldap_mnesia / 08f53a0
Reports root/ big
OK: 2353 / Failed: 0 / User-skipped: 912 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 08f53a0
Reports root/ big
OK: 4726 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 08f53a0
Reports root/ big
OK: 4761 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 08f53a0
Reports root/ big
OK: 2495 / Failed: 0 / User-skipped: 770 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 08f53a0
Reports root/ big
OK: 4761 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 08f53a0
Reports root/ big
OK: 4850 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 08f53a0
Reports root/ big
OK: 4850 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0


mssql_mnesia_27 / odbc_mssql_mnesia / 08f53a0
Reports root/ big
OK: 5146 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 08f53a0
Reports root/ big
OK: 5130 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / 08f53a0
Reports root/ big
OK: 5151 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 08f53a0
Reports root/ big
OK: 4756 / Failed: 0 / User-skipped: 124 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / 08f53a0
Reports root/ big
OK: 5151 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

@NelsonVides NelsonVides marked this pull request as ready for review December 18, 2024 09:37
Copy link
Member

@telezynski telezynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@telezynski telezynski merged commit 770a362 into master Dec 19, 2024
4 checks passed
@telezynski telezynski deleted the minor_cleanups branch December 19, 2024 12:20
@jacekwegr jacekwegr added this to the 6.3.1 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants