Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restart mongooseim as temporary #4443

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Don't restart mongooseim as temporary #4443

merged 1 commit into from
Dec 19, 2024

Conversation

chrzaszcz
Copy link
Member

It is started as a permanent app, and should stay this way to ensure that the node does not remain running without the app.

@chrzaszcz
Don't restart mongooseim as temporary
9ad2942 
It is started as a permanent app, and should stay this way
to ensure that the node does not remain running without the app.
@mongoose-im
Copy link
Collaborator

mongoose-im commented Dec 18, 2024 •
edited
Loading

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 9ad2942
Reports root/ big
OK: 472 / Failed: 0 / User-skipped: 49 / Auto-skipped: 0

small_tests_26 / small_tests / 9ad2942
Reports root / small

small_tests_27 / small_tests / 9ad2942
Reports root / small

small_tests_27_arm64 / small_tests / 9ad2942
Reports root / small

ldap_mnesia_26 / ldap_mnesia / 9ad2942
Reports root/ big
OK: 2352 / Failed: 1 / User-skipped: 912 / Auto-skipped: 0

pubsub_SUITE:tree+basic:discover_nodes_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {pubsub_SUITE,'-discover_nodes_test/1-fun-0-',2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,302}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1234}]}]}}

Report log

ldap_mnesia_27 / ldap_mnesia / 9ad2942
Reports root/ big
OK: 2352 / Failed: 1 / User-skipped: 912 / Auto-skipped: 0

pubsub_SUITE:tree+basic:publish_test 
{error,{{badmatch,false},
    [{pubsub_tools,check_response,2,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,444}]},
     {pubsub_tools,receive_response,3,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
            {line,424}]},
     {pubsub_SUITE,'-publish_test/1-fun-0-',1,
             [{file,"/home/circleci/project/big_tests/tests/pubsub_SUITE.erl"},
            {line,463}]},
     {escalus_story,story,4,
            [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
             {line,72}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log

dynamic_domains_mysql_redis_27 / mysql_redis / 9ad2942
Reports root/ big
OK: 4726 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 9ad2942
Reports root/ big
OK: 4761 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

internal_mnesia_27 / internal_mnesia / 9ad2942
Reports root/ big
OK: 2495 / Failed: 0 / User-skipped: 770 / Auto-skipped: 0

pgsql_cets_27 / pgsql_cets / 9ad2942
Reports root/ big
OK: 4850 / Failed: 0 / User-skipped: 188 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 9ad2942
Reports root/ big
OK: 4756 / Failed: 0 / User-skipped: 124 / Auto-skipped: 0

mysql_redis_27 / mysql_redis / 9ad2942
Reports root/ big
OK: 5130 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0

cockroachdb_cets_27 / cockroachdb_cets / 9ad2942
Reports root/ big
OK: 4893 / Failed: 3 / User-skipped: 188 / Auto-skipped: 0

pubsub_SUITE:dag+basic:discover_nodes_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_discover_nodes_test_2862@localhost/res1">>,
          escalus_tcp,<0.101946.0>,
          [{event_manager,<0.101804.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_discover_nodes_test_2862">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.101804.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_discover_nodes_test_2862">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_discover_nodes_test_2862">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_discover_nodes_test_2862">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"d2f793c18e6dd3cf">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {escalus_story,story,4,
       [{file,
          ...

Report log

pubsub_SUITE:dag+basic:discover_nodes_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,<<"alice_discover_nodes_test_2883@localhost/res1">>,
          escalus_tcp,<0.102405.0>,
          [{event_manager,<0.102266.0>},
           {server,<<"localhost">>},
           {username,<<"alicE_discover_nodes_test_2883">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.102266.0>},
            {server,<<"localhost">>},
            {username,<<"alicE_discover_nodes_test_2883">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,<<"alice_discover_nodes_test_2883">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,<<"alicE_discover_nodes_test_2883">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"44ff375d4c16a9da">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,424}]},
     {escalus_story,story,4,
       [{file,
          ...

Report log

pubsub_SUITE:dag+manage_subscriptions:retrieve_node_subscriptions_test 
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_retrieve_node_subscriptions_test_2932@localhost/res1">>,
          escalus_tcp,<0.103471.0>,
          [{event_manager,<0.103420.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_retrieve_node_subscriptions_test_2932">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.103420.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_retrieve_node_subscriptions_test_2932">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_retrieve_node_subscriptions_test_2932">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_retrieve_node_subscriptions_test_2932">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"725d4a2764d76065">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,433}]},
     {pubsub_tools,receive_and_check_response,4,
       [{file,"/h...

Report log

pgsql_mnesia_26 / pgsql_mnesia / 9ad2942
Reports root/ big
OK: 5151 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

pgsql_mnesia_27 / pgsql_mnesia / 9ad2942
Reports root/ big
OK: 5151 / Failed: 0 / User-skipped: 128 / Auto-skipped: 0

mssql_mnesia_27 / odbc_mssql_mnesia / 9ad2942
Reports root/ big
OK: 5146 / Failed: 0 / User-skipped: 133 / Auto-skipped: 0

ldap_mnesia_27 / ldap_mnesia / 9ad2942
Reports root/ big
OK: 117 / Failed: 0 / User-skipped: 2 / Auto-skipped: 0

ldap_mnesia_26 / ldap_mnesia / 9ad2942
Reports root/ big
OK: 117 / Failed: 0 / User-skipped: 2 / Auto-skipped: 0

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (d940bea) to head (9ad2942).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4443      +/-   ##
==========================================
- Coverage   85.16%   84.53%   -0.63%     
==========================================
  Files         550      550              
  Lines       33886    33886              
==========================================
- Hits        28859    28647     -212     
- Misses       5027     5239     +212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrzaszcz chrzaszcz marked this pull request as ready for review December 19, 2024 08:16
arcusfelis
arcusfelis approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@arcusfelis arcusfelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@arcusfelis arcusfelis merged commit 4bac0ce into master Dec 19, 2024
3 of 4 checks passed
@arcusfelis arcusfelis deleted the application-start-type branch December 19, 2024 09:04
@jacekwegr jacekwegr added this to the 6.3.1 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcusfelis arcusfelis arcusfelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@chrzaszcz @mongoose-im @arcusfelis @jacekwegr