Riak vcard #460
Merged
Riak vcard #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis is using test branch |
Closed
| @@ -28,3 +29,16 @@ string_to_binary(S) when is_list(S) -> | |||
| end; | |||
| string_to_binary(B) when is_binary(B) -> | |||
| B. | |||
|
|
|||
|
|
|||
| join([], _) -> | |||
There was a problem hiding this comment.
Maybe this could be more optimal:
join(Parts, Sep) when is_integer(Sep) -> join(Parts, <<Sep>>);
join(Parts, Sep) -> join(Parts, Sep, <<>>).
join([], _Sep, Acc) -> Acc;
join([Part], _Sep, Acc) -> <<Acc/binary, Part/binary>>;
join([Part | RParts], Sep, Acc) -> join2(RParts, Sep, <<Acc/binary, Part/binary, Sep/binary>>).There was a problem hiding this comment.
Actually some time ago I saw some micro-benchmarking done by @arcusfelis showing that io_list_to_binary is faster than incrementally built binary.
There was a problem hiding this comment.
Ah, true, I think I saw it too. I wonder if it still holds with current OTP versions (AFAIR those were done with R16).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Riak backend for mod_vcard.
This is done on top of #378