Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash on bad xml input #570

Merged
merged 3 commits into from
Nov 4, 2015

Conversation

sstrigler
Copy link
Contributor

fixes #564

@michalwski
Copy link
Contributor

Thanks for the change. Would perfect if you could write a test case showing there was a problem before and now it's fixed.

@sstrigler
Copy link
Contributor Author

Oh, lol, of course. Not my day. I knew I had forgotten sth. Would have been too easy :p

@sstrigler
Copy link
Contributor Author

And suddenly a rogue testcase appeared.
[ ] continue
[ ] integration

@michalwski
Copy link
Contributor

Hmm, still the error case is not covered somehow. Take a look here: https://coveralls.io/builds/3999189/source?filename=apps%2Fejabberd%2Fsrc%2Fejabberd_receiver.erl#L336

@sstrigler
Copy link
Contributor Author

facepalm

@michalwski
Copy link
Contributor

Thanks @sstrigler :)

michalwski added a commit that referenced this pull request Nov 4, 2015
@michalwski michalwski merged commit 34097d5 into esl:master Nov 4, 2015
@michalwski michalwski mentioned this pull request Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash on bad XML input
2 participants