When unblocking all contacts response should not contain jids #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you please create issue here from the card and reference to it? Or just put the examples from the card in this PR. |
|
Also dialyzer has some suggestions regarding types. |
| @@ -529,10 +534,10 @@ get_blocklist_items(Items) -> | |||
| user_blocks(Blocker, Blockees) when is_list(Blockees) -> | |||
| BlockeeJIDs = [ escalus_utils:jid_to_lower(escalus_client:short_jid(B)) || B <- Blockees ], | |||
| AddStanza = block_users_stanza(BlockeeJIDs), | |||
| ct:pal("add stanza ~p", [AddStanza]), | |||
| %% ct:pal("add stanza ~p", [AddStanza]), | |||
There was a problem hiding this comment.
Let's remove these commented ct:pal calls.
|
According to http://xmpp.org/extensions/xep-0191.html#unblockall When I unblock all sending: <iq id='6w6t1-62' type='set'><unblock xmlns='urn:xmpp:blocking'/></iq>I should receive a push like this: <iq from='gardano@erlang-solutions.com' to='gardano@erlang-solutions.com/9bb69f6dacb33248' id='push' type='set'>
<unblock xmlns='urn:xmpp:blocking'/>
</iq>But I receive this push: <iq from='gardano@erlang-solutions.com' to='gardano@erlang-solutions.com/9bb69f6dacb33248' id='push' type='set'>
<unblock xmlns='urn:xmpp:blocking'>
<item jid='griveroa-inaka@erlang-solutions.com'/>
<item jid='ramabit@erlang-solutions.com'/>
</unblock>
</iq>Where |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the Trello card: "Blocking Command: Bad push received when unblock all"
As stated in XEP-0191, point 3.5, when a user sends an "unblock" stanza without specifying jids to unblock, the server should unblock all contacts and reply with an empty result (no jid list). This PR fixes this.