Updated to match the newest version of the RFC

README.md

@@ -493,7 +493,7 @@ If you specify both **alert** and **data**, target device will receive both noti
 
 ### Healthcheck
 
-MongoosePush exposes a `/healthcheck` endpoint, from which you can get information about the current status of all connections in a `JSON` format, grouped by connection pool. Response structure is described in a following [RFC draft](https://tools.ietf.org/id/draft-inadarei-api-health-check-01.html). An example with 2 pools, one being connected to the service and the other one not, would look like this:
+MongoosePush exposes a `/healthcheck` endpoint, from which you can get information about the current status of all connections in a `JSON` format, grouped by connection pool. The response structure is described in the following [RFC draft](https://inadarei.github.io/rfc-healthcheck/). An example with 2 pools, one being connected to the service and the other one not, would look like this:
 
 ```json
 {
@@ -525,7 +525,7 @@ MongoosePush exposes a `/healthcheck` endpoint, from which you can get informati
   "version": "2"
 }
 ```
-If all the connections are down the response status is `503` and in all the other cases it's `200`.
+If all the connections are down the response status is `503`; in all the other cases, it's `200`.
 
 Please note that it's not recommended to use this frequently as it puts an extra load on the worker processes.
 

lib/mongoose_push_web/controllers/healthcheck_controller.ex

@@ -55,7 +55,7 @@ defmodule MongoosePushWeb.HealthcheckController do
   end
 
   # Response formatted to match the draft RFC for healthcheck endpoints, described here:
-  # https://tools.ietf.org/id/draft-inadarei-api-health-check-01.html
+  # https://inadarei.github.io/rfc-healthcheck/
   defp format_response(connections) do
     {_, pool_infos} = Enum.map_reduce(connections, %{}, &format_pool_info/2)
 
@@ -83,7 +83,7 @@ defmodule MongoosePushWeb.HealthcheckController do
       status: health,
       version: List.to_string(Application.spec(:mongoose_push, :vsn)),
       description: "Health of MongoosePush connections to FCM and APNS services",
-      details: pool_infos
+      checks: pool_infos
     }
   end
 

test/unit/healthcheck_test.exs

@@ -35,7 +35,7 @@ defmodule MongoosePushWeb.HealthcheckTest do
 
       response =
         pools
-        |> Map.fetch!("details")
+        |> Map.fetch!("checks")
         |> Map.fetch!("pool:#{pool_name}")
         |> List.first()
         |> Map.fetch!("output")
@@ -86,7 +86,7 @@ defmodule MongoosePushWeb.HealthcheckTest do
 
         response =
           pools
-          |> Map.fetch!("details")
+          |> Map.fetch!("checks")
           |> Map.fetch!("pool:#{pool_name}")
           |> List.first()
           |> Map.fetch!("output")
@@ -102,7 +102,7 @@ defmodule MongoosePushWeb.HealthcheckTest do
 
         response =
           pools
-          |> Map.fetch!("details")
+          |> Map.fetch!("checks")
           |> Map.fetch!("pool:#{pool_name}")
           |> List.first()
           |> Map.fetch!("output")
@@ -163,7 +163,7 @@ defmodule MongoosePushWeb.HealthcheckTest do
 
         response =
           pools
-          |> Map.fetch!("details")
+          |> Map.fetch!("checks")
           |> Map.fetch!("pool:#{pool_name}")
           |> List.first()
           |> Map.fetch!("output")
@@ -179,7 +179,7 @@ defmodule MongoosePushWeb.HealthcheckTest do
 
         response =
           pools
-          |> Map.fetch!("details")
+          |> Map.fetch!("checks")
           |> Map.fetch!("pool:#{pool_name}")
           |> List.first()
           |> Map.fetch!("output")